From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC42248B69 for ; Fri, 21 Nov 2025 12:24:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A74B94026F; Fri, 21 Nov 2025 12:24:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 674484026F for ; Fri, 21 Nov 2025 12:24:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QshFDOjZ23OZBEumNf20tFBrfptyz6JJeey+feSwDr0=; b=O09X1wmaJGHfVHmUO5M/krbF8mgEYbNLkGa1HwqlAPrwkZOWmabdUQoWDzJBpJGBqqPzow kRppG6+78ksdrtULuwZtp4Vq8y6ynHl83YGjK/roIHAIZlP4TAmKOWXzO9uuEiwaZl1TdM MzSNuTVyCP2zSe9u44SfKMVYdI297z4= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-4vCYkzFnOnC8KgVSwpnInA-1; Fri, 21 Nov 2025 06:24:14 -0500 X-MC-Unique: 4vCYkzFnOnC8KgVSwpnInA-1 X-Mimecast-MFC-AGG-ID: 4vCYkzFnOnC8KgVSwpnInA_1763724253 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D1859180049F; Fri, 21 Nov 2025 11:24:13 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A040E30044DC; Fri, 21 Nov 2025 11:24:12 +0000 (UTC) From: Kevin Traynor To: Satha Rao Cc: dpdk stable Subject: patch 'common/cnxk: fix null SQ access' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:21:00 +0000 Message-ID: <20251121112128.485623-76-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 419MgJBSF6vzroJUNeE-QVW7gJ7WtQAHviKhT7wlCF8_1763724253 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4d8505348c48426722d3c8fd6a54dd543aef7c45 Thanks. Kevin --- >From 4d8505348c48426722d3c8fd6a54dd543aef7c45 Mon Sep 17 00:00:00 2001 From: Satha Rao Date: Thu, 13 Nov 2025 10:08:01 +0530 Subject: [PATCH] common/cnxk: fix null SQ access [ upstream commit 52ff61c2ca114691d74546f5ce16e8a7ebd164ae ] Condition to check SQ is non NULL before access. Also pktio locks are simplified while doing threshold_profile config. Fixes: 90a903ffa6eb ("common/cnxk: split NIX TM hierarchy enable API") Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_nix_tm_ops.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c index b89f08ac66..c5dfdb0122 100644 --- a/drivers/common/cnxk/roc_nix_tm_ops.c +++ b/drivers/common/cnxk/roc_nix_tm_ops.c @@ -619,4 +619,11 @@ roc_nix_tm_hierarchy_xmit_enable(struct roc_nix *roc_nix, enum roc_nix_tm_tree t sq = nix->sqs[sq_id]; + if (!sq) { + plt_err("nb_rxq %d nb_txq %d sq_id %d lvl %d", nix->nb_rx_queues, + nix->nb_tx_queues, sq_id, node->lvl); + roc_nix_tm_dump(roc_nix, NULL); + roc_nix_dump(roc_nix, NULL); + return NIX_ERR_TM_INVALID_NODE; + } rc = roc_nix_sq_ena_dis(sq, true); if (rc) { -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:11.931293727 +0000 +++ 0076-common-cnxk-fix-null-SQ-access.patch 2025-11-21 11:05:09.556201566 +0000 @@ -1 +1 @@ -From 52ff61c2ca114691d74546f5ce16e8a7ebd164ae Mon Sep 17 00:00:00 2001 +From 4d8505348c48426722d3c8fd6a54dd543aef7c45 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 52ff61c2ca114691d74546f5ce16e8a7ebd164ae ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -18 +19 @@ -index 09d014a276..230e9b72f6 100644 +index b89f08ac66..c5dfdb0122 100644 @@ -21 +22 @@ -@@ -625,4 +625,11 @@ roc_nix_tm_hierarchy_xmit_enable(struct roc_nix *roc_nix, enum roc_nix_tm_tree t +@@ -619,4 +619,11 @@ roc_nix_tm_hierarchy_xmit_enable(struct roc_nix *roc_nix, enum roc_nix_tm_tree t