From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4324448B69 for ; Fri, 21 Nov 2025 12:24:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D1B34026F; Fri, 21 Nov 2025 12:24:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BD749402ED for ; Fri, 21 Nov 2025 12:24:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lgGEK+LwgpACf9VU1ITDLylnWTqSRKtZpiH/nRN+3b8=; b=D3m5wZgaTI6eQEbWHH29uCVGpsaSMGf9ie3ge+KytqIdm2p7OsS5s71tox0E9GmGI6gEWK a3Cym0gy8cjV0/vOSiG6QJ5l6u+K5mqNYKfyW3VDrm8oTS/CNn58aDIh+CN9YZ0jJXsJSc WM1iTGJaQMAoUZzDSbnHnjDag5L9qy8= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-1eeNUCDgOMCWlTL0kxxc0A-1; Fri, 21 Nov 2025 06:24:22 -0500 X-MC-Unique: 1eeNUCDgOMCWlTL0kxxc0A-1 X-Mimecast-MFC-AGG-ID: 1eeNUCDgOMCWlTL0kxxc0A_1763724261 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4F0B91954204; Fri, 21 Nov 2025 11:24:21 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 774E430044DB; Fri, 21 Nov 2025 11:24:20 +0000 (UTC) From: Kevin Traynor To: Emma Finn Cc: dpdk stable Subject: patch 'crypto/qat: fix CCM request descriptor hash state size' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:21:05 +0000 Message-ID: <20251121112128.485623-81-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gFeW1nWWKNBTudUwaMpymoko-26vAHYiQhx3Cw3TXMw_1763724261 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/802e08bd04013c3d36e6422f811a1787ddc6af44 Thanks. Kevin --- >From 802e08bd04013c3d36e6422f811a1787ddc6af44 Mon Sep 17 00:00:00 2001 From: Emma Finn Date: Wed, 12 Nov 2025 10:19:10 +0000 Subject: [PATCH] crypto/qat: fix CCM request descriptor hash state size [ upstream commit 3ffcfc48040a076643ec58c5f53b77069305afda ] The hash_state_sz field in the QAT request descriptor for AES-CCM operations was incorrectly set to the digest length. According to the QAT firmware specification, this field should contain the length of AAD in quadwords for CCM operations. Fixes: ab56c4d9ed9a ("crypto/qat: support AES-CCM") Signed-off-by: Emma Finn --- drivers/crypto/qat/qat_sym_session.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index 5a4bac8c46..dd9921769c 100644 --- a/drivers/crypto/qat/qat_sym_session.c +++ b/drivers/crypto/qat/qat_sym_session.c @@ -2794,5 +2794,6 @@ static int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, hash_cd_ctrl->outer_prefix_sz = digestsize; - auth_param->hash_state_sz = digestsize; + auth_param->hash_state_sz = (RTE_ALIGN_CEIL(auth_param->u2.aad_sz, + ICP_QAT_HW_CCM_AAD_ALIGNMENT) >> 3); memcpy(cdesc->cd_cur_ptr + state1_size, authkey, authkeylen); -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:12.072146517 +0000 +++ 0081-crypto-qat-fix-CCM-request-descriptor-hash-state-siz.patch 2025-11-21 11:05:09.562201591 +0000 @@ -1 +1 @@ -From 3ffcfc48040a076643ec58c5f53b77069305afda Mon Sep 17 00:00:00 2001 +From 802e08bd04013c3d36e6422f811a1787ddc6af44 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3ffcfc48040a076643ec58c5f53b77069305afda ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 98ab82ffb3..2ba4fc0a3a 100644 +index 5a4bac8c46..dd9921769c 100644 @@ -23 +24 @@ -@@ -2775,5 +2775,6 @@ static int qat_sym_cd_auth_set(struct qat_sym_session *cdesc, +@@ -2794,5 +2794,6 @@ static int qat_sym_cd_auth_set(struct qat_sym_session *cdesc,