From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9D5048B69 for ; Fri, 21 Nov 2025 12:24:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3BD24026F; Fri, 21 Nov 2025 12:24:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0667D402E0 for ; Fri, 21 Nov 2025 12:24:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=glGVvRvIs7aAQ6QN8StjnxkqUUFyx1zm2RUIuhrIwc4=; b=ZCISRRdN2+KEZLzEZ62oc4YWT1ImomrA6ZGsvRKab8W2BwoZZImKtP14G5ig44lWczyjy1 PkUik0UCp+FPRl2w16HfGKgQc+RcyZBtQSNI7X1c6USfGCIiZ79cWzw5stAFaiaGBcKy0z 3idEy0gqBfAOWLtu4uJvlgxIn5SQFRs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-393-0OdzO-yqMbCvxi2NPDL-eQ-1; Fri, 21 Nov 2025 06:24:30 -0500 X-MC-Unique: 0OdzO-yqMbCvxi2NPDL-eQ-1 X-Mimecast-MFC-AGG-ID: 0OdzO-yqMbCvxi2NPDL-eQ_1763724269 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 80E4C19560B0; Fri, 21 Nov 2025 11:24:29 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EB00430044DC; Fri, 21 Nov 2025 11:24:27 +0000 (UTC) From: Kevin Traynor To: Gavin Li Cc: Bing Zhao , dpdk stable Subject: patch 'net/mlx5: fix IPv6 DSCP offset in HWS sync API' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:21:09 +0000 Message-ID: <20251121112128.485623-85-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KoIFE5k7WT_4ERcDFaD2lNC2G4ph8yfUjHGNEWCH0kA_1763724269 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/35678b1c4c3503cb33dff3c74e42718c622f15e9 Thanks. Kevin --- >From 35678b1c4c3503cb33dff3c74e42718c622f15e9 Mon Sep 17 00:00:00 2001 From: Gavin Li Date: Wed, 12 Nov 2025 15:42:36 +0200 Subject: [PATCH] net/mlx5: fix IPv6 DSCP offset in HWS sync API [ upstream commit 15501c4298ea029b4252b8194daa574d4e02df20 ] The processing of field IPv6 DSCP via the synchronous flow API is different between software and hardware steering engines (HWS). The bit shift handling for IPv6 DSCP was not handled in HWS, resulting in incorrect data in the field. To resolve this, bit shift handling should be added to HWS. Fixes: ec1e7a5ceb69 ("net/mlx5: update IPv6 traffic class modification") Signed-off-by: Gavin Li Acked-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow.h | 7 +++++++ drivers/net/mlx5/mlx5_flow_dv.c | 6 ------ drivers/net/mlx5/mlx5_flow_hw.c | 5 +++++ 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index cfdaaac812..5f154add0d 100644 --- a/drivers/net/mlx5/mlx5_flow.h +++ b/drivers/net/mlx5/mlx5_flow.h @@ -3647,4 +3647,11 @@ flow_hw_get_ipv6_route_ext_mod_id_from_ctx(void *dr_ctx, uint8_t idx) return 0; } + +static inline bool +mlx5_dv_modify_ipv6_traffic_class_supported(struct mlx5_priv *priv) +{ + return priv->sh->phdev->config.ipv6_tc_fallback == MLX5_IPV6_TC_OK; +} + void mlx5_indirect_list_handles_release(struct rte_eth_dev *dev); diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index f5dbb06cd5..c8b17c0f3a 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -1639,10 +1639,4 @@ mlx5_modify_flex_item(const struct rte_eth_dev *dev, } -static inline bool -mlx5_dv_modify_ipv6_traffic_class_supported(struct mlx5_priv *priv) -{ - return priv->sh->phdev->config.ipv6_tc_fallback == MLX5_IPV6_TC_OK; -} - void mlx5_flow_field_id_to_modify_info diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 667472800f..e4a67a0c1a 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -1596,4 +1596,9 @@ flow_hw_modify_field_compile(struct rte_eth_dev *dev, value = rte_cpu_to_be_32(value); item.spec = &value; + } else if (conf->dst.field == RTE_FLOW_FIELD_IPV6_DSCP && + !(mask[0] & MLX5_IPV6_HDR_ECN_MASK) && + mlx5_dv_modify_ipv6_traffic_class_supported(dev->data->dev_private)) { + value = *(const unaligned_uint32_t *)item.spec << MLX5_IPV6_HDR_DSCP_SHIFT; + item.spec = &value; } } else { -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:12.203761422 +0000 +++ 0085-net-mlx5-fix-IPv6-DSCP-offset-in-HWS-sync-API.patch 2025-11-21 11:05:09.587201698 +0000 @@ -1 +1 @@ -From 15501c4298ea029b4252b8194daa574d4e02df20 Mon Sep 17 00:00:00 2001 +From 35678b1c4c3503cb33dff3c74e42718c622f15e9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 15501c4298ea029b4252b8194daa574d4e02df20 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 26d9e80a13..e332226fff 100644 +index cfdaaac812..5f154add0d 100644 @@ -28 +29 @@ -@@ -3715,4 +3715,11 @@ flow_hw_get_ipv6_route_ext_mod_id_from_ctx(void *dr_ctx, uint8_t idx) +@@ -3647,4 +3647,11 @@ flow_hw_get_ipv6_route_ext_mod_id_from_ctx(void *dr_ctx, uint8_t idx) @@ -41 +42 @@ -index 95ca57e8c4..83046418c4 100644 +index f5dbb06cd5..c8b17c0f3a 100644 @@ -56 +57 @@ -index de400536c7..e0f79932a5 100644 +index 667472800f..e4a67a0c1a 100644 @@ -59 +60 @@ -@@ -1626,4 +1626,9 @@ flow_hw_modify_field_compile(struct rte_eth_dev *dev, +@@ -1596,4 +1596,9 @@ flow_hw_modify_field_compile(struct rte_eth_dev *dev,