From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3E3348B69 for ; Fri, 21 Nov 2025 12:24:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A320440431; Fri, 21 Nov 2025 12:24:46 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AA080402E0 for ; Fri, 21 Nov 2025 12:24:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763724285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=42In9ce3+KRrqU572nxKGqw6UZBizgCmufpV5i9rSjA=; b=cMfyuU0pQjYtZyBmPqy1vu7G3C6CwF/sfOOHOqQTziWrfZstZTtvN9moPZj5AACcqcl5QU uSF4Li6pb4yAw/SocwtA4oclYUn0CjqH+cVIxUBZXlS91gxeBedR7fpKL8ipjz5ZEO7ylZ JyvdqFaqTxhHQQqXyyZmviRB6t2544o= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-270-2pR_Ib2ZMMGHDkGIkEdiQQ-1; Fri, 21 Nov 2025 06:24:40 -0500 X-MC-Unique: 2pR_Ib2ZMMGHDkGIkEdiQQ-1 X-Mimecast-MFC-AGG-ID: 2pR_Ib2ZMMGHDkGIkEdiQQ_1763724279 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 24973180047F; Fri, 21 Nov 2025 11:24:39 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.165]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C523F30044DB; Fri, 21 Nov 2025 11:24:37 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Raslan Darawsheh , dpdk stable Subject: patch 'net/mlx5: fix uninitialized variable' has been queued to stable release 24.11.4 Date: Fri, 21 Nov 2025 11:21:14 +0000 Message-ID: <20251121112128.485623-90-ktraynor@redhat.com> In-Reply-To: <20251121112128.485623-1-ktraynor@redhat.com> References: <20251121112128.485623-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: CTGppsk2-YhcttyAujtynDiWtzSTCZGfxHacq4QT7zw_1763724279 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/4a531c127f89720480afb3daf869e09028376d9e Thanks. Kevin --- >From 4a531c127f89720480afb3daf869e09028376d9e Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 14 Nov 2025 09:49:12 -0800 Subject: [PATCH] net/mlx5: fix uninitialized variable [ upstream commit 7429374afba9827a43cf2efabce14e27ccc4bdef ] Gcc-16 detects use of uninitialized variable. If the retry loop exits the code would do memcmp against uninitialized stack value. Resolve by initializing to zero. Bugzilla ID: 1823 Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions") Fixes: cfee94752b8f ("net/mlx5: fix link status to use wait to complete") Signed-off-by: Stephen Hemminger Acked-by: Raslan Darawsheh --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c index a5dda1e5f1..5235066e35 100644 --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c @@ -512,5 +512,5 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) { int ret; - struct rte_eth_link dev_link; + struct rte_eth_link dev_link = { 0 }; time_t start_time = time(NULL); int retry = MLX5_GET_LINK_STATUS_RETRY_COUNT; @@ -1966,3 +1966,2 @@ int mlx5_txpp_map_hca_bar(struct rte_eth_dev *dev) return 0; } - -- 2.51.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-21 11:05:12.347261206 +0000 +++ 0090-net-mlx5-fix-uninitialized-variable.patch 2025-11-21 11:05:09.594201728 +0000 @@ -1 +1 @@ -From 7429374afba9827a43cf2efabce14e27ccc4bdef Mon Sep 17 00:00:00 2001 +From 4a531c127f89720480afb3daf869e09028376d9e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7429374afba9827a43cf2efabce14e27ccc4bdef ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 4d8fbed188..50997c187c 100644 +index a5dda1e5f1..5235066e35 100644 @@ -25 +26 @@ -@@ -513,5 +513,5 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) +@@ -512,5 +512,5 @@ mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) @@ -32 +33 @@ -@@ -2074,3 +2074,2 @@ int mlx5_txpp_map_hca_bar(struct rte_eth_dev *dev) +@@ -1966,3 +1966,2 @@ int mlx5_txpp_map_hca_bar(struct rte_eth_dev *dev)