From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA90B48B6C for ; Fri, 21 Nov 2025 18:10:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01E6B40653; Fri, 21 Nov 2025 18:10:06 +0100 (CET) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id BD023402EE for ; Fri, 21 Nov 2025 18:09:57 +0100 (CET) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-b98983baeacso1200311a12.1 for ; Fri, 21 Nov 2025 09:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1763744997; x=1764349797; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WmT0N/n74EPEE6smaUUFOrqeqMbkWMQqkiLgpTfyWr0=; b=odSim114r/5VIAEf3QgOu1L0CuyXmoIwKN6u1JszoAvvIuHKPkufLmAVH7/VuqQx26 G2WMWWUw+sNmGtEotlto7vQoNI1u/qFS7sZCdUpExHV018wuU9UvpIfLxbt0SZ45jlv9 szKNW7WgakolSwFwCOTtp6wcqoQBeSedkGLnPwc33MdW+N54pv3zHWWWKwnRTrO/sV7X 556nEXmef+rQwqDLWrLXCzNuwIy0xoLtlpKriniYTkz3buzgx1QMRmSgjXoW8l4fItIu is+4olKEkl6K1WSzdqeJsi1o0aielyJZ1qSRu4uca3+uW7DvZbm7MMCZnddCWmixZTDq 8GUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763744997; x=1764349797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WmT0N/n74EPEE6smaUUFOrqeqMbkWMQqkiLgpTfyWr0=; b=PI42Ke3MTGSGS7VHg3LzvuPt+kM381eQ3FfeAxLJWN4TlwpK1k7JHJmLMxDlsUIgAq sFq85z6KretxaBls3sieimiVLS4i9H7tehaM0em+hXtzM7pPNWiuTAa6duoA64JfZxnY DsInYhNrgdDtwld/1t++1yp+ADK6HwhQo1/S3jkgf0I4tZnbEtT+bh6TZIk19AnIV+ok MpzfAkpFI9dl+z9jL8QsIh44WWrgL1R7THphqQmH3GIRRov65CFB2LcKoo/ftDeyRhoW K1H84PMOEaPwwFz3FpRzSOXmiRezXfwcywXG3LwnvISCPwzXQXgcLsVKrczrMGnSrRGt VHJw== X-Forwarded-Encrypted: i=1; AJvYcCU4+2BemnHLbXqvV1j5CGD6IFyHLBJBUZ1zuFrwAJ5FNGfy5QjimaDFNcFC7JR8+5v3vXyOvbk=@dpdk.org X-Gm-Message-State: AOJu0YxN0wAXN80svZbWX0+7ciQj3NjZ8jmeKLFHCWcqQpzqe3SWIYMm 3EJ8nT1ptnmz0IKNLVz3EOihbgS4hmKTeaGT1aayBRRo4ORFsit3ftVuTQEKwYg2xdGFwcJeJ4h nxGFA X-Gm-Gg: ASbGnctbIoeHuDk/O3YVjuT2gKltlcuguXak9tl5QDhf80tHsUfaetU+ByteKY2G5l4 Eth7zFSYQT0VyRBPnO9nxJQUBQJSUq6ByXrIzYO842u75NjnjIPR1DUoPedfC0+AeDiuiofa7vE d6PVHGYEopkeq6eelGyIjQN4eGjEOn2wlA6S+ctwTuM198NlpHu4kG2x3dSpGsosLfSfLDehveS sOfBISmhvoBLx/bRu4Jpy7ZBk3Doy2/LrAAfE5rq91K9RA8dVKltxy/0l8XMY52a9rou1CPH+oF Wo1mU4TTjDnCji3WwsZry2mimdvUCqA4/Y+DvcTABVj6/O+mpjAVBPfGJzeIu4mt3yi9mISdbtL 91NeZo/op6rl75ebQRwahBYyWGMBTepI/GLPZmT/RbHRl092r7yDH6LMCNBeLkE7l17lhyj9N+/ b2WFOM3uGY+KhnCQHZ0/8WjOWSVjpo1C/cbTIDxCgzdFozkbmmPA== X-Google-Smtp-Source: AGHT+IHfFjysxU/q57WTOwq297MR34aYb0J0Ah5+yiAO1Y305FZGWNFFLyOnlZ6jEv5DqUWh2Ja4YA== X-Received: by 2002:a05:693c:8016:b0:2a4:3593:ddd3 with SMTP id 5a478bee46e88-2a7193c9fd0mr829525eec.0.1763744996653; Fri, 21 Nov 2025 09:09:56 -0800 (PST) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a6fc5b122dsm21341544eec.5.2025.11.21.09.09.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Nov 2025 09:09:56 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Anatoly Burakov , Cristian Dumitrescu , Bruce Richardson Subject: [PATCH v5 6/8] test: fix impossible format-truncation in cfgfiles Date: Fri, 21 Nov 2025 09:08:25 -0800 Message-ID: <20251121170947.134502-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251121170947.134502-1-stephen@networkplumber.org> References: <20251110182209.104087-1-stephen@networkplumber.org> <20251121170947.134502-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Although, it is not possible on Linux (which always uses /tmp) the compiler complains about possible snprintf() truncation. Use existing code to make empty tmp file which puts the OS specific code in one spot and avoids any races if two tests are run at once. Fixes: be22019a58c4 ("test: restore cfgfile tests") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- app/test/test_cfgfile.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/test/test_cfgfile.c b/app/test/test_cfgfile.c index b189d9d7a5..eabf155404 100644 --- a/app/test/test_cfgfile.c +++ b/app/test/test_cfgfile.c @@ -178,12 +178,8 @@ test_cfgfile_realloc_sections(void) ret = remove(filename); TEST_ASSERT_SUCCESS(ret, "Failed to remove file"); - char tmp[PATH_MAX] = "/tmp/"; -#ifdef RTE_EXEC_ENV_WINDOWS - ret = GetTempPathA(sizeof(tmp), tmp); - TEST_ASSERT(ret > 0, "Failed to get tmp directory"); -#endif - snprintf(filename, sizeof(filename), "%s%s", tmp, "cfg_save.ini"); + ret = make_tmp_file(filename, "save", ""); + TEST_ASSERT(ret == 0, "Failed to make empty tmp filename for save"); ret = rte_cfgfile_save(cfgfile, filename); TEST_ASSERT_SUCCESS(ret, "Failed to save to %s", filename); -- 2.51.0