From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79C4848B8C for ; Sun, 23 Nov 2025 18:45:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6961840650; Sun, 23 Nov 2025 18:45:25 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 4A818402E1 for ; Sun, 23 Nov 2025 18:45:11 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-29555415c5fso39509575ad.1 for ; Sun, 23 Nov 2025 09:45:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1763919910; x=1764524710; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WmT0N/n74EPEE6smaUUFOrqeqMbkWMQqkiLgpTfyWr0=; b=j1D45Yyt5ioTSS4LO8vrOSdEjc6DZoNclE9+4k2l4nwApMY2kLg/BCxDDI7Pf36iD0 Zr/WqLmUM5cwOP2oCl1GCLjXka8hANJNIkjieS4mxSqPuigNJTUR3VRurZxyIMLsGrkD 4wjyUMSo1U+ufgdkud4DBQ4YhdgCS6mvtNDgAbVR59ICHvVKjirttQEQZzs4W5bHWvLU yIoPgNC13n6fS53LzDhjYvPxYQi32l8wsmInNbsX699Au8QLdxXf44Q+SGCxSOcBcM3u cW9VRmgn22g15vVYv5Rcvau0nRe4QIzRAnD5MXu4Z+tY27A9b8qxjrvXhJDJW84g3isG znIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763919910; x=1764524710; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WmT0N/n74EPEE6smaUUFOrqeqMbkWMQqkiLgpTfyWr0=; b=rQ0H5xR28JOCZ0t5fENu3+TiM5KF+0xP9+kORRDsgi672aWSd55p4VTljITXWLqHqb qxKAkfi89vV3WHL5Xwq8XbL+Oh2xPcjmRCQUC/Lk8fcOmUZTOO4tfcPXSNi7/RzKgK2x qBwp+itoLhOFxmNpjyk6FsEql2J0A4V9mRNEBZDM9GRGw1Gf0VlM5l4QIe/zbbzkpjKV Hfl97AY7fDvUGP+F/sLev9dk20UJhCJyLqJKlO9bH1vvKWi+SvzgSjKwjg3o+al4S+Yg fDa1oi0r9+chkoGAFyNOvV+aD8oZ5J1f4DYfk3SmyOPYiDD0DpcTnB9gLSNG3rqjPILH FP8A== X-Forwarded-Encrypted: i=1; AJvYcCX0SK2JlzOQp8zHN22cfCwNHmtMDzKSbLEgEDM1I4wDYh6r8ieeYoh9IMHW/GeKDVmlL1YkJbQ=@dpdk.org X-Gm-Message-State: AOJu0Yw7D1n0xSSjpdCxc1MvdAy6uxn3gEWv8scYUtIfLkBT6z/RJP+A 3G7lO3zG86oelwbVRJPyXu5Qhctu8Ov61zMB7LnCHERWDb+nCYxv0kdLyy2VE/r66hInFWFDRuj +WwQI X-Gm-Gg: ASbGncvGxocaDZSORmw2yzcM9HnkCU2Rbt1NLNq4F2WoM0UeTwI6qXhe8GQj0EnmOGG gQsc1Qdr+HRdtJZvBsCEcrXpCMMd8w4XY4t/YeTHjiarRv6+jy+Zl5rxN5jSOdb+YHO9DeqGk55 gaFjov9AK+/jvpOURwmXGz13OEeNVQsAtt7WKP8oPzMrt7HnmsMNoORNJjPkzKT7cFqPBC916pq hecZ25KWIlBN5N1VLuk3n0PlTOduOJ5Dq6EzCnXVWBgZYTAtRc+5MSdBbpPiDZvR47XtvVKM61v PFo0xR7DFLdunvkOqmN2oEnG8bsa/ifc+jKDcO2zYQTVLcKX8+8fEX2iR5U+OHPjalvCsTcoqt/ bVv2MyxpAAALwozKWY2VwRQ/KS88P5RXw3TYX5Cr6rVbbw6Lqp7bN8vQC6OHpgytC6Ze2SAXO18 SrU43p6fCeYNrRyrsRuV4PA69E2iSdRv68QWk/r24NAvfrgz+B0Q== X-Google-Smtp-Source: AGHT+IFdYvOvDROEXjVsudSVOy4N5JlfsAz2ffiQBePCQt9TSKZCoqJSGVFURrAg+zvKeIQzbXTE3A== X-Received: by 2002:a17:903:178e:b0:295:543a:f7e3 with SMTP id d9443c01a7336-29b6c53992cmr107718775ad.27.1763919910478; Sun, 23 Nov 2025 09:45:10 -0800 (PST) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b13b973sm112585985ad.39.2025.11.23.09.45.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Nov 2025 09:45:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Anatoly Burakov , Cristian Dumitrescu , Bruce Richardson Subject: [PATCH v6 6/9] test: fix impossible format-truncation in cfgfiles Date: Sun, 23 Nov 2025 09:43:29 -0800 Message-ID: <20251123174503.20880-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251123174503.20880-1-stephen@networkplumber.org> References: <20251110182209.104087-1-stephen@networkplumber.org> <20251123174503.20880-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Although, it is not possible on Linux (which always uses /tmp) the compiler complains about possible snprintf() truncation. Use existing code to make empty tmp file which puts the OS specific code in one spot and avoids any races if two tests are run at once. Fixes: be22019a58c4 ("test: restore cfgfile tests") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- app/test/test_cfgfile.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/test/test_cfgfile.c b/app/test/test_cfgfile.c index b189d9d7a5..eabf155404 100644 --- a/app/test/test_cfgfile.c +++ b/app/test/test_cfgfile.c @@ -178,12 +178,8 @@ test_cfgfile_realloc_sections(void) ret = remove(filename); TEST_ASSERT_SUCCESS(ret, "Failed to remove file"); - char tmp[PATH_MAX] = "/tmp/"; -#ifdef RTE_EXEC_ENV_WINDOWS - ret = GetTempPathA(sizeof(tmp), tmp); - TEST_ASSERT(ret > 0, "Failed to get tmp directory"); -#endif - snprintf(filename, sizeof(filename), "%s%s", tmp, "cfg_save.ini"); + ret = make_tmp_file(filename, "save", ""); + TEST_ASSERT(ret == 0, "Failed to make empty tmp filename for save"); ret = rte_cfgfile_save(cfgfile, filename); TEST_ASSERT_SUCCESS(ret, "Failed to save to %s", filename); -- 2.51.0