From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A95BC48BAB for ; Tue, 25 Nov 2025 16:06:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1EE740B9B; Tue, 25 Nov 2025 16:06:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5E3BA40B9B for ; Tue, 25 Nov 2025 16:06:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764083176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8O0dkD3GAVc3FmLSiPBqJ7aTPy68xanhodOvmNOy+xc=; b=A/fcqLP6q7cGC2CMn/zXgag4mFKm6rQtyKFilTH+ljbPHrvT1fv+bKxMfkkt//mBLnP+C0 wAH0wqv6L+/Lk2Kv23F8pVCoEaUaBLIek4atcyRufFbcRh+I0X7spC6us/bWQcKBrjnErw fKoGtuQfTR9iaXEndhUze8n+KXwXVj8= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-sBx3_KzmPry4O3M_ufxJkQ-1; Tue, 25 Nov 2025 10:06:15 -0500 X-MC-Unique: sBx3_KzmPry4O3M_ufxJkQ-1 X-Mimecast-MFC-AGG-ID: sBx3_KzmPry4O3M_ufxJkQ_1764083174 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2E40119560B7; Tue, 25 Nov 2025 15:06:14 +0000 (UTC) Received: from rh.redhat.com (unknown [10.42.28.10]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F26813003761; Tue, 25 Nov 2025 15:06:12 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Bruce Richardson , dpdk stable Subject: patch 'examples/vdpa: fix format overflow' has been queued to stable release 24.11.4 Date: Tue, 25 Nov 2025 15:05:52 +0000 Message-ID: <20251125150558.232595-3-ktraynor@redhat.com> In-Reply-To: <20251125150558.232595-1-ktraynor@redhat.com> References: <20251125150558.232595-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UjS5999E_Gk5BgGn5lcl3xMi-CeNY4maPmsDR9O0tm4_1764083174 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 24.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/e347a8f0303cb33302c104935a9db8fe60b1768e Thanks. Kevin --- >From e347a8f0303cb33302c104935a9db8fe60b1768e Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 20 Nov 2025 08:22:00 -0800 Subject: [PATCH] examples/vdpa: fix format overflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 66052657fcb810c47cbbe52762c9ad0ad7828821 ] The ifname is limited to 128 characters, but it would allow up to 128 characters as prefix then could overflow creating ifname. Change to limit path prefix (iface) to 123 (128 - sizeof("1024")) to avoid possible format overflow ../examples/vdpa/main.c:501:76: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=] 501 | snprintf(vports[devcnt].ifname, MAX_PATH_LEN, "%s%d", | ^ ../examples/vdpa/main.c:501:25: note: ‘snprintf’ output between 2 and 139 bytes into a destination of size 128 501 | snprintf(vports[devcnt].ifname, MAX_PATH_LEN, "%s%d", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 502 | iface, devcnt); | Fixes: 38f8ab0bbc8d ("vhost: make vDPA framework bus agnostic") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- examples/vdpa/main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c index 289db26498..08aa933272 100644 --- a/examples/vdpa/main.c +++ b/examples/vdpa/main.c @@ -23,4 +23,5 @@ #define MAX_PATH_LEN 128 #define MAX_VDPA_SAMPLE_PORTS 1024 +#define MAX_VDPA_STR_LEN sizeof(RTE_STR(MAX_VDPA_SAMPLE_PORTS)) #define RTE_LOGTYPE_VDPA RTE_LOGTYPE_USER1 @@ -37,5 +38,5 @@ struct vdpa_port { static struct vdpa_port vports[MAX_VDPA_SAMPLE_PORTS]; -static char iface[MAX_PATH_LEN]; +static char iface[MAX_PATH_LEN - MAX_VDPA_STR_LEN]; static int devcnt; static int interactive; @@ -75,7 +76,6 @@ parse_args(int argc, char **argv) /* long options */ case 0: - if (strncmp(long_option[idx].name, "iface", - MAX_PATH_LEN) == 0) { - rte_strscpy(iface, optarg, MAX_PATH_LEN); + if (!strcmp(long_option[idx].name, "iface")) { + rte_strscpy(iface, optarg, sizeof(iface)); printf("iface %s\n", iface); } -- 2.51.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-11-25 15:03:57.944679212 +0000 +++ 0003-examples-vdpa-fix-format-overflow.patch 2025-11-25 15:03:57.829498053 +0000 @@ -1 +1 @@ -From 66052657fcb810c47cbbe52762c9ad0ad7828821 Mon Sep 17 00:00:00 2001 +From e347a8f0303cb33302c104935a9db8fe60b1768e Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 66052657fcb810c47cbbe52762c9ad0ad7828821 ] + @@ -25 +26,0 @@ -Cc: stable@dpdk.org