From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64CA648BAB for ; Tue, 25 Nov 2025 16:22:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FDB640E12; Tue, 25 Nov 2025 16:22:50 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 96A0740B98 for ; Tue, 25 Nov 2025 16:22:42 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-298456bb53aso70752705ad.0 for ; Tue, 25 Nov 2025 07:22:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1764084162; x=1764688962; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WmT0N/n74EPEE6smaUUFOrqeqMbkWMQqkiLgpTfyWr0=; b=gHXrw+dAW1WxXy+o8imTG2+RxicsZ4BQ6pcxve5Pt48GFafKBduvlsZPdTspZ8tK14 S0J+lIJIG9iRAUBsJVm/94JSdzq1RtDT2T3OcdYF1yOo4uLW8/sqUyiI8INJaHViv5GW pEDIpwwQTdec15nNC+dgm1NtRZpjgf+pgSIlchGpa4su1LtVCAYFfQOhQ0fHk6SN4im9 jhAiSBpotWD1aqvBlFkx2ge+h/hNbWhngFHDX4we8Y0PrAGRCDPQgdkP8h3ktNnjnffB IVZP6qf4+cxDcQVjyXeJrgo7nLA4cc/YZ+iY3hZkNUxEmtfl0j5vodz75dVwJGVQmgpK FUWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764084162; x=1764688962; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WmT0N/n74EPEE6smaUUFOrqeqMbkWMQqkiLgpTfyWr0=; b=iZ76pLJQ0YHEd6Y0rJ+iSrXKQ/w1soESgdN//Z0+cvit83PTLttCwqi65YRHxrV2G0 ArCE+reV3vqw2eyeEgcwe9oeKhNDiiQfWgpM+P1PYzGyvHIjg2mozZRswLrK7m1ddAiB ge67LbwguKpSCN1pzOpkLRrsEyYFGbVzluH+Rf3naEQvtHuQ5ktSdVSm/Kh5slbTa3mE bFe7Xo6k80N4zq0JiULOUu+fbTFzJmmnsltzSRBOMF1X3pdTiErVb5OS2YjqbLm2cMTY 9EtnKP/45YkX5Wh106i0PWBVnUaQe4NwAsEsoMm1DGnLhTyVuKrcaX5TONQ+BXglaLHj YXAQ== X-Forwarded-Encrypted: i=1; AJvYcCX3ZNYcd9b6s11Dz6qw+lbLIDYOaSR9ZTFZDSDh/2TB+gaMHC/iN/LAUe9KfDRdrTmJPEb7y1M=@dpdk.org X-Gm-Message-State: AOJu0YyZ3eJEOFY/Hd7xSFJq37totmyq8DAyh/8jPF4Mpf/TGSE4pW5l 5iZmtHtbznlKqXgnx/ogBBt7OGE1NQ0kDJJYUnD9rmMlVu9RgRbYlh8sjNgC/vihX/k= X-Gm-Gg: ASbGnctFuSuM5WMz/BkzP9rUfKLfOSRzrxGLIk4h9gKquzz0/ZKZAWgBoonNdRvqwqE +CQx6gp6t/NDYk9CCm85CurcotKas5WkJz2JMDNVcB2vW4xuyzMQH1OuWpgsKODFZKLbfkPnDXw Gjsg9C4QbEUWUVlg3kMRCYL6NYrRM4wSEY5zy4VPbWVg/UliizH6jso1JB5aEm4P/tLVdOvM0aX gIUCajVOFYc1/dl+le8DmLzREsfDNDQHyNF9ORSkdQLXuazIpf+4H5KPQt2ssM1ZpX+9pGDQzDB 2l9esCVcJfEIXgEGT0TzfG0Sv5btuOnuWCvXVXoIs6gZCNclUA0jnbKYprGYfbjOCkVtqhetfPS eKJED/JWiIoqMY2hlQ6DqPeJH+uVYhl/HbJNgvAayPKYxeeCKnDYFad4fh2U1yBHOulCF/zcbuk 89vEi1eh7u4zqDFyfAWmsI1Dv+LmLy89kjI2JDvU66XQNxbGw8xw== X-Google-Smtp-Source: AGHT+IHQK0y5cPKxPQM0mrJ5SVmYnjWQpRAaliZxLolfEFSXvQrhYSk2UUnYghm/DL7CIdHVn95MSg== X-Received: by 2002:a17:903:234e:b0:293:e5f:85b7 with SMTP id d9443c01a7336-29b6c3dc272mr171378515ad.11.1764084161749; Tue, 25 Nov 2025 07:22:41 -0800 (PST) Received: from phoenix.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b111acfsm172573345ad.19.2025.11.25.07.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 07:22:41 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org, Anatoly Burakov , Cristian Dumitrescu , Bruce Richardson Subject: [PATCH v7 06/10] test: fix impossible format-truncation in cfgfiles Date: Tue, 25 Nov 2025 07:20:56 -0800 Message-ID: <20251125152232.73528-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251125152232.73528-1-stephen@networkplumber.org> References: <20251110182209.104087-1-stephen@networkplumber.org> <20251125152232.73528-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Although, it is not possible on Linux (which always uses /tmp) the compiler complains about possible snprintf() truncation. Use existing code to make empty tmp file which puts the OS specific code in one spot and avoids any races if two tests are run at once. Fixes: be22019a58c4 ("test: restore cfgfile tests") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Anatoly Burakov --- app/test/test_cfgfile.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/test/test_cfgfile.c b/app/test/test_cfgfile.c index b189d9d7a5..eabf155404 100644 --- a/app/test/test_cfgfile.c +++ b/app/test/test_cfgfile.c @@ -178,12 +178,8 @@ test_cfgfile_realloc_sections(void) ret = remove(filename); TEST_ASSERT_SUCCESS(ret, "Failed to remove file"); - char tmp[PATH_MAX] = "/tmp/"; -#ifdef RTE_EXEC_ENV_WINDOWS - ret = GetTempPathA(sizeof(tmp), tmp); - TEST_ASSERT(ret > 0, "Failed to get tmp directory"); -#endif - snprintf(filename, sizeof(filename), "%s%s", tmp, "cfg_save.ini"); + ret = make_tmp_file(filename, "save", ""); + TEST_ASSERT(ret == 0, "Failed to make empty tmp filename for save"); ret = rte_cfgfile_save(cfgfile, filename); TEST_ASSERT_SUCCESS(ret, "Failed to save to %s", filename); -- 2.51.0