From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5E30470E5 for ; Thu, 25 Dec 2025 10:20:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27ECA4025E; Thu, 25 Dec 2025 10:20:09 +0100 (CET) Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012035.outbound.protection.outlook.com [52.101.43.35]) by mails.dpdk.org (Postfix) with ESMTP id 1905A4025E for ; Thu, 25 Dec 2025 10:20:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kV25uxpd4GfL4Tsf1qwQ8PzaUIrEwIMXPvOJ8Mg0YMj4u+hja1VR+VwSYW0PqalD4YA7Ufc8CfM9hjXZMyuJL/dhEEyrwxq/+2Vi3N1bIadS6LL7g7K9lsb1DE1h8rdnrXA7a3YJvaw3hyrXqy7GYL2qch/VDs8UiSm3r9aX4U7xXmTH0LSOCEY1UwYfBo0Cp7MwKRsFRMwFu/qiA3iSS5dxy6uCE0LyE6ZBCoTxgISIyzmtGd3mPdxp7443+s3WGr2W+/zqYrIoNOqmerXGhibE0y6RK9hMWU9YsdDGZAOZ5pfHUagEqeaLzX+f7msmhH9I5V11AeGQcbT87qBYQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qb8ZWB7q1FNjFeePolIbWcUFZiBJpX2CTG1FlaTYnm8=; b=k4FOOGuV7gr5QXK1BSIYaym+OoAzezt7Mk0XvaDAC5aTm+fh+8rH5enhpCRPD5/wVs7Fk6F+pYEWGMIQIaZAnA0B1NQnWyU1VnQz5iImaCPifvIDAe1MPvcgZfkkwrDvpz1n9NlFD2SLDDA/5cuEtC3jzKflg4IXQjdIq1Uf0vl0ERWxhz5TxHWRn/I4EbCBCl2sTTBkPhTWHSS0xgm03lybEMfa/oqemc5NM5AKCTvy4bwtQgLAHMCxS4Y6HMxhLJVpWZuMcdmkK7CFPKLvyOmFoFk6Fqku+FrVuyLRXgyuCcj3xZ/b6atz7mqo5Ga/aegGTwZT+3MAM9v+sjhr1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=nxp.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qb8ZWB7q1FNjFeePolIbWcUFZiBJpX2CTG1FlaTYnm8=; b=GHIwkyyA5Ex5Er9r4jdKuwNhWGXOpo/jq/ljTNB1sySUAyJ00iyrm3O3r3GZyX3eMVwbcIatK510Qu9h4xBqnEXRiAcj1ujhdxjEz+7X4PU6wXZHHUN0Tm+TyaBLPZKT/4B00D/dJuqcggHzTU6yPPWkUUV6+bxHekM9VXbPWllzdOIKKoTjrIlVnEnrWr9hONcYqnG2ZQFk9f5RZUOAlkZNC47O8RPLmqvPLXE5d59vuX7NEeeBjNxtu/FIuXeZJMwxLegnPGjlCT1a4u1V6DS5wMSLhjhUNGVa0uutSPnFBl0MDS9q7zPfVFPfnlVsNJIbBM/qJB5QGk/3Y0YXqQ== Received: from BY5PR17CA0066.namprd17.prod.outlook.com (2603:10b6:a03:167::43) by SJ0PR12MB7007.namprd12.prod.outlook.com (2603:10b6:a03:486::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.11; Thu, 25 Dec 2025 09:20:04 +0000 Received: from MWH0EPF000989EB.namprd02.prod.outlook.com (2603:10b6:a03:167:cafe::22) by BY5PR17CA0066.outlook.office365.com (2603:10b6:a03:167::43) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.11 via Frontend Transport; Thu, 25 Dec 2025 09:20:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MWH0EPF000989EB.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:20:03 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:19:48 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:19:48 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:19:47 -0800 From: Shani Peretz To: Brick Yang CC: Gagandeep Singh , dpdk stable Subject: patch 'net/dpaa2: fix L3/L4 checksum results' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:17:22 +0200 Message-ID: <20251225091938.345892-1-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-93-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989EB:EE_|SJ0PR12MB7007:EE_ X-MS-Office365-Filtering-Correlation-Id: 920f8930-3962-4b0d-5bb0-08de4396c997 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xR0uuHbr4l7Kq9dVHXACCP6dNJr5OdS8rLHFMsI6SN7RZOCdbz6BfH+uUOQY?= =?us-ascii?Q?2BzKdXwwH3Hv8OupU3phu7p+qMJTfenx/swOxVUKmO4w7ryMcTM0b1yLq+te?= =?us-ascii?Q?OxYiRCJ4z0NmyO5WrgEen1NO0mOYg8/lIY5M1UpDVkGn3o70edlSV/zaplMG?= =?us-ascii?Q?TSS8zLTnORFT3o6qWHCflZa28EPQR+Mh8et0ELbyFTnS38Ai1S4NiEtsML7x?= =?us-ascii?Q?J9r1l2Li/ZGx4GkR4t6HwvTrDFK3Q/I5j81w/AinBFPYLAPGhLzz0s2MboF4?= =?us-ascii?Q?O4B2f2itIfWXODQ19j1QCWphkHXffT7jmFu0HbF2YbCE2zBG8Q8GTC611l8k?= =?us-ascii?Q?LkNsZUKLBF5I7jWSTnslac0a4IMWQRr7wVALLKo5beoM0Fa5zPt69t+549Qg?= =?us-ascii?Q?X6lGfrxhw1bsVqS8TpY+RxcFkhnNhKo/iKIbYNc6SEULrl+X6hHu+LWY9037?= =?us-ascii?Q?Hz+vtdYJS4BdfnXileps0v3kR6dtPyEKgOi6fhO060ZnwRbOP1jE5kYU8FcG?= =?us-ascii?Q?g2b2IptGfHd8LSJp5b1GC945ZocRB82UybPYtFplO1UdR8aTRwxNmgYFN4JC?= =?us-ascii?Q?OMVNfyMinVviAMmi0YkPL3KN/QY7RFqmrbCwd5DLg6Un2ucO2ZmKa95lplA+?= =?us-ascii?Q?sdVlKAise7G0qU+7Qswh8vRAsHre4nOx/a0+jwJWZOK5l3jSAE63bmiGuaLO?= =?us-ascii?Q?ceZ5yAZlCop6od8SJTZLEtNnNAL5gUasVyrWvn34LiBDPatOLLZDGEPEDR6V?= =?us-ascii?Q?KIie3bKYUZtbIDwSkLiyB84eozUh0Gdo/PVFjjXvnKKzUmwz55vYRxAAA2sL?= =?us-ascii?Q?+DEFJ6KBrOoSj+MZxFAb/RZs9V15dSvztOj1cy4MLgwDjPMsYl8TLghw9Jtg?= =?us-ascii?Q?VdL3PVP/PsWB///PhKwdAzpFbXRsiZhWbThd5leqYPUox0sWUjvsiTcuu23A?= =?us-ascii?Q?mtkoy59eMddqdB82VZOkMm/5wVW6/YhIMGN1KxnPuKgmjgdAhZv7SAw/7gsO?= =?us-ascii?Q?hD2VohAA0Zt/eimnK6xe/dupQSgdz1VneaOn44hw8G++FLP06EcIlBC20rgF?= =?us-ascii?Q?EMuZeDJGvKRlhIq5fcJrFOpr/xvXfRfQAyXffpH5TfcwK3+iIu0ZAPLfRFFY?= =?us-ascii?Q?dPbaC98xcqaIbVNcb1c7ksdnqe2kFWZu0271A7Nl1mKvO5HvQD76iwcm1yxt?= =?us-ascii?Q?8GQszSEw7zJSNxAheiUFmwHH//3+5qFt5jTVnKeuAAe3iTd19PmNtpaiN1aZ?= =?us-ascii?Q?GFg/k6Sd8TBLJTS71xWqhYZDzd/mEzcnKBpyrlf7SOosF+DJmQ7/9ffLkaEv?= =?us-ascii?Q?m7V2/I0CMEAg1hich8iKlo8i3gjNQTAtLuLKb4iOdBiK198vRA6anVs5G5nJ?= =?us-ascii?Q?++C5oI2oHOLVDlGWAo1GgwyA53rzWpaT679YrPJqwhnDDdpkAW4DwVAEzYVJ?= =?us-ascii?Q?xiYby/44LD9nazf+laDAeujpAYRXBA/GyDfwBdg1weDWEQkSNWpkjrwO4Arg?= =?us-ascii?Q?Y0TCSKmJK4+WiMo30MiQ0O6TanTv2SNARWHR6kYqa2Z0g7jI8wqRQfpGzmJu?= =?us-ascii?Q?0uE7w8psvHtNLhnGfddkVVwli032vt4YLc7x+Qa+?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:20:03.8531 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 920f8930-3962-4b0d-5bb0-08de4396c997 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989EB.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7007 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/fb4a3f8053c2de63af0f133bd22b7f6215d5bc2d Thanks. Shani --- >From fb4a3f8053c2de63af0f133bd22b7f6215d5bc2d Mon Sep 17 00:00:00 2001 From: Brick Yang Date: Thu, 16 Oct 2025 15:57:53 +0530 Subject: [PATCH] net/dpaa2: fix L3/L4 checksum results [ upstream commit 870354264644bc8a2f014571e9a34757258d2ec8 ] Layer3 and layer4 checksum validation and error status is part of word1 of annotation area, but driver is looking into wrong word. This patch fixes the checksum error status in packet parsing. Fixes: 94d31549c380 ("net/dpaa2: support Rx checksum offload in slow parsing") Signed-off-by: Gagandeep Singh Signed-off-by: Brick Yang --- drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 10 +++++----- drivers/net/dpaa2/dpaa2_rxtx.c | 16 ++++------------ 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h b/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h index 7e5e499b6a..4f5ac1a481 100644 --- a/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h +++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: BSD-3-Clause * * Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved. - * Copyright 2016,2019 NXP + * Copyright 2016,2019,2022,2024 NXP * */ @@ -298,13 +298,13 @@ struct dpaa2_faead { #define DPAA2_ETH_FAS_PHE 0x00000020 #define DPAA2_ETH_FAS_BLE 0x00000010 /* L3 csum validation performed */ -#define DPAA2_ETH_FAS_L3CV 0x00000008 +#define DPAA2_ETH_FAS_L3CV 0x0000000800000000 /* L3 csum error */ -#define DPAA2_ETH_FAS_L3CE 0x00000004 +#define DPAA2_ETH_FAS_L3CE 0x0000000400000000 /* L4 csum validation performed */ -#define DPAA2_ETH_FAS_L4CV 0x00000002 +#define DPAA2_ETH_FAS_L4CV 0x0000000200000000 /* L4 csum error */ -#define DPAA2_ETH_FAS_L4CE 0x00000001 +#define DPAA2_ETH_FAS_L4CE 0x0000000100000000 #ifdef __cplusplus } diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c index f65603aa09..2d5555d585 100644 --- a/drivers/net/dpaa2/dpaa2_rxtx.c +++ b/drivers/net/dpaa2/dpaa2_rxtx.c @@ -196,14 +196,10 @@ dpaa2_dev_rx_parse_slow(struct rte_mbuf *mbuf, goto parse_done; } - if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE)) + if (BIT_ISSET_AT_POS(annotation->word1, DPAA2_ETH_FAS_L3CE)) mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD; - else - mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD; - if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE)) + else if (BIT_ISSET_AT_POS(annotation->word1, DPAA2_ETH_FAS_L4CE)) mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; - else - mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; if (BIT_ISSET_AT_POS(annotation->word4, L3_IP_1_FIRST_FRAGMENT | L3_IP_1_MORE_FRAGMENT | @@ -243,14 +239,10 @@ dpaa2_dev_rx_parse(struct rte_mbuf *mbuf, void *hw_annot_addr) DPAA2_PMD_DP_DEBUG("(fast parse) Annotation = 0x%" PRIx64 "\t", annotation->word4); - if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE)) + if (BIT_ISSET_AT_POS(annotation->word1, DPAA2_ETH_FAS_L3CE)) mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD; - else - mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD; - if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE)) + else if (BIT_ISSET_AT_POS(annotation->word1, DPAA2_ETH_FAS_L4CE)) mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; - else - mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; if (dpaa2_enable_ts[mbuf->port]) { *dpaa2_timestamp_dynfield(mbuf) = annotation->word2; -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:36.435501704 +0200 +++ 0001-net-dpaa2-fix-L3-L4-checksum-results.patch 2025-12-25 11:16:35.240902000 +0200 @@ -1 +1 @@ -From 870354264644bc8a2f014571e9a34757258d2ec8 Mon Sep 17 00:00:00 2001 +From fb4a3f8053c2de63af0f133bd22b7f6215d5bc2d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 870354264644bc8a2f014571e9a34757258d2ec8 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index d156b07087..a670098958 100644 +index 7e5e499b6a..4f5ac1a481 100644 @@ -35 +36 @@ -@@ -304,13 +304,13 @@ struct dpaa2_faead { +@@ -298,13 +298,13 @@ struct dpaa2_faead { @@ -54 +55 @@ -index 656a3a423f..da0c06caad 100644 +index f65603aa09..2d5555d585 100644 @@ -57 +58 @@ -@@ -201,14 +201,10 @@ dpaa2_dev_rx_parse_slow(struct rte_mbuf *mbuf, +@@ -196,14 +196,10 @@ dpaa2_dev_rx_parse_slow(struct rte_mbuf *mbuf, @@ -74 +75 @@ -@@ -248,14 +244,10 @@ dpaa2_dev_rx_parse(struct rte_mbuf *mbuf, void *hw_annot_addr) +@@ -243,14 +239,10 @@ dpaa2_dev_rx_parse(struct rte_mbuf *mbuf, void *hw_annot_addr) @@ -89,2 +90,2 @@ - if (unlikely(dpaa2_print_parser_result)) - dpaa2_print_parse_result(annotation); + if (dpaa2_enable_ts[mbuf->port]) { + *dpaa2_timestamp_dynfield(mbuf) = annotation->word2;