From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B193470E5 for ; Thu, 25 Dec 2025 10:21:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73282402DB; Thu, 25 Dec 2025 10:21:09 +0100 (CET) Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011020.outbound.protection.outlook.com [40.107.208.20]) by mails.dpdk.org (Postfix) with ESMTP id 0B7D34025E for ; Thu, 25 Dec 2025 10:21:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vTRsbPNTzwlGtpELZv3/XrNU/WsshsrJWLdmjuWBXqYJRfL9KUzhmwVkhB2YvYac/raZCd2iyQgztAYV1lvYF6dOpvaJ+YVEqB9b3Ndg4/EM046ScdbHKklr/ATVcezucslsinY07yExU0Hfw4AzYXIvKMYUrqiWWqdM6QT/NB3dQiliBUbXpgpB9bq9IFU+1r9vO9vsJlrz5P4Ee4WCHRuOpeCEZCRapgkG91H6M3E26OquiYkr4BC1SC4SRwXJob1cusdfCH95r7KPW+E/Tpni4cTNnYATxNq96znRibjJSTkDiCT5xYlGY23nwnYGxL0n2IkCuXdU1H4w9aLT1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NkEKiKRwZPIihijwtinnIJ1XJGDn18xgZffifSxAbzU=; b=Hbrgi+uLPEYoZX1gEZLlM0lbjXTqbPTzXt31jeZHENsXIZf1F/iHLPlhGDbTgcmGV+z0xwLUZXix8V9OgbtLVl2F5uxUaLfiv1ruRWhQ+Rqfg6tV6u3wiedaQW+ViSeVjRH6FgUmNo4xx1CZofyekcK4msDEzF2YEUqhC1Dk4oTNVb5W6bRniFtC4xhhnnx8c7c4h2M8uZJcDOgJc5YiCiN7q0Wp3eMQMOJ8RqxgZrfAoswTVguUxJroOBfGd/lbkz+QjL+EzFmcnIg9wtRI/jtZ9HSsiv9Arvs6yhd4xni9NpVD1FmuyTBQfSN3LW5wAGYAsF4rMpmL7W46+/Lc2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NkEKiKRwZPIihijwtinnIJ1XJGDn18xgZffifSxAbzU=; b=d/w7NVrE0N076a/QIp3Pi1vMn4GmmokH9Dz5Uu2jmEBzYqTbX1eRZhontdcmqBf8/0Ofn3fumpPJqwobMrTi0uVOrMcIAEilgpX572n6ZyWCuhlXjRU4UyT/rRbVxjJdaNxgrUgtHporHOLO8DTdKwYC//9MjgnuicRhodWgfhtU0JkAaSpiEzdseB0ZXN1GV3CIV2/bUgQ0S0g0t4bYs0lT9+C+NIiMmFm6prRJgCu58ZPibZdBWKKASRF3s8T+wAPEWyIVTlSHTfieP1iEBx/NNGL1xQXyBm5XDP5BKmSmRlWoAKFRmkKTsP/zg0Ny+ITW189SfUwCYyH39DoJ0Q== Received: from SJ0PR05CA0025.namprd05.prod.outlook.com (2603:10b6:a03:33b::30) by SJ5PPF6785369A4.namprd12.prod.outlook.com (2603:10b6:a0f:fc02::997) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.11; Thu, 25 Dec 2025 09:20:45 +0000 Received: from BY1PEPF0001AE19.namprd04.prod.outlook.com (2603:10b6:a03:33b:cafe::6e) by SJ0PR05CA0025.outlook.office365.com (2603:10b6:a03:33b::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.11 via Frontend Transport; Thu, 25 Dec 2025 09:20:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BY1PEPF0001AE19.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:20:45 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:20:34 -0800 Received: from drhqmail202.nvidia.com (10.126.190.181) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:20:34 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:20:33 -0800 From: Shani Peretz To: Thomas Monjalon CC: David Marchand , dpdk stable Subject: patch 'test/hash: check memory allocation' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:17:34 +0200 Message-ID: <20251225091938.345892-13-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE19:EE_|SJ5PPF6785369A4:EE_ X-MS-Office365-Filtering-Correlation-Id: c38ad3e1-7a2e-49cc-249c-08de4396e216 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|36860700013|376014|13003099007|7142099003|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?A/xzskVuEgsJrnQ5FE3ieAbV7DpMzTt6c15je1+8AnHimz8qJ2WTeNW9bNp1?= =?us-ascii?Q?t6jrP10D7zj/H+IVs7Asuw02tb15rmaarmtXbQKjjxUaKuS7Q94NDDTKkDDL?= =?us-ascii?Q?U1jGA8UdE//UujJ5/+KJIspIJAh6UxgX7CWrbekK7/T4ySRApld0JgxmhOzB?= =?us-ascii?Q?7cU78aeQef095A838g95K9lo5dIQL2wg8vThN8oZb8MV8tlPrC8kINUET/Gh?= =?us-ascii?Q?1g7yqjwYueAV30wx0HXhwmkVlDQyYp8keg+tfe5E40ngA/sjL0yI7w2O/cly?= =?us-ascii?Q?2kIrJ8SZ/iBqL0OqLi+yN6+Qr/x5aBEfj0l3sXjI4dc/W9ZtqGOtYa3CDw1I?= =?us-ascii?Q?+eP4uVze92vv/uCU26CSuShGZHdTxkg7Pow/s/ohTg6sQ8BPM8p2x9d0Uzdt?= =?us-ascii?Q?qU+IEc3rlQWWYnkaxqpBXFHf4WF0HpN7OCDaWf1BifJYum2DSqnE7n+8zZn/?= =?us-ascii?Q?lTPQKO4ld0NoKfPCCaZ2rminv5Wn6WGQRY/iNv6q8TWnCc5+3TykUgdTIjiG?= =?us-ascii?Q?7saXaHAJtMfMiJ/vppmUIyzURH8VfzsRdLER69BXlIPWuCzuFOML7LkiM1dM?= =?us-ascii?Q?t8yYzB+B6HGovQICcNXX9/h7iBQ9IG59v/iCSQsdopPzLMe+TaUlWzt57Gh8?= =?us-ascii?Q?WOva+83ahDF3NzF5Xvx/pI5X2N22FvfdtcckwuPAcxv+bkPcmcVVqP7RHrDt?= =?us-ascii?Q?wT6l4xmpObhmiE0QhVNEheyBpWJ4OWT0NJefHvY2aWX1zJ1O/pXjx570Xdas?= =?us-ascii?Q?6AxyGkAVS+M4VDVjL3J5ACsA6UjoUwzVeHqTqADnmfYyN7QP9CUkMTGlHL8E?= =?us-ascii?Q?hsei+/Xt8C20acDDG5BwKb1EZX8uWr8ZoYnkSnGQibRLCNTjlqpn3C2Ij1NT?= =?us-ascii?Q?cUERBIkg8AnasOhCeQw+sCathu/qKYD5KUg1SBqqltM5Cs4fPXSbqmJEXqlm?= =?us-ascii?Q?oO9NBxiOpUjjOtBFoKq6q61QNJsfhCuzAE6pBUoHhaghFS31aG+aD+jnMlzU?= =?us-ascii?Q?3UxF53K0fwKqfzbxYi1aLa526JTvWnQI7eIZsjYvwsFIW+30SmJnq0zNAp6R?= =?us-ascii?Q?AptHj1z+97eLvkwrHeR3VNZQ3STVeyyOUX7n117KERkrhxeNd5pXJzAtq1ij?= =?us-ascii?Q?hW8f/C/tw1kGTg7KxAQPJznkLDv0n7Fkxt26MZKQ09qJ5eUKcAc2Xg75zq6e?= =?us-ascii?Q?zA5j2JY0NwF/m+jFGhbUTuA4GMOw7HPS4a8t09HqrOqB+Fh8sdPVaFs2+9tb?= =?us-ascii?Q?/HB+mHsD7cyGnNu4sKCoTcOCT4IBq0hrzi8y/y3lZx0u31L7lr5hN1R76GBC?= =?us-ascii?Q?z24pXbs6TQezrE3CDpEA3fxkWtiqU6F6tlTbSsHmSftTjny5dxTKFmWjOBS0?= =?us-ascii?Q?9GuRmZUeZwmYsXrV+fPYFuPjAKZhHNab605QY+uJcJM1D4PmWbSubd8kPzaV?= =?us-ascii?Q?tLZ3NCMAOmNti9nu9N2q4D2AsuInlviFH1cphrFvqXDyyCqDSazN/ieY9wxv?= =?us-ascii?Q?JzldbZFHuusatCflwZKZW06Q/wyydrcUY431M68GNu/GkMzEizOqr8VUcSVy?= =?us-ascii?Q?/bFdxor+zv1gvRJzUak=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014)(13003099007)(7142099003)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:20:45.0303 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c38ad3e1-7a2e-49cc-249c-08de4396e216 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE19.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ5PPF6785369A4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/e593c2f4728f0b84b31215281b3a0fcbea908670 Thanks. Shani --- >From e593c2f4728f0b84b31215281b3a0fcbea908670 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Thu, 30 Oct 2025 17:03:20 +0100 Subject: [PATCH] test/hash: check memory allocation [ upstream commit 77e23b2d7ee45d153f588611a3fa479e4cf0c9b6 ] When reserving a specific memory amount, it was possible to pass the first allocations and fail on a later allocation where there was no check, resulting in a crash. It is fixed by stopping the test if allocation failed. Fixes: fd368e1982bc ("test/hash: test more corner cases") Fixes: 9c7d8eed1a45 ("test/hash: add RCU tests") Signed-off-by: Thomas Monjalon Reviewed-by: David Marchand --- app/test/test_hash_readwrite.c | 5 +++++ app/test/test_hash_readwrite_lf_perf.c | 4 ++++ 2 files changed, 9 insertions(+) diff --git a/app/test/test_hash_readwrite.c b/app/test/test_hash_readwrite.c index 4997a01249..0ee1d64b02 100644 --- a/app/test/test_hash_readwrite.c +++ b/app/test/test_hash_readwrite.c @@ -64,6 +64,11 @@ test_hash_readwrite_worker(__rte_unused void *arg) ret = rte_malloc(NULL, sizeof(int) * tbl_rw_test_param.num_insert, 0); + if (ret == NULL) { + printf("allocation failed\n"); + return -1; + } + for (i = 0; i < rte_lcore_count(); i++) { if (worker_core_ids[i] == lcore_id) break; diff --git a/app/test/test_hash_readwrite_lf_perf.c b/app/test/test_hash_readwrite_lf_perf.c index 5d18850e19..5a52038247 100644 --- a/app/test/test_hash_readwrite_lf_perf.c +++ b/app/test/test_hash_readwrite_lf_perf.c @@ -1310,6 +1310,10 @@ test_hash_rcu_qsbr_writer_perf(struct rwc_perf *rwc_perf_results, int rwc_lf, sz = rte_rcu_qsbr_get_memsize(RTE_MAX_LCORE); rv = (struct rte_rcu_qsbr *)rte_zmalloc(NULL, sz, RTE_CACHE_LINE_SIZE); + if (rv == NULL) { + printf("allocation failed\n"); + goto err; + } rcu_config.v = rv; if (rte_hash_rcu_qsbr_add(tbl_rwc_test_param.h, &rcu_config) < 0) { -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:37.018612552 +0200 +++ 0013-test-hash-check-memory-allocation.patch 2025-12-25 11:16:35.362964000 +0200 @@ -1 +1 @@ -From 77e23b2d7ee45d153f588611a3fa479e4cf0c9b6 Mon Sep 17 00:00:00 2001 +From e593c2f4728f0b84b31215281b3a0fcbea908670 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 77e23b2d7ee45d153f588611a3fa479e4cf0c9b6 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index 82fe03cc5a..22ccd6df6a 100644 +index 4997a01249..0ee1d64b02 100644 @@ -26 +27 @@ -@@ -70,6 +70,11 @@ test_hash_readwrite_worker(__rte_unused void *arg) +@@ -64,6 +64,11 @@ test_hash_readwrite_worker(__rte_unused void *arg) @@ -39 +40 @@ -index 864c3059d9..bef987d29d 100644 +index 5d18850e19..5a52038247 100644