From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AC63470E5 for ; Thu, 25 Dec 2025 10:21:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 335AE4029A; Thu, 25 Dec 2025 10:21:08 +0100 (CET) Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012035.outbound.protection.outlook.com [52.101.48.35]) by mails.dpdk.org (Postfix) with ESMTP id 127DC4025E for ; Thu, 25 Dec 2025 10:21:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iS33S584PWV+ZMKjQEcT7jWCzoi6h64oG8CjIHwaaeyM2x8VZmIxsbowySozQDCmmykkuyVgIkbXVGAR8LS0I6/fwn/uaXN5tfMg9IKbvllFUKXYmCIAb/bQfNqtZp4hH7R+X20lMy1xzjoQ9QS3qWpKPSbFT+3vfCSxsXa4SFDD+qggA8z6OojCrqKctMD/UQrai+tPe2Giyzo7eK81A7VjS65M3DbpQtHjtA60ihV0mCGOW033z6RKPY7OOVFk5gFBFTrQznvPSwMe9tr3Bm38TYEDa2v1fyE+H81P82xmEwDSKRtEC9QIKgPe0Ya8yo1bVUOz6NROH0x1BtsyYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D9Wsip+mklJU7iumZbToJVfKM8FYTertsUqDfuzodWI=; b=slNSkyPobtfzoajhMYGhhGLP65jP7Awu9Y0SX/j2Bqa5HJNR8idZBrXQ8cHmeNyPI+zXl7nBU0eNd4gAKDOHf+U460pFD+YecFAX6mCugshFRwREbW0hfJcSVpMn8pGx1Sf9Vyu9sJoAPd5vHzgncPnzk7u/rmCnGmfzgPwhh7lh2OCR1l+JEwWkYOzTlXVQqk+QZnVmfYAZ1DO56OPuta7xeaWCAUMhcowBXAsJCQ/zXje647M9IQI68cpZ/7CC6HzzM+TzvlMdd0anKR7Hkzb4ax+g6aB4lg04MsMtoi0rPSn6jVpz20bmJSRTGdrEx/2pRXlVkKdU4IKXL7SNGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D9Wsip+mklJU7iumZbToJVfKM8FYTertsUqDfuzodWI=; b=F0Wsg2pdYIMtBPiJav84YAV7ik3WN4ChD/hZO3POrZkao0lwprS9GtunFojqM+ZLvPIps+mnqXbVp0A0VId71A3UoPbnoADb/xjm3XW4RHpsTvLe6/iEN+E3sAuS54HOxnUk0Z/mLfZkqvYzPsrE2N2pPxYgbOaK4dP3UVwESfKRnN+M9ClDtD04FCwLNn3Tbc4yVs2mynd6lj+HKaQ100wkae2i5boxJ8GaTe9KPR8E7Ibp9M/tGVCSTlJcpQ40xdoDgq15PRJY693DRDdweC/QSrTeXIWnPa2U7aqsRm6B3wX3CjcbQWiiKKIQHwESqAAvPpAb0jchtkXSZ5JRAw== Received: from SJ0PR05CA0161.namprd05.prod.outlook.com (2603:10b6:a03:339::16) by BL1PR12MB5780.namprd12.prod.outlook.com (2603:10b6:208:393::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Thu, 25 Dec 2025 09:21:02 +0000 Received: from BY1PEPF0001AE1C.namprd04.prod.outlook.com (2603:10b6:a03:339:cafe::48) by SJ0PR05CA0161.outlook.office365.com (2603:10b6:a03:339::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.11 via Frontend Transport; Thu, 25 Dec 2025 09:21:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by BY1PEPF0001AE1C.mail.protection.outlook.com (10.167.242.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:21:01 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:20:53 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:20:53 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:20:52 -0800 From: Shani Peretz To: Robin Jarry CC: Dmitry Kozlyuk , dpdk stable Subject: patch 'buildtools/pmdinfogen: fix warning with python 3.14' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:17:38 +0200 Message-ID: <20251225091938.345892-17-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE1C:EE_|BL1PR12MB5780:EE_ X-MS-Office365-Filtering-Correlation-Id: afe551d7-de27-48e7-38ad-08de4396ec14 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bTxoTP8MxEtocp9VYrXZS9/KFMc+xA+XtDNvbKmYMo2c39SFoCtIv5Gcg4Z3?= =?us-ascii?Q?8TEt4geaDSx5NaHbprCZfh0A7/MTjtGiNzmzT34fUabkEs4I0u4uha8020e3?= =?us-ascii?Q?IdqKhpre7yABGwolYflxRw0qQr5CAeMnI6T4EFlL3Qnjwq/IznVX+ylSVVcn?= =?us-ascii?Q?oYUNTkEJuEeprMKMj2QHBRyRpozrK65W7MWovoBV/MTBlge2sk2pURg/f05K?= =?us-ascii?Q?nYeSVRmjC9t6AqNJDlwnVA4SFzxPr5AtWgXF7o3Y+iU11yMOeX3IU1sGqJMn?= =?us-ascii?Q?PIw+74NDzDSc4ycYQ6UrBggES9nDJ4T+5DOxu2l5RACbm4sYEpVCiq5Xn7my?= =?us-ascii?Q?jdc1tHRjWgco7zlquCTQNDwhzWciqwRlL+uA08N/EJvxlE+FMKfirspZNtuC?= =?us-ascii?Q?ZV959byaEFB6TLh2qTm3kFHBqFdqjRjvEiuej587Lyo2Ry7c9g7yQ3nKLh3I?= =?us-ascii?Q?i3fj92jJ/ckBb1L911xcwK6TE/fH13anXwCLpkxkihWCvs3tx/QpfSVKS/KX?= =?us-ascii?Q?mLp4BxGgStwrR0YjrndmCYLoGFDFpRm1YQseNnk7nmwDzdadasQQaSWGWe7t?= =?us-ascii?Q?5yotZDAma9URUdFvtNkcGggLacZ+6JVX1GnV2xZB0wSmT7UZw/gLBcolkuGd?= =?us-ascii?Q?xrP1z1kJT6KLfGDNT4zF4tZs7sGKThK08eave/3T8jwptF/OiWra0DtfHyXU?= =?us-ascii?Q?vbPy2HdhW4s/aIuMW9nuvm71l5kqaZr4IjAxjNQzHd01GibsIWSzIdFG2F4X?= =?us-ascii?Q?Hgmy5dYIx0uStYJxgKpg2sJnL7kEYBw7UUK7aAok+jTFGisPRdaxdFazT6wJ?= =?us-ascii?Q?fG5LeDpa9OgmIXXVwcIgBhv9GJg4n68TnfNQPYdLKtLlVdEBc5XjiM9BVT/t?= =?us-ascii?Q?tYnDQFYkP/Jo0uLoSR+Myv7I8VW3zinZnCYIQf27SHzyGJnGrn7tVUBUqY9/?= =?us-ascii?Q?fdWBu4mplZtoZmOYWVTlbY9hZniI5wwmSxfqF4ErnX2rUF9+7ftMQvnla+tr?= =?us-ascii?Q?HMOBWyxYNtUdjfE8udm8ZRJeNw4eKQUWrpkkDmJ4x2uuLjcQAkPdxOzluHkP?= =?us-ascii?Q?/zgkJYQ9ClkE9qTWglPozMPck1IGNnHMRTpcIycZ42BF1H3eY9x5DLoMnedG?= =?us-ascii?Q?VoCZXqokR8RW/vURfz653lNTtdlF1iKlDRLH3FlyFK52giED9gsdMPrRWZNJ?= =?us-ascii?Q?I3JAfIvGvhG/wxJfsZK45k/ukmO9rD/Ilb+ewtwWV3MUYwnsLMX4TP51jdNs?= =?us-ascii?Q?ErQ+yFZ7fWY5S8k0qHvLKu0Xt6IHZlMPNMk2bCMkv/BqLAcJSvqJg+q9YO6V?= =?us-ascii?Q?2PtyM0zIaCuvNXF2JQusy3b+9IivgzyrZrechUaSUOt1CXqvRyyYfBEC+Oov?= =?us-ascii?Q?VZCr+HM12GXrz4zUH3z9iuFOoHhVEdaxVbr8Ya+HOZWzs/Zc4m2hNqoek694?= =?us-ascii?Q?OKG3Wcvey/615Fj/8w8mw2F22pKT+gbAf10I0LkFLT4P7W0DdYmkUce+nEYU?= =?us-ascii?Q?mioSJKLIHfytYmyDpHTk5M7TklA8ZyTG0iCYKropYuxMKR9dhHk8LwryKTsi?= =?us-ascii?Q?k9fAcBQ0vbVJF+O16aOqpQ6W2Vt/sTpC87sg5WU2?= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:21:01.7693 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afe551d7-de27-48e7-38ad-08de4396ec14 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE1C.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5780 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/2c546b93bb6012a87d975547bc6b6b44468db4e3 Thanks. Shani --- >From 2c546b93bb6012a87d975547bc6b6b44468db4e3 Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Wed, 29 Oct 2025 17:46:17 +0100 Subject: [PATCH] buildtools/pmdinfogen: fix warning with python 3.14 [ upstream commit 74019b85e70e6152594768d6d07b8360e39ee70a ] Fix the following warning seen on Fedora 43 with Python 3.14: buildtools/pmdinfogen.py:118: DeprecationWarning: Due to '_pack_', the 'rte_pci_id' Structure will use memory layout compatible with MSVC (Windows). If this is intended, set _layout_ to 'ms'. The implicit default is dep recated and slated to become an error in Python 3.19. Use the struct module which is simpler and assumes everything is packed by default. There is no change in the output of dpdk-pmdinfo.py before and after this patch. Bugzilla ID: 1818 Link: https://docs.python.org/3/library/struct.html Signed-off-by: Robin Jarry Acked-by: Dmitry Kozlyuk --- buildtools/pmdinfogen.py | 42 +++++++++++----------------------------- 1 file changed, 11 insertions(+), 31 deletions(-) diff --git a/buildtools/pmdinfogen.py b/buildtools/pmdinfogen.py index dfb89500c0..09e34f1524 100755 --- a/buildtools/pmdinfogen.py +++ b/buildtools/pmdinfogen.py @@ -4,9 +4,9 @@ # Copyright (c) 2020 Dmitry Kozlyuk import argparse -import ctypes import json import re +import struct import sys import tempfile @@ -110,24 +110,6 @@ class COFFImage: return None -def define_rte_pci_id(is_big_endian): - base_type = ctypes.LittleEndianStructure - if is_big_endian: - base_type = ctypes.BigEndianStructure - - class rte_pci_id(base_type): - _pack_ = True - _fields_ = [ - ("class_id", ctypes.c_uint32), - ("vendor_id", ctypes.c_uint16), - ("device_id", ctypes.c_uint16), - ("subsystem_vendor_id", ctypes.c_uint16), - ("subsystem_device_id", ctypes.c_uint16), - ] - - return rte_pci_id - - class Driver: OPTIONS = [ ("params", "_param_string_export"), @@ -166,26 +148,24 @@ class Driver: if not table_symbol: raise Exception("PCI table declared but not defined: %d" % table_name) - rte_pci_id = define_rte_pci_id(image.is_big_endian) + if image.is_big_endian: + fmt = ">" + else: + fmt = "<" + fmt += "LHHHH" result = [] while True: - size = ctypes.sizeof(rte_pci_id) + size = struct.calcsize(fmt) offset = size * len(result) data = table_symbol.get_value(offset, size) if not data: break - pci_id = rte_pci_id.from_buffer_copy(data) - if not pci_id.device_id: + _, vendor, device, ss_vendor, ss_device = struct.unpack_from(fmt, data) + if not device: break - result.append( - [ - pci_id.vendor_id, - pci_id.device_id, - pci_id.subsystem_vendor_id, - pci_id.subsystem_device_id, - ] - ) + result.append((vendor, device, ss_vendor, ss_device)) + return result def dump(self, file): -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:37.199099904 +0200 +++ 0017-buildtools-pmdinfogen-fix-warning-with-python-3.14.patch 2025-12-25 11:16:35.385969000 +0200 @@ -1 +1 @@ -From 74019b85e70e6152594768d6d07b8360e39ee70a Mon Sep 17 00:00:00 2001 +From 2c546b93bb6012a87d975547bc6b6b44468db4e3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 74019b85e70e6152594768d6d07b8360e39ee70a ] + @@ -20 +21,0 @@ -Cc: stable@dpdk.org @@ -30 +31 @@ -index 63e0a8b364..4401106f0b 100755 +index dfb89500c0..09e34f1524 100755