From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B3EB470E5 for ; Thu, 25 Dec 2025 10:20:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42F49402B2; Thu, 25 Dec 2025 10:20:12 +0100 (CET) Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012025.outbound.protection.outlook.com [40.107.209.25]) by mails.dpdk.org (Postfix) with ESMTP id B11E0402B2 for ; Thu, 25 Dec 2025 10:20:10 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P/chotcIkCeb7NMmSS85euV81VyK22TVuWzyAbXvlclB6xhGK1PE8cu4OFjVNxSlIE5C6d4vO7bbSZsRpRcedmENMbemfL5Wz3vxK2dWl07u2t4p7WjQBxzUJyLLxVwGiqZecdjMRN+2OHP536UZ5aBOJ1705XSWE3ZrhhrE8IspHq3QAsfpAEnxFaJ1F0tFDm6ZYzp5ZjX6Yf26qNtgztwwbJOCIoD76iMarIomIf1vKRKNSC5dwVEvUAGAUp2Mz7UeayEUJOzfbfMW/F63Kiv22yQfLGNpuOKOtx+xdQjy5RalGo55NYsXtxmmNhTsvrmEqlUwwtUkN+Br8HHppQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v74f/4LflRJWKlbWxrp4gXh1PIUBv6uJSlRKYHZRiCY=; b=VUnPtk1VnU2Ch5Bx97LJ515XbTvdsOF/JF+3Pp6NudeUZy+Vg8zyjA70vXjKqXbH2mW83ZveFWymH7mRg8l/vgOSipJEyOr4S7oHl/SZd41+VhTY1ML30N9XnBkx25GAEf64sR+g5Z25rgosJZZKVFzEbKTN7JOzDarhlWBnbsDBUD6cITZOBcyfDQNhnCStPYZ9Y2KBrSH4qBo4eEvE7xAHPvtVC8Vrtl4u+/Fi7HR2Lz+wckPMc7hMXfcBYVXhQK9MrVb0sGgML3VX/FQ09ilKLgyCmNYGSOJ2uFuMLAkak1CrEQqCZ3iVxXvizJJpaiw7+RbDWpMenW0kqxDarg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v74f/4LflRJWKlbWxrp4gXh1PIUBv6uJSlRKYHZRiCY=; b=gCAfeIeCJUsxnW5JQE/fVZfpMOvV/HyqxlPYR7Ba615rQxMyHHC9tTLUdaysuWAEBNnruLmCUFIksv5mhi0RKwqJcdN5rqbsWvUfly9IrBdmHdD2yPtBpPh3mfaTi09Do/br3FgPYRQpOU863Q4xIpBepC4uE67MR/x1urqK0KtaiGWgTmULSnOTny0FxJOkaqPOX0D7l49b29YeGpv+Ca21isR+AKMIMYC9WeoGOq7DvKv0yGEk1AN3uiiDy4NrsuHbXRrWrPxwbiFib2qVuypXQV/05K9at03pu7LaSaZyPXGJTxJ+Ms94Ao5hJgCxdGiQyKR6lAQ3XqptffIVxQ== Received: from BL0PR05CA0005.namprd05.prod.outlook.com (2603:10b6:208:91::15) by BN7PPF5D27497F1.namprd12.prod.outlook.com (2603:10b6:40f:fc02::6d1) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.12; Thu, 25 Dec 2025 09:20:05 +0000 Received: from BL02EPF00029928.namprd02.prod.outlook.com (2603:10b6:208:91:cafe::4d) by BL0PR05CA0005.outlook.office365.com (2603:10b6:208:91::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9478.2 via Frontend Transport; Thu, 25 Dec 2025 09:20:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL02EPF00029928.mail.protection.outlook.com (10.167.249.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:20:05 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:19:52 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:19:51 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:19:50 -0800 From: Shani Peretz To: Radu Nicolau CC: Kai Ji , dpdk stable Subject: patch 'crypto/qat: fix ECDH' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:17:24 +0200 Message-ID: <20251225091938.345892-3-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00029928:EE_|BN7PPF5D27497F1:EE_ X-MS-Office365-Filtering-Correlation-Id: a0fc26a3-fc5c-41f7-aee0-08de4396cab1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|1800799024|376014|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?3XRfLdHRbw7uzba9mwz/rIpdCbHU5B2BO7OHgwLxArJIfy6YovpUDdrpHsqG?= =?us-ascii?Q?27ok2ku/UPMX8lJkxGO6mLTIhskdV39zzrKR/5p6FOVjWESKlhETAlXrTCqY?= =?us-ascii?Q?Hdnzg12Ljx2UEGs7oBjYG3pPzKobbhqnKpB0waELuIa07dpwaNITa22EXmqu?= =?us-ascii?Q?IQY8A0CT5B9cNU4w7kGrceyaMAeINCKUbtmJS+IyCHLiy0TeQYpnMzQrQthw?= =?us-ascii?Q?QWGCQNd5dXW99xaZPO24qBpUcYg2syl+6KxEwZxFrYS0svUbsMEExThjY882?= =?us-ascii?Q?oSOGIUJNJyi29QTBrbjfC0qCw+MvDLiwCLoIXeWUGwmBxJaHjz3ujX85LLW0?= =?us-ascii?Q?cv7dBCB7nY7MViig3LhjPsXEgUc3bZ1hZa6hhNQbrKqbmkujemPPWdb0mzwy?= =?us-ascii?Q?+YuCFudXUrYWoBYs3CF8AAzhLWH58ea5klXbgU3oPcNcgOHVUMqPIGPCOjjz?= =?us-ascii?Q?wfgg2Q3etcroGbrj5S8Smfo2eMNRXMU0mh4a+F+/be03rtbPrtwiWQ3AYf9N?= =?us-ascii?Q?G4TrMCv5DzSv8BXlKFcDe3jCNptnR7tTK0FtyXAJim4SkhuGkqZiKPQ1uMEe?= =?us-ascii?Q?4v8ZGU2Yc1VR7TBCQv9iT92BbMcp1WHvUSdaxPhmDom4lMLXk+I1F55VIr7z?= =?us-ascii?Q?IquF2/O4brXZmBlgop6jmcb4gaHIfhjIda5CTeIeFxUOfOwj9l//PmErVlr9?= =?us-ascii?Q?DtQwfYQfuw5/EwyQLpquKeajiznChfOlcnVQCtOtkB+STEQlhmQkyekCMqMS?= =?us-ascii?Q?Mcl8zVJ6sH4mU8MgNM1MuLDtpcmt55sTijF5asHDlNjwcnGromvk+MGxIkCK?= =?us-ascii?Q?GLyztyuOIEa3tu8ZSFfuwNEqcwibuibs3BJDyyScB1IluQ2ZMc7L686LFRtA?= =?us-ascii?Q?0RA9mPSuny35elgyVHr6K+WJcOkk4TmgTbcyLOBcBqgjBKMaoh6VrBvAv4ID?= =?us-ascii?Q?BKJ1VknuN2DH9/RizrYCrW/KhiNDa3JT+H4bx5sPHuzRGK7x6Xp4MTPEDQjW?= =?us-ascii?Q?pY3s5nHq2uqOYBT9+vMxsyfxb7euhWWKQyFPYZ5EsBTJSeqg90Q3QAV0R5GI?= =?us-ascii?Q?uQQTSuNMSEc1L0JcsfVoePX3qmjd/fhPVCIeyiUzJ1/HdkAn5we5RHbv+ug8?= =?us-ascii?Q?xuRRJqOCgQNx5ur1N8vW9cHlTKGunUVc9UqGUIaJYAQTaHDBojjPG+jzxnrL?= =?us-ascii?Q?s8x+q/6cHmqJkPacgDIZP+CbXs/OatWwqJLBS6InNfpYqJ7pjnONBXYlD9PP?= =?us-ascii?Q?MHPvTG7hxO855MG3irp5NEU6lxo+tWa2EbR4wWqN64PlzwmIEFFEc5wjnBiw?= =?us-ascii?Q?K68y4rqqMf6itwRWoQA6CBBxR9v/olL2LyHCpXQYjgn2GlrXkaU9Vhedj7+G?= =?us-ascii?Q?rPNMldw4Fk/Qb6ffD7FQMy7Fxc7HhLh0oOysEshcONCXVHsd/TgGVfR01zM9?= =?us-ascii?Q?6ZfTqeiLf9iJYRu3qBz4CshOs0eaStB2/GPqsMVTSpWTGV1kXVQVsWM8StID?= =?us-ascii?Q?n/cu3UxuyW7KI2pZxKRU0PhqRDnwIb+2iXN906i5RDd4omEaxBp75PUAYFDp?= =?us-ascii?Q?6lg+IPsP8DavNhJfSlCH82VEL8KUPkcd1xifGGWi?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:20:05.6196 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a0fc26a3-fc5c-41f7-aee0-08de4396cab1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00029928.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PPF5D27497F1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/4ab28d40af68b2bffcd1cea2a9ab769e62fea20e Thanks. Shani --- >From 4ab28d40af68b2bffcd1cea2a9ab769e62fea20e Mon Sep 17 00:00:00 2001 From: Radu Nicolau Date: Wed, 27 Aug 2025 09:23:58 +0000 Subject: [PATCH] crypto/qat: fix ECDH [ upstream commit 25ef596203a94c79b1c9fa8504839c3f41da1a57 ] Read EC parameters from the xform, not from the asym_op, where they may not be set. Fixes: 305e1f856f0c ("crypto/qat: add ECDH key exchange algorithm") Signed-off-by: Radu Nicolau Acked-by: Kai Ji --- drivers/crypto/qat/qat_asym.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c index 4bc087987f..0a40e69da1 100644 --- a/drivers/crypto/qat/qat_asym.c +++ b/drivers/crypto/qat/qat_asym.c @@ -793,13 +793,13 @@ ecdh_set_input(struct icp_qat_fw_pke_request *qat_req, qat_func_alignsize = RTE_ALIGN_CEIL(qat_function.bytesize, 8); if (asym_op->ecdh.ke_type == RTE_CRYPTO_ASYM_KE_PUB_KEY_GENERATE) { - SET_PKE_LN(asym_op->ecdh.priv_key, qat_func_alignsize, 0); + SET_PKE_LN(xform->ec.pkey, qat_func_alignsize, 0); SET_PKE_LN_EC(curve[curve_id], x, 1); SET_PKE_LN_EC(curve[curve_id], y, 2); } else { - SET_PKE_LN(asym_op->ecdh.priv_key, qat_func_alignsize, 0); - SET_PKE_LN(asym_op->ecdh.pub_key.x, qat_func_alignsize, 1); - SET_PKE_LN(asym_op->ecdh.pub_key.y, qat_func_alignsize, 2); + SET_PKE_LN(xform->ec.pkey, qat_func_alignsize, 0); + SET_PKE_LN(xform->ec.q.x, qat_func_alignsize, 1); + SET_PKE_LN(xform->ec.q.y, qat_func_alignsize, 2); } SET_PKE_LN_EC(curve[curve_id], a, 3); SET_PKE_LN_EC(curve[curve_id], b, 4); -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:36.535324842 +0200 +++ 0003-crypto-qat-fix-ECDH.patch 2025-12-25 11:16:35.258969000 +0200 @@ -1 +1 @@ -From 25ef596203a94c79b1c9fa8504839c3f41da1a57 Mon Sep 17 00:00:00 2001 +From 4ab28d40af68b2bffcd1cea2a9ab769e62fea20e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 25ef596203a94c79b1c9fa8504839c3f41da1a57 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 80f7e5cda2..8808337551 100644 +index 4bc087987f..0a40e69da1 100644 @@ -22 +23 @@ -@@ -798,13 +798,13 @@ ecdh_set_input(struct icp_qat_fw_pke_request *qat_req, +@@ -793,13 +793,13 @@ ecdh_set_input(struct icp_qat_fw_pke_request *qat_req, @@ -30 +31 @@ - } else if (asym_op->ecdh.ke_type == RTE_CRYPTO_ASYM_KE_SHARED_SECRET_COMPUTE) { + } else { @@ -37,2 +37,0 @@ - } else { - return -EINVAL; @@ -39,0 +39,2 @@ + SET_PKE_LN_EC(curve[curve_id], a, 3); + SET_PKE_LN_EC(curve[curve_id], b, 4);