From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F103470E5 for ; Thu, 25 Dec 2025 10:22:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 181B4402B2; Thu, 25 Dec 2025 10:22:06 +0100 (CET) Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012000.outbound.protection.outlook.com [40.93.195.0]) by mails.dpdk.org (Postfix) with ESMTP id EE71E4025E for ; Thu, 25 Dec 2025 10:22:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FC1jSNMMGn2Y2PWa1Umd/iQ67JJpxzA7EGMLDGMBenJWX2Ij1LaNCSOgJCrviRoOS8eX8IFjYcmL9R7XJ4wJU2r5VLsq/Y9paRjTsP5obnB0avfVSA2192HwJ0mqotJaT0hxQjHWouOoF8D28Ykks1DDu/KAC2RBzED34p6FRS5yefg0YEKIiRb7oGqqV5xAN1HqRhFc8CObAnOG0aoCfUQ70th4I3Lft/SlEBWDqYJ5ngzeiNNTVjEo5KGMrwRwMdvktqJtp0I21D2amdQV4WRJKALfW1KVdDzUguYZHKbryzyWAd4PG3s+Uv4An02RktlnkgewgkkytOIfkmNn/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0o8eqIBaB7cPXO+R6HrB7dbqZOsqrsAzg3dQtcn5jq0=; b=P7f/4Z/6AMlWLqHREIxD56fsjHFSaXWbsncV1D6NsTTGCBNTVAvJvf7MdqSZKGCwaNK/Adh/w1O8PcauGOCW0hmoKLvAHbE8cp6ll+x7jDDaaOWBLodYVuJ8hl0AWHD9IrIhiokWSFHQM7rzuOjeP/lrZaqQe5IUk2Sg8BVE8jUdxOJeW3xP1TOzF0+g6xBlryevZH/Rb0qmFRyd1riLHuxWz9ERUtNE6fDm6zJq+0upmeKkwIB1CD5L2OFU6vGi9UH1d1pTjIJNgzw8wbKS1xiA866Rzk01rZdRUo4n93E2qN11H+MGmxmLC00C8LdztYuMwmSx0pz7TePqcv8odw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=nxp.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0o8eqIBaB7cPXO+R6HrB7dbqZOsqrsAzg3dQtcn5jq0=; b=IGnS8GOIRxd/Vg+3vhUQujGFPPSy16nwL7JKcL7xO8m9F/7lnLQo3PyzRvxlsu4fFw0ORGF/v6VMOvr4rf6PTleX4wh748UNU7VJ0lGSRnD9RapnumdArhNfjjBMuf8GMB8sF+QSxXEAXQJxvvghAbTlTINCXUXrTsgpVgHuy0OnRNBI8Dg6aUxLWhlOGovvrHrmKwX6v89xT48ui5x6XFXLx8fr7DKQsebDiPlrkVGyN/TMzy1uBF4Ab1iQ0x2fyIvESv6dkp17MvqZm0OFPxCWIdZmDYzAMLu43jNTIiSVRtu9FR5fZVrZmIhD0jrWTO/r1eQ/gszy63qHpJ1YBQ== Received: from CH2PR03CA0008.namprd03.prod.outlook.com (2603:10b6:610:59::18) by CH8PR12MB9840.namprd12.prod.outlook.com (2603:10b6:610:271::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.11; Thu, 25 Dec 2025 09:22:00 +0000 Received: from CH2PEPF0000013D.namprd02.prod.outlook.com (2603:10b6:610:59:cafe::b5) by CH2PR03CA0008.outlook.office365.com (2603:10b6:610:59::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.11 via Frontend Transport; Thu, 25 Dec 2025 09:22:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH2PEPF0000013D.mail.protection.outlook.com (10.167.244.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:22:00 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:21:53 -0800 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:21:53 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:21:52 -0800 From: Shani Peretz To: Vanshika Shukla CC: dpdk stable Subject: patch 'net/dpaa: fix resource leak' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:17:53 +0200 Message-ID: <20251225091938.345892-32-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000013D:EE_|CH8PR12MB9840:EE_ X-MS-Office365-Filtering-Correlation-Id: ee9a9d44-4d1e-4498-d18f-08de43970f1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4kGemDje1s+i6GgM8HKbmz1K8sQ4s5xK0DWi45SQXGoC7bdkhtLZDkLXZXAB?= =?us-ascii?Q?fZHH3lSWFtkQ7QhbuFPotfNTcVjkAk61ptQ4NysbK12ur/CPGbdgeFrbzdsv?= =?us-ascii?Q?bds/RAnriG5Z4mbe/5oYeVLX12F0pgfed2eE1JJJJ6y6U1B73M26FAjYDP5F?= =?us-ascii?Q?ogRQd1TOB47ufnEjvujFuQtcFzoqiVIPexBYpdn5WQRcwEmD8uYKiqqN8s0v?= =?us-ascii?Q?4ZQFy3KUWUXsWE1TpOAikxcOIT1PqcdJo/XXstTyG2VZo0TX8SEHZg6mkyBy?= =?us-ascii?Q?gWHcrORXn4kGegCAci2O1CcET8HkhYetbELj1UP0ubeix7yTva1DA1l2EQl8?= =?us-ascii?Q?OCZJmTymONSLz6T/RyGkUP1Qy/h7BfIVei9Gylwhi2HRlntkIxmPSAc3ZFpc?= =?us-ascii?Q?ELi1Shh2g8ihfi32DVHBHW61+QlBAN3x98NB1W5mJOn2JomqXcZaB4L33jD8?= =?us-ascii?Q?k26yW7MP8K1LdRhHS5AnO+a6KnTZobsx+odr6XGUieFeiuQc3fGjBWo+Gl+R?= =?us-ascii?Q?L7paEmvy004sLbv1+MbM2YZzg8HB3GP+CvmR467qIKjwCoZVZDEgk/Qn4dwh?= =?us-ascii?Q?vegbjT95kfPmRwK11qXCAJKN/66ECGifEVMvYQyZNPhN3w/uOj4iQPzN1RzO?= =?us-ascii?Q?kX7R+8f+PA95afXhF+W2phby1byfK5NhikTVnXySX8HrHWzMVRvMRbj62oG2?= =?us-ascii?Q?DK27C44s33E4EGJ/VXq5pwPseZA1Njzt3qEWlAVLIA1rlFYgQSVUDO8zIuQ9?= =?us-ascii?Q?qL7IxB0sRHur/B5J0j5MG2u4whPO0rxEZyCPfHLFbdakp4VM+crGD+WnVVmX?= =?us-ascii?Q?SNi0otqwkEFUQCZK5YR5OxFZbcWU+TXAeeb7GyThA3+8SXL+ojwEUbW1ffFk?= =?us-ascii?Q?fUrGYZQuSJF61HuzJR7htMtk7oqPJo/U30k4yi4P+Nhon14zGP/8NOK0o8Cw?= =?us-ascii?Q?x5qMpDApgNoeaS9f8to/XidhWwbc9Gvivex5dP7H1Vl149+cJkDXoV0HF3ER?= =?us-ascii?Q?4DJxTIEmMJdGzU4ZLuXexpLnYaQ+OlgsyNPVpLo1QEkNXCB54QnGQYOyojTj?= =?us-ascii?Q?sMtuR0rG7/e/aFOed3Y1kce13n85IUGrmXrTewIZSUGZ/6aoZTOdSv4wp2gr?= =?us-ascii?Q?Zoea4tWKg7PIKyZ9l2cVBWKGIOw0wb8ymgKTmFTB+KGqYZzRQbMcpXQPz4zo?= =?us-ascii?Q?I4vii/YTH8nqQqpfQeP3tQ5Wep04vcbsoekGaz+CK9dKzXoXA1Sjpvwod6WA?= =?us-ascii?Q?Cyk3MEA/ed9UatBkyNxeC0GwRPXTNAYGHvSTq8w9dUfDHAw6YX/5tyJreC66?= =?us-ascii?Q?Vk2N9HdUyKn6BUW/LLiUuzZ85a65ZvZJegXchuyuj9rpEwZcmXrzDitd8oZ6?= =?us-ascii?Q?ardSOenW9KeS6oUhxs47AfNpXDG9o+hkJ6Jl2YeO2iolI4Tbhyw1u0Ufjsou?= =?us-ascii?Q?7fLrmS8qXf0uoFsYoEAYxcdpvwhXjM50/6v9VZqpqqryRpOmjgWKNsPFczL6?= =?us-ascii?Q?qYcvSxmd0Ws9IsEyYbBjkwbOOas38xnDdT/joNR7TWsZ1WzreFXSIYZfGcIt?= =?us-ascii?Q?RIuB5gMVCG7cgwGPNajhZ9jNh61Gz8u0szVl17he?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:22:00.4395 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ee9a9d44-4d1e-4498-d18f-08de43970f1b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000013D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH8PR12MB9840 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/2df9f3f2c249b5ede674d3e431114a45eb7bae76 Thanks. Shani --- >From 2df9f3f2c249b5ede674d3e431114a45eb7bae76 Mon Sep 17 00:00:00 2001 From: Vanshika Shukla Date: Fri, 24 Oct 2025 11:49:06 +0530 Subject: [PATCH] net/dpaa: fix resource leak [ upstream commit e7665de896836e99866ef8016bbaa12223e1cfb7 ] This patch correct the cleanup order of PCD and FMan handles to prevent resource leaks reported by coverity tool. Coverity issue: 362787 Fixes: 4defbc8cbb6d ("net/dpaa: support FMCless mode") Signed-off-by: Vanshika Shukla --- drivers/net/dpaa/dpaa_flow.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/dpaa/dpaa_flow.c b/drivers/net/dpaa/dpaa_flow.c index 690ba6bcb3..4ce8e88d66 100644 --- a/drivers/net/dpaa/dpaa_flow.c +++ b/drivers/net/dpaa/dpaa_flow.c @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause - * Copyright 2017-2019,2021 NXP + * Copyright 2017-2019,2021-2025 NXP */ /* System headers */ @@ -889,9 +889,9 @@ int dpaa_fm_init(void) /* FM PCD Enable */ ret = fm_pcd_enable(pcd_handle); if (ret) { - fm_close(fman_handle); - fm_pcd_close(pcd_handle); DPAA_PMD_ERR("fm_pcd_enable: Failed"); + fm_pcd_close(pcd_handle); + fm_close(fman_handle); return -1; } -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:37.908564344 +0200 +++ 0032-net-dpaa-fix-resource-leak.patch 2025-12-25 11:16:35.534915000 +0200 @@ -1 +1 @@ -From e7665de896836e99866ef8016bbaa12223e1cfb7 Mon Sep 17 00:00:00 2001 +From 2df9f3f2c249b5ede674d3e431114a45eb7bae76 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit e7665de896836e99866ef8016bbaa12223e1cfb7 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 2a22b23c8f..417b9b6fbb 100644 +index 690ba6bcb3..4ce8e88d66 100644 @@ -25 +26 @@ -- * Copyright 2017-2019,2021-2024 NXP +- * Copyright 2017-2019,2021 NXP