From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A1CD470E6 for ; Thu, 25 Dec 2025 10:22:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CAB6E4065D; Thu, 25 Dec 2025 10:22:39 +0100 (CET) Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012068.outbound.protection.outlook.com [52.101.48.68]) by mails.dpdk.org (Postfix) with ESMTP id D92ED4025E for ; Thu, 25 Dec 2025 10:22:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OGgDfYe/fmyHZqwhH5Q01kWGX3RSMFCYpv+vmxMfJTX8xzraW3MrPZmWP78xtBpehz/8+Amqw7vhDo3K28zGgGRAkKK5tqunB8O9Q27E/VCOvr0EaziDPhrwZDvrHBeKOQDF1nmbWwVthrBpgpldJrGRUR/9VDpKULSEpq8sPB5W4P29EROMRAMJUTt4ap15GBAiIudm2q9U6Q+CuL7XzClPyXJYZ1Ypqokyg8OFVCGB0FsNrGtDglzzQfnfQ02HApWCK7qwmiSWXbORGoKsj9RFFhmpCkLcdRyvKwofgkNj3G+vtQW8qVF4OaKifUCa3z4pUfKBTHuoUxwv26wBOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lG9ddP1BcObsfa6yWZShZAauTh6cs38xeod0B6fVBO8=; b=BCt/nXlAb3vfOzKJZ48i7//qPV77dC7yX/i2cMSQaSZA8mtcWjE60moYRDOZPtO5JPbuN95ekdBIIXY5SCmggEdfy7Xa/eQ/U1z8nSK7x/6Ulj3q5tldYUVA2DQFRTYG8dj4ZjsApKhC421LzzbIzQsH6f908GL8N4JsrJA8YTGxz0W8w+8/ZLpN6v5fxqq+o1vdxey2W63VwwLxOphyg0QjaKBYg0mYTSHZEv+Pd08B6hvO2N1y1vqYomoCizKUDeIi04wq3UHmg8aloaVqiB+hThYFw/hg/YpG1aZngn4w+aQkzGnTVo1Y9OFyClwCTrlnTgCKhpsA2vmiXAvWEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=trustnetic.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lG9ddP1BcObsfa6yWZShZAauTh6cs38xeod0B6fVBO8=; b=oKIknYLB/xsQpgM5EE4/5o+8v26yqGtjeAn4GBvxE9Gbe9hysl9dMGg8NsYZlQw9FXHmRiZ4d37NyYj9OShckR/3d2NuDRg1EImmKtB7pCY/ricpHf4NbTzd1+F3sMktAAt0055d2fHSsbNQrl8uP+wlVXb04IRfLYdMFUZHKhbKGjgKfnyySppLNeso5q4/kijuhvs0EX7oQb6bjCkFc0ALi9mBjaR/wgDCI6K6YJVfw7Pjx+/q/REB72AtrlE1pUsNIgsttcD6jpp4nEy6h8xMLjbLbo8SWwdlky+ufkerFKk920ymxiF/fYCYpohqNtfhL3tV/KyZrreo9Uqj4A== Received: from CH2PR20CA0023.namprd20.prod.outlook.com (2603:10b6:610:58::33) by DS0PR12MB6391.namprd12.prod.outlook.com (2603:10b6:8:cd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.11; Thu, 25 Dec 2025 09:22:32 +0000 Received: from CH2PEPF00000140.namprd02.prod.outlook.com (2603:10b6:610:58:cafe::77) by CH2PR20CA0023.outlook.office365.com (2603:10b6:610:58::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.11 via Frontend Transport; Thu, 25 Dec 2025 09:22:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CH2PEPF00000140.mail.protection.outlook.com (10.167.244.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:22:32 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:22:15 -0800 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:22:14 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:22:13 -0800 From: Shani Peretz To: Jiawen Wu CC: dpdk stable Subject: patch 'net/txgbe: fix FDIR mode clearing' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:17:59 +0200 Message-ID: <20251225091938.345892-38-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000140:EE_|DS0PR12MB6391:EE_ X-MS-Office365-Filtering-Correlation-Id: a273951f-229d-4e8e-8001-08de43972226 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|82310400026|376014|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?TT37JXA+LsqdKz2aSVFuukbKYzYd8WGnefLoguiNauvW+E7F/ZlIlqF2l/Op?= =?us-ascii?Q?btvI5/EsXwCb2IFwjC/MLZRK6pUsOHCp5uDTnqLF56U1NfYnxYcGd0kAtRG1?= =?us-ascii?Q?VJDsfkoez1nEhCoBJ4aHS8nu4kRSRFnAtFRAUaOLR52M8zYwM9cDy4yVjQd7?= =?us-ascii?Q?LX2DIpHzxt0Ft4rLoOeNj9h4i3YtfA56zpCp+0pAh1oh/kcC1RGep5M5D7up?= =?us-ascii?Q?+GMuitYuYXbQGLl8LuLFHT93OeXPfdoeSeb2Yw6xL8M3ws426l97AgJpBIGt?= =?us-ascii?Q?u/uP155lYibFFrKQSLcqmYiq4VAyflbAuqe28xGcvcjJ3b+3GZrOLoUeSLBF?= =?us-ascii?Q?Kiov/eBxPipjGN0wjqiCjNCpni2y+770i76WQWe56ndxV9klfiqJaxPZEBuX?= =?us-ascii?Q?icMAMdD8dO8PAI9M7AmNjmLLo7S+jBJP6puwbd8XdpwFVnjPH7T5vHrQlNEl?= =?us-ascii?Q?jWHqC2kEIcyfDIby0gapIze7zW/gBS9wWX6jtAtj+TSGhP0S9BYWBPUKNpk6?= =?us-ascii?Q?dJAHKcHIAH+OLtiDx2URTb5PrCb9qttd8jvA5QNz0DPKVU3iEsk4BRvZVC1i?= =?us-ascii?Q?AkYzUtSu2MmdTrsJdwUOEM5P3emY+rRHuU61aNcPoKWufQY9l+ZChy2nl9Ac?= =?us-ascii?Q?oQH4u/+KUlY/x1zlbfNbJbL3FRsLlNqquqdbuTuTmHd2E9GiPa0d6UMVk1B+?= =?us-ascii?Q?nuWs8UcazTXGGmTUoEaunjE1Ii79Jvx+TF7FA1NdXYZZ94DKKwP1H0e0vIA0?= =?us-ascii?Q?MMNEODa+3xXvBOAhaDgDDQdRki8y003P0YyreNg99TqodBZhSfLfYyuuNSyo?= =?us-ascii?Q?KV6YwUJFtkdfEz69fL0kU6ZHs/oHywU5/TH1b5P245Gk8zcCg60hRVqEPaZr?= =?us-ascii?Q?D7H9dFl88FaWAyRjypvBM+gD3AO2cvdiTRmekc3Y4os0V76lAQFx4hzX9DIV?= =?us-ascii?Q?JacEVzthrfzESLnBe2UBSjble0Godzi2e80AMBNwb2zpZdhLYQAxHtreiiNE?= =?us-ascii?Q?QeQU6biynWaUHdy9rWUwYXd1LczKZxcFH+BxHRsumTloKxO018F2Pifl77lm?= =?us-ascii?Q?k7evVcMoDJaW7dUrBDhoVjIVOZ8h8UjMZpYFlmd96gl2WEVUXM3zNjO1CuL8?= =?us-ascii?Q?VjbmLi04lDThMjBKHHqFCrGfDzslrF3wl4/FldA4uex4CV1K5wl8B8QkY5+s?= =?us-ascii?Q?DJvm+bXpslfDChcTS6Nk6aLUwK7LMB1vArzuWXg54UE8QkxqqjIsR4ylMcb4?= =?us-ascii?Q?4LMbvI9Rjnsazl0h5OJPYAlMAove81d2toLCm6uuTvCHgUwpMxoMQQ3C+CAV?= =?us-ascii?Q?VWood7kW3Rceyx19mv96NDAee0DTy6UG2xIY/JEjQF1n/vJmeVz0wdnjHmF7?= =?us-ascii?Q?LH5PaWLbV5tZkUdFT6eBe8e0Xt0j1VmiQjEQTToA65TsrNCOwG/TlBFoCW1Z?= =?us-ascii?Q?zACfjODJJK8fUm1QpHLqf1orO4tEvNh1eC+4wB2EFNEK9FFQZi4HakA8rD/e?= =?us-ascii?Q?ADKRMqWjkmhlxPlCYS7wJh7OsgcjjpYFWUWhANLuYCEjYn6Gl0ixWJuZSuf0?= =?us-ascii?Q?5PDjJogadostqR7KMc3mE6O3Xy+dn3Nj/tSOmTXt?= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:22:32.3870 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a273951f-229d-4e8e-8001-08de43972226 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000140.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6391 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/b37e7cf39d4ce667bed46babfc8a7512b12154a5 Thanks. Shani --- >From b37e7cf39d4ce667bed46babfc8a7512b12154a5 Mon Sep 17 00:00:00 2001 From: Jiawen Wu Date: Mon, 27 Oct 2025 11:15:33 +0800 Subject: [PATCH] net/txgbe: fix FDIR mode clearing [ upstream commit 26048c25942f2579a821a99b78db48fdb2c90c77 ] When FDIR flow rules are all cleared, FDIR mode is not cleared. This will cause that creating new FDIR flow rules failed, for their mode are different from the previously deleted ones. Fixes: 6bde42fe7fa5 ("net/txgbe: flush all filters") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_fdir.c | 1 + drivers/net/txgbe/txgbe_flow.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/net/txgbe/txgbe_fdir.c b/drivers/net/txgbe/txgbe_fdir.c index c4cf39997c..8ba42fa8fa 100644 --- a/drivers/net/txgbe/txgbe_fdir.c +++ b/drivers/net/txgbe/txgbe_fdir.c @@ -976,6 +976,7 @@ txgbe_clear_all_fdir_filter(struct rte_eth_dev *dev) memset(fdir_info->hash_map, 0, sizeof(struct txgbe_fdir_filter *) * ((1024 << (fdir_conf->pballoc + 1)) - 2)); + fdir_conf->mode = RTE_FDIR_MODE_NONE; filter_flag = TAILQ_FIRST(&fdir_info->fdir_list); while ((fdir_filter = TAILQ_FIRST(&fdir_info->fdir_list))) { TAILQ_REMOVE(&fdir_info->fdir_list, diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index a50bdffd62..d53aaaf452 100644 --- a/drivers/net/txgbe/txgbe_flow.c +++ b/drivers/net/txgbe/txgbe_flow.c @@ -3064,6 +3064,7 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, struct txgbe_fdir_rule_ele *fdir_rule_ptr; struct txgbe_flow_mem *txgbe_flow_mem_ptr; struct txgbe_hw_fdir_info *fdir_info = TXGBE_DEV_FDIR(dev); + struct rte_eth_fdir_conf *fdir_conf = TXGBE_DEV_FDIR_CONF(dev); struct txgbe_rss_conf_ele *rss_filter_ptr; switch (filter_type) { @@ -3123,6 +3124,7 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, fdir_info->mask_added = false; fdir_info->flex_relative = false; fdir_info->flex_bytes_offset = 0; + fdir_conf->mode = RTE_FDIR_MODE_NONE; } } break; -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:38.212129929 +0200 +++ 0038-net-txgbe-fix-FDIR-mode-clearing.patch 2025-12-25 11:16:35.608943000 +0200 @@ -1 +1 @@ -From 26048c25942f2579a821a99b78db48fdb2c90c77 Mon Sep 17 00:00:00 2001 +From b37e7cf39d4ce667bed46babfc8a7512b12154a5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 26048c25942f2579a821a99b78db48fdb2c90c77 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 631dec69e8..77d0cc4c30 100644 +index c4cf39997c..8ba42fa8fa 100644 @@ -23 +24 @@ -@@ -970,6 +970,7 @@ txgbe_clear_all_fdir_filter(struct rte_eth_dev *dev) +@@ -976,6 +976,7 @@ txgbe_clear_all_fdir_filter(struct rte_eth_dev *dev) @@ -32 +33 @@ -index 31af3593ed..25cf0db316 100644 +index a50bdffd62..d53aaaf452 100644 @@ -35 +36 @@ -@@ -3429,6 +3429,7 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, +@@ -3064,6 +3064,7 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, @@ -43 +44 @@ -@@ -3488,6 +3489,7 @@ txgbe_flow_destroy(struct rte_eth_dev *dev, +@@ -3123,6 +3124,7 @@ txgbe_flow_destroy(struct rte_eth_dev *dev,