From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7A7C470E5 for ; Thu, 25 Dec 2025 10:23:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58D3A4067E; Thu, 25 Dec 2025 10:23:10 +0100 (CET) Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013054.outbound.protection.outlook.com [40.93.196.54]) by mails.dpdk.org (Postfix) with ESMTP id 1A5D640656 for ; Thu, 25 Dec 2025 10:23:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PX+8hAKhmhQjbUoJO1AE56PK/uzZbGt97fl00aduy9ZjLfvH5iO9xLibjKxbc7u4tTovEMlAio+1wI6H+8cIkDlLeXNp45duVK8s8BtI/vytYBM2U/x9T8Yf7jSmebZRcmmNFUu1SD6zytLhD1j7fZt7mBB7BnR/V32yjKmuS1ntMXLk1/ekdXXl9kL775+EaNTGX5o7rPTHfesgunphMikLxPD2Wjonq/gSPSJ/kPzpkAwQqs4AM+MnnXpNs0m7TyFX9lXEv+8Iw6y1Z9k8qHjkIWifHelox8c+lx5bWRXjwToL/Fsy2XBFo1+F10RxOgLkdmkGJca2DNHQjdepuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=//64ByFa6RBUY3uEtyQ0Tud/C4NryLQaSPxkBimZFik=; b=bPXsHzGC5fW3KE/9oRroeSmcH/SuXeu57SBmX7VbeoZnjiFtd2aSCOJb2S08kpG6fI0DR3xlsbLpoR0uUoEngs5UntqOuINa2BYyVyKRzFoB11ba0lo0fdi3ZAZavAStmgv++RivLjNNRK4u/LkxOau9yIpJvYoa76fkLDMupgb4A9ijz4r1adw1U/XrZcTzz+HiWzzD2/fDVGmi/bM+koLb6s5iLu5NFBSI+oFRs09ILfPlmcftbPEquKUAzvvbrfcyEtI6ghRQ4SPkzkXHm9CEMEbeVP1Chy8Qvi9w0U4k0NCTVu7b8+BKOxhMEC9oj+aoSW4HL2V+7uri7C7h6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=//64ByFa6RBUY3uEtyQ0Tud/C4NryLQaSPxkBimZFik=; b=sdFH0zW3JjtaHPI1JqwOpZ6yIh0ZGXL1PQM0yJL/aSfVLchduaAT+t3shZ3wTBoosWUiup1gG7fF7VvN6HtF058OXugcwWsC8T6Qv6V442iImXQx+0za4dVTeUUSQIyRjaBPFSCpsqLEj89yV9eH3A12EVZcNwgngCaOJVQknUmmLaQKZ82eNNxqMfMWHypkVralKVqQZmsF+jH22/vE1xy0Q0DspPlIY6MvOvFGFkFpHXG2jjkdBidVvyzqS7BP5tXS+Wnni8DLo0Lx1lGwaUm09EjW2TcGWt3te+7m6Jquz4ltyd+ce89f2G7mvpWosI33YaNDOZ5T+RC7i7WNqQ== Received: from CH0P221CA0004.NAMP221.PROD.OUTLOOK.COM (2603:10b6:610:11c::14) by DM4PR12MB5770.namprd12.prod.outlook.com (2603:10b6:8:61::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.9; Thu, 25 Dec 2025 09:23:05 +0000 Received: from CH2PEPF00000141.namprd02.prod.outlook.com (2603:10b6:610:11c:cafe::ba) by CH0P221CA0004.outlook.office365.com (2603:10b6:610:11c::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.11 via Frontend Transport; Thu, 25 Dec 2025 09:23:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CH2PEPF00000141.mail.protection.outlook.com (10.167.244.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:23:05 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:22:54 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:22:53 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:22:52 -0800 From: Shani Peretz To: Ciara Loftus CC: Thierry Herbelot , dpdk stable Subject: patch 'net/e1000/base: fix crash on init with GCC 13' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:18:08 +0200 Message-ID: <20251225091938.345892-47-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000141:EE_|DM4PR12MB5770:EE_ X-MS-Office365-Filtering-Correlation-Id: 2328b43e-a06b-409d-fca7-08de439735ae X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5vaSuMK3aULpa2Je8vDRVtwzn3vKwIGwju1BYINvsuqOcvjU0RFfmqwtm2bc?= =?us-ascii?Q?mQIygbXcxcWP2GLdTplRJijjpfi+grxF0S5iNrdemLoTuLs1/a2G6Sp3PI6T?= =?us-ascii?Q?8/Ui3Oc8/CbAkt5UXQk/8ry0Cub0YoXTCY5vbw29EYozDwiMQQJgU1FXDL6w?= =?us-ascii?Q?RH23IezKzEG+rLOtIKPGa6RhUH5lWLaG0RmanPsuYMuqmdMK7fsy6IvkDQNW?= =?us-ascii?Q?PhmCP2DckNzkr2co2LgO6ufyuTlNDYNuTw1KJ+urGzILVbkCmACXVEX3QbM+?= =?us-ascii?Q?u9GmNZEM2JxVkZLyIPM3FzrUiM//jabdH5OzkZCs1BxxWuYQZe0zRXRLl0ZZ?= =?us-ascii?Q?4h8f8g556RmcR7MNWtgR/kP1aX3E7XDOAkIevli1xANKKpNzZsAXph1eRnQj?= =?us-ascii?Q?h+/2/WM8oF36cxJotwCbowGL+qOzomPPFzSPRp3rp7YdYlBlg8Zi4l2zvEfQ?= =?us-ascii?Q?hwjDiB0d7GWZEaJCw4AR1kehewDmFCVaFpLrbdsYMbgmRXIhrNkww2Mogwr9?= =?us-ascii?Q?xu07hfzZKS8+09boxOt5J0Kd+VDXFYBkhSvLQ7+NY6mndrQzVjoqkgB1cz2Z?= =?us-ascii?Q?jJPdXDt9F3qpIKWdFkt7OUzWxIDh3WI0HVKbo8Ng2g98R2YDuuOvPuA12Cm9?= =?us-ascii?Q?nLWiOQMdBhpieZ7mIzRUF16oMP8uvfSolT8dMuKQYllmQdChukrgCXLX0rUE?= =?us-ascii?Q?oa3dshomhz31TcN0tNtGj9CQR8xiLBvKTpWHWY6Qf7/wecCsafBsNk5Llp+p?= =?us-ascii?Q?aUP1RxTfgJfv3OYn3snPCKRsYNiIUbuF5tHqxqug/eOztl9KOpq31uXIzWDT?= =?us-ascii?Q?+A2HrYCAl6GK0HmWHOkrEwlnfPzMGsK2X0A3sf7P2wurcdAS99MLMXxFn3s9?= =?us-ascii?Q?io5SRr0xiUUzcloTFI8Szk8ZAyVrygQ/RZ+wklnZs0ACx15zezZnfNh/u1F4?= =?us-ascii?Q?265zd1TPWNxSndaMa2CK/DIBIHjkop7/nLs9j21BvVHf4tNJ+63YhLh4NgDL?= =?us-ascii?Q?UN4ZsAThFcu2Qw20lgmkghtt6pIkXXiCw4XRDmTu1cWPjp4ZbWM3mGEqAZSr?= =?us-ascii?Q?Grt4e6WdGEbT8Nd5ymA3URi+Qzp+68+FA+Yl79cGCq+Y8NojoKRnyZ0wuRkK?= =?us-ascii?Q?fY4Ty4BJ0aRbGqmbDhp/0p+kRu8C5AyMz7NL6eYhyS6tb/ahewUr28x8gsLS?= =?us-ascii?Q?smNhr3uQvPl0aPhXH01d0+n+WmXv4gQ2y8Xe1lbrj9t8fBUUI0FIp/ER7SHf?= =?us-ascii?Q?9nfDYCZnM3uwwwVexT0dzsvc4Wa1Z0Nj6AcfR2z3AUy3RJKJQX3QXUf9ddnN?= =?us-ascii?Q?f7lUUks5ERvpc05KTWZbGp97InL0KBu9a8NDsmp/V0JKBFCL+Eo+8Y8HoJz1?= =?us-ascii?Q?XfFd42ZZJ0Zt07OPyVvLjkiS7ICKTuGDznhVSYvJ4NOQrBU7kvTxjpNgraCA?= =?us-ascii?Q?86DuPnLhVXIYfE4nO6DuyYE/AdOBs9ReQOl2GB5tw1cOeFn0WW0NfQtrXR87?= =?us-ascii?Q?UNHQe+9RUUdOw1HFxQSbzmxH2ybdmW7yY+zBp7dBNyxl2JgDY3yUMYGorv9A?= =?us-ascii?Q?gQIsNgc0jr7u8dPiVl4yNFNaTfYizpO40tqcV3I9?= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:23:05.1364 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2328b43e-a06b-409d-fca7-08de439735ae X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000141.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5770 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/431171204f2f97c36cd29b2a4a3ccab2ec0313ac Thanks. Shani --- >From 431171204f2f97c36cd29b2a4a3ccab2ec0313ac Mon Sep 17 00:00:00 2001 From: Ciara Loftus Date: Fri, 10 Oct 2025 12:58:48 +0000 Subject: [PATCH] net/e1000/base: fix crash on init with GCC 13 [ upstream commit 4d0b1e252a58f9cee89aa08d6e9742fa4a797e91 ] The e1000 PMD crashes during initialisation in a Ubuntu 24.04 VM when compiled with gcc-13 with -O3 optimisations. This patch introduces a compiler barrier after the register read that was causing the issue. Bugzilla ID: 1691 Fixes: af75078fece3 ("first public release") Signed-off-by: Ciara Loftus Tested-by: Thierry Herbelot --- drivers/net/e1000/base/e1000_mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_mac.c b/drivers/net/e1000/base/e1000_mac.c index 5bb77d9e09..1ab5db98f2 100644 --- a/drivers/net/e1000/base/e1000_mac.c +++ b/drivers/net/e1000/base/e1000_mac.c @@ -1826,6 +1826,7 @@ s32 e1000_id_led_init_generic(struct e1000_hw *hw) return ret_val; mac->ledctl_default = E1000_READ_REG(hw, E1000_LEDCTL); + rte_compiler_barrier(); mac->ledctl_mode1 = mac->ledctl_default; mac->ledctl_mode2 = mac->ledctl_default; -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:38.645917123 +0200 +++ 0047-net-e1000-base-fix-crash-on-init-with-GCC-13.patch 2025-12-25 11:16:35.709865000 +0200 @@ -1 +1 @@ -From 4d0b1e252a58f9cee89aa08d6e9742fa4a797e91 Mon Sep 17 00:00:00 2001 +From 431171204f2f97c36cd29b2a4a3ccab2ec0313ac Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4d0b1e252a58f9cee89aa08d6e9742fa4a797e91 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -17 +18 @@ - drivers/net/intel/e1000/base/e1000_mac.c | 1 + + drivers/net/e1000/base/e1000_mac.c | 1 + @@ -20,5 +21,5 @@ -diff --git a/drivers/net/intel/e1000/base/e1000_mac.c b/drivers/net/intel/e1000/base/e1000_mac.c -index 2fa97d12a9..41aae86ffe 100644 ---- a/drivers/net/intel/e1000/base/e1000_mac.c -+++ b/drivers/net/intel/e1000/base/e1000_mac.c -@@ -1842,6 +1842,7 @@ s32 e1000_id_led_init_generic(struct e1000_hw *hw) +diff --git a/drivers/net/e1000/base/e1000_mac.c b/drivers/net/e1000/base/e1000_mac.c +index 5bb77d9e09..1ab5db98f2 100644 +--- a/drivers/net/e1000/base/e1000_mac.c ++++ b/drivers/net/e1000/base/e1000_mac.c +@@ -1826,6 +1826,7 @@ s32 e1000_id_led_init_generic(struct e1000_hw *hw)