From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06495470E6 for ; Thu, 25 Dec 2025 10:24:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DC184066C; Thu, 25 Dec 2025 10:24:12 +0100 (CET) Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012055.outbound.protection.outlook.com [52.101.53.55]) by mails.dpdk.org (Postfix) with ESMTP id EDF094066C for ; Thu, 25 Dec 2025 10:24:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f+U8Ta2nVtDGAO3yhAee4MSQjbVXqiiA/AxdWU1x1guteyDCKEU+OfxiCy79cM39C1oLs7xeH0qixTS9tivtI6c0ThNdsXER2psEixfipKEbN75fDGv0B9moAai0utiZkA/OcB3h2K3VS18qtwt8HmgN52orfW/PI7NXyj2MR917ZdYGmkueTuzbY3eGFZpy76273/sCvjT4iiwDEvDmMLkuwbmL8/Gvnt0lKzZw7AKYtEETTUlLxCb0Gr1cVaWHjRIuui95GOQ9W6fT5D8gKB8OH3O/Y5bweBQJrIzeAsEMaWbmf123kIRmC2o2hPQo4fXqjzCS66X2FLlbRrQsDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tIt0P7lNnGZW1SrWcrOPaOgUMAQsg/hWDeNvtJnNvSw=; b=i1mdt9jx7s4HSXl+ab5Zqm4C5j3WWIzDl/lK4QHwnNDSr/zVw4dlSkhdyfyhNhE4XRND+qIvvq14XOTn2oJ6zLAOS3tzzK2brsjYhBQTnpus2PaMhh+ZN+PX5ocLBF+iJkUzEzn8eNMe29UT7s5zJXalU93AIhiRA6qPSa8V2IOgV1knm29lgqeNmKVZqhtz8UTmr5ZkKVNaEVSG04RlVn5ozA9nILpr7aUDrJGWC1VFoYDV/ArpfQFwNfDiKrHP/aU7KNbm1JDxUczxoZzhtq7G34CVhcBQNInL+gdf8RlSq1RYGoLd95jtKrpy9ZYnANxrdxgYtKgCXU122FgeBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tIt0P7lNnGZW1SrWcrOPaOgUMAQsg/hWDeNvtJnNvSw=; b=Si/b0dcgwpLDaQYCHQFHWQ0Ei92xQPSmkk8RhNfeXwe/ezJRa1NPCm88dXLJmY7nW5RFGaXwNM/9xpQk2sZugrqyXgtv7xREWRtWfrgbdgJvwMoZxzyy/Hryn75eeLyvBqZ07pzDOIfM7laodcpVRvV4UrdOHd70mamnUyTG2afSwLV9D6uJvsunSvpA4pk7YlsVyOTi5nKZf9zMIj+68+72og6dFLRk6pehPvlUhSm4x6W0RkeI0YdvJpClOxE/3kCaTYXlD8iaLoczlunXOy8i1uVHeiwb2ofQ+GEbt5FID+qf+mT1YQM6gVm0bfH+itbEodGnT2LRzAvfUDYSVg== Received: from SN7P222CA0006.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:124::19) by CH1PPFC908D89D1.namprd12.prod.outlook.com (2603:10b6:61f:fc00::623) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.11; Thu, 25 Dec 2025 09:24:08 +0000 Received: from SA2PEPF00003AE8.namprd02.prod.outlook.com (2603:10b6:806:124:cafe::f2) by SN7P222CA0006.outlook.office365.com (2603:10b6:806:124::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.11 via Frontend Transport; Thu, 25 Dec 2025 09:24:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SA2PEPF00003AE8.mail.protection.outlook.com (10.167.248.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:24:07 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:23:58 -0800 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:23:57 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:23:56 -0800 From: Shani Peretz To: Bruce Richardson CC: Anatoly Burakov , dpdk stable Subject: patch 'app/pdump: remove hard-coded memory channels' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:18:24 +0200 Message-ID: <20251225091938.345892-63-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003AE8:EE_|CH1PPFC908D89D1:EE_ X-MS-Office365-Filtering-Correlation-Id: cf88f22d-e2c3-4f2c-9be6-08de43975ab3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|1800799024|82310400026|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9C/jvB9JqYlMeWTxUz7GaYMN7gcOGqS4LLxZKhVEMOWtq/NuTx0ZqESzXL/5?= =?us-ascii?Q?YC+u8zeGNcT4aFdlsBxODc29bbjR7D9QCyoxhJrc/xsKAQFmwFuf1p4xBmwB?= =?us-ascii?Q?cbm3j+ueo6wxwMy5rTiEogBhG2ucEz+InNJZYVDF/rg8/UGYRvuQLuYftKXN?= =?us-ascii?Q?O/KGADL414DwRie/FPzdWc3lMzVf1DRf02mJwqYppG7vAU48aaqkSqLdigFy?= =?us-ascii?Q?dzvkoz6seFrdCZEs7bIx4bVQoSU2Cq3eOT1ZR7TpDomFpFGfrr/hdXF0QoRu?= =?us-ascii?Q?FucvoKk2+XxD4FiIZmDhJy8Vsj7CYguQL/EivGZfdI+CGMuoO8V7asinYnrQ?= =?us-ascii?Q?IycrrtLShdGjrz07cx+qGgqV+/SPjlWEOrUq8QOeLKDUt4UlNj28NRHy3/Dy?= =?us-ascii?Q?8Rkeh1CxlCpH7Rj+7GaEb/fE12ceHW4Sr+ERqoT5YcJ5p4mkGriK18vtWZv8?= =?us-ascii?Q?+F0fjkL4bcQcgu3yT9zdoDuBRb2+ibrrTSBg5O4/6E91rMUEq/BY51N2jxLo?= =?us-ascii?Q?mtGnBvouNIO4QR3Tc+m0b5HjmhxotjoU1qWW46a6Dj70YDgQz9pSXBlY+mld?= =?us-ascii?Q?yytA/a4ZxiHBVb7M1G+zElql+HeVRrClkAHnO1uQpk6J6fB6cMH4TBqvIqrN?= =?us-ascii?Q?51JJIr0oaiKo3AWa94ED3qBsFvXLugummnmbWhbRVlIkxtTB9Gy0i/8LG53X?= =?us-ascii?Q?ozIMXAV1t0muU8Ol+KZq6A60K69o2ZIdwFzpGOzVDBAFe79ZetC1YMfBZjUz?= =?us-ascii?Q?NDGGSue5bFqq1haSv9mxsZSegvpU4AtCWey3hEZsoPl3Hy3ODnWgh6h5+g1u?= =?us-ascii?Q?rFaUMvGVcIQqn+wzxUqCNOGcF51AxgOBc2CwnhzfIcOU+1Es9Dq0sYtpgmp4?= =?us-ascii?Q?ukzlh4NnxMLCG6eltkpkcOOrc2FxxagtmsMW661E+3L6KtI6gBjkTBUFpd5e?= =?us-ascii?Q?25n8RpWe7qwti+sBX/HkDAR8aiiE8h+7loTGsZESfKvVh+7+BkF1VHizs0EU?= =?us-ascii?Q?v8z33jWs68oEaIuWFWgE8O4CgwDUUivHs33C/dfhZ2rrRDnX2QGPDFJRn5cz?= =?us-ascii?Q?uGonBccy7hzN0g51+bjAAX0Vg3kZ3mwU38gCAUn8m+WoQACalBsUu4AwP3Df?= =?us-ascii?Q?ELY3dYKQUeK3lkaKl2ukWkSg7hoLnQSGckjskr/OmzkwY/mgbspkaASoGaqm?= =?us-ascii?Q?0rhi2LwUnHi4zWcFIfTvEOI4lV2khF0vCAB4SfPXmnNKPtoXMvaE0rirTI8U?= =?us-ascii?Q?yuh65P/AXxeEsFGHusMZCQovtigauMuMjgI/wbIZbHAqUm+NIk/72jedkStt?= =?us-ascii?Q?rxeYhIUNw7myHS/wGK6SGsYPWxZ5+6BOmfFxH4GevC+SheVEwRNGJ8DSVD3c?= =?us-ascii?Q?O2POaMYp0YgYFqmyDnocFvBAf2OZ9sbEEKB+YaOjJ9IeYxfHqWekE4kthgFg?= =?us-ascii?Q?k9pw/PNQOEGDgq4ydZL83fMECwBulGwvkY9sRnRLMLAL8bTQuQ2uVYOrAVPo?= =?us-ascii?Q?Ekz1xLp8UOnOjQxSJUulP9o/7uJc6YhkSxIUzhrz8cU04OjcYch4zcNbGdM+?= =?us-ascii?Q?/4uHVJCTn3y3YoTo2qCA24OMbzwlfAeFLeBjB+Bf?= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:24:07.2880 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf88f22d-e2c3-4f2c-9be6-08de43975ab3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003AE8.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PPFC908D89D1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/923ea1f897d278289f6c051ff87123003dc4c436 Thanks. Shani --- >From 923ea1f897d278289f6c051ff87123003dc4c436 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 17 Oct 2025 12:06:36 +0100 Subject: [PATCH] app/pdump: remove hard-coded memory channels [ upstream commit 4a8d8db495f66b22ce0c12055b1c9f704f542152 ] The pdump main function modifies argc/argv before calling EAL init function. It needs to do so in order to add the proc-type=secondary flag, but also adds in "-n4" as parameter. This parameter is unnecessary and also causes duplicate parameter errors if the user also passes in -n flag on the commandline. Just remove this flag. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Signed-off-by: Bruce Richardson Acked-by: Anatoly Burakov --- app/pdump/main.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index 3592f8a865..4631ae2591 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -982,9 +982,8 @@ main(int argc, char **argv) int ret; int i; - char n_flag[] = "-n4"; char mp_flag[] = "--proc-type=secondary"; - char *argp[argc + 2]; + char *argp[argc + 1]; /* catch ctrl-c so we can cleanup on exit */ sigemptyset(&action.sa_mask); @@ -996,13 +995,12 @@ main(int argc, char **argv) sigaction(SIGHUP, &action, NULL); argp[0] = argv[0]; - argp[1] = n_flag; - argp[2] = mp_flag; + argp[1] = mp_flag; for (i = 1; i < argc; i++) - argp[i + 2] = argv[i]; + argp[i + 1] = argv[i]; - argc += 2; + argc += 1; diag = rte_eal_init(argc, argp); if (diag < 0) @@ -1012,7 +1010,7 @@ main(int argc, char **argv) rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n"); argc -= diag; - argv += (diag - 2); + argv += (diag - 1); /* parse app arguments */ if (argc > 1) { -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:39.524258006 +0200 +++ 0063-app-pdump-remove-hard-coded-memory-channels.patch 2025-12-25 11:16:36.026864000 +0200 @@ -1 +1 @@ -From 4a8d8db495f66b22ce0c12055b1c9f704f542152 Mon Sep 17 00:00:00 2001 +From 923ea1f897d278289f6c051ff87123003dc4c436 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4a8d8db495f66b22ce0c12055b1c9f704f542152 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index fa85859703..f3ac81cb80 100644 +index 3592f8a865..4631ae2591 100644