From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55130470E5 for ; Thu, 25 Dec 2025 10:24:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB6E540A6E; Thu, 25 Dec 2025 10:24:14 +0100 (CET) Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010025.outbound.protection.outlook.com [52.101.61.25]) by mails.dpdk.org (Postfix) with ESMTP id 31E3340684 for ; Thu, 25 Dec 2025 10:24:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EQzdPwc2IGf0jPM368A8dRmoIV2KTRBLtZLjK+j3HOShpyeCOswE1B0cgSVbBKerGO7NRKX9443t2X39lsCvqhN9+ukjHqkLR13n3t19hsNL1/OyoNIX9m/dr57lu7OUvYGnBTYI7Mhri7BUK0oMUOHIzWz2QuvTdb7cROP/xTR2mtxCsicceGUp4lzZyT/fobqWe4zLOaG4SvfX9Mp/dkfefqguKzqRecbrmPgktzdRetcaRAD1yfKEIrVTr0YcD6nklxyUWZDbiWGPio4dh7qXtbvJabbsKPWY4QYO1JHVpphtnCAb3/JmL5oCATX2nFvCylEX1t5PwvchLT6JYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xz9/1x1Gp5+ByoX6T5CmdPR8J34GdKDkVsapYmqfEXs=; b=EPPagpKWYFdvLUmm9NckDJacuogsKoyTetDqN1NCSD38B+MaFFBFcZBYn7j/GmH6LiOwDPOH7URQPUj6QkkRNr5/MSAcf0iQtDgAlEh/2JkVutOSgiBcG4etNI978/mrebg2DojJcNlEoiksKNQdYHhWB4MXdvE4ZFOQ23VGiTiozzhxKbSz9A6nbPbgtAu0TkfOyjKWbWDG5749/lAPVSfVRr/1cl+yCF66CMCkP88z5lrJSklkbCZLoFboRDCM7JgmGAqgygIT8lz1pHTDhdYONG6kcWrST7FH0w1raGw7RGgwOehTIFvti5B8hoe4xiplCWzBs92mpu8iHV7Kjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xz9/1x1Gp5+ByoX6T5CmdPR8J34GdKDkVsapYmqfEXs=; b=ma/VdV+onTJTVP5yAW6DCHKAJfPARrIu7hV4ZbDlvgtZzBP3Y6qCLsLpY50EBgsxzae1aZ5ckCpE15o/n8RLxFN23G4oh5mF/6OLagr51Ed+N5QWNUCXJ+wEZ7zTCo0GVrnZfXQpbJjl62a4fCrxctGAElfmDkUE0AX4FQnnvjfHXml0icRgueRpLIFGTRVhChmMxM8DD4mFnMTx0oD4Q06ouHI+mtIrZDOih00cUkhV8uuTbg86pmwlc3ESg/lafrio5rBy4tYuBWkukr63lXihQWj1Xyps+/kTwZhui1LVmFiVjPjSoIlnOLOYNM4XhfYBhZcToFHcGAIV1z+E9A== Received: from SN6PR05CA0029.namprd05.prod.outlook.com (2603:10b6:805:de::42) by MW4PR12MB5642.namprd12.prod.outlook.com (2603:10b6:303:187::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.11; Thu, 25 Dec 2025 09:24:10 +0000 Received: from SA2PEPF00003AE9.namprd02.prod.outlook.com (2603:10b6:805:de:cafe::4d) by SN6PR05CA0029.outlook.office365.com (2603:10b6:805:de::42) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9478.2 via Frontend Transport; Thu, 25 Dec 2025 09:24:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SA2PEPF00003AE9.mail.protection.outlook.com (10.167.248.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:24:09 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:24:00 -0800 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:23:59 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:23:58 -0800 From: Shani Peretz To: Stephen Hemminger CC: Bruce Richardson , Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk>, dpdk stable Subject: patch 'pdump: handle primary process exit' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:18:25 +0200 Message-ID: <20251225091938.345892-64-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003AE9:EE_|MW4PR12MB5642:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e9a1477-c9d1-426c-532e-08de43975bea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?WdZrrkbITVH23TiEzCRIlCyPOJ9315D10rpF7dpIcGS37dn2DQ1+wUKOxBcR?= =?us-ascii?Q?0wkoxMJfOQ1mk49WNv+qeY43ms4NctPbJU61lR2vEtsUW4CHj/VCKz4nS9s4?= =?us-ascii?Q?I/ylOUZOwf/HCu8uz7Kit5LFvYxoor6q2Fd3n+Ld5MYXLoGOgBKNtMSn0Abl?= =?us-ascii?Q?j+Mwp008EMd8h3RUQlGDjdwICxZNv/5m/32agVMQXjEvshInXs4BF+iIsI2T?= =?us-ascii?Q?knZl56dY8qCv8ypOO+v3wPiQ8hNT1hH1G03F0tO0Si4UGDctKOHzEc3zbix/?= =?us-ascii?Q?NnSGZrF9YPbRWhOZJ5C+1i61F6TB2hJLtnTbPKPTmV8IveMi+JUrTZupLWeR?= =?us-ascii?Q?C1NyggnXTrjZFUsRMk7CoQO3cCWvUAA8UQ5GS8rSzbYm2Byv/cJsvMxJo7iL?= =?us-ascii?Q?rUeOlb4DmGLZ6W/IY0gD5uqOeEbeDWrsnhbYYyJEpgMNpEQYwQInNo35iMB2?= =?us-ascii?Q?17Yzps31SqfLYnTUY1jIbG3RSGQZWNMEocZgSFEDU/sXHNZHqvwfdbQe3ZF9?= =?us-ascii?Q?aPzNRB+E+QzHI9ur+pq1rfVJWLFsta6kNSb2Z6gmaXCBssisotqdQLPDBFsC?= =?us-ascii?Q?OWAqfi0EtNej7nhXSnq3OI7OPLHmCBG5UoUUE1RIgaeFh7/olUTijWGbh10D?= =?us-ascii?Q?9NoNlJWr1i/sBaE/B/xEmgvx6f1EAnODeEGUO27HrMRKfQ4si0JYr1pviZe8?= =?us-ascii?Q?A2HH2oc3WC5UEwSeDePhAgtYkC87V1gcDXQ2n3L/15dZRXOUM0bJkNwQGvxJ?= =?us-ascii?Q?i7UMcGeVMmXn+4UuKis4TKGiQJ+zJUGgodzyj9WrykLV9vqwbQt73fxSvp8+?= =?us-ascii?Q?PiEm9UodBwu975yyyXbZqwbkGgJgbjY8vThoL3GHN8e6jMWCNP0qhn1fBWYK?= =?us-ascii?Q?/TTutdmowUurdUiNzHbjBY5l6EA0RSoQd9IidSeJi3JO/OpK7GSQo1MiMEBl?= =?us-ascii?Q?+y3BBweW+yAnujAUHBXyaiTkSi1kEXdOcPPBZpk7sam+gtVCTBJYIQYM2Sjc?= =?us-ascii?Q?CtUUNHwD3yD9yr9ZGmTKdoyJpMr4jwCbRD9eIbIVv5OmsArqNVnzj0rY9n3p?= =?us-ascii?Q?cHKJ2T5RowLyKHxs2D78poA1ToFvc3SXMbjBDPAYaiySEbanqwG9j6uitcNE?= =?us-ascii?Q?gcpsi28ixsLpzZhpq+LjFVp9CsfFbhk3wfwtozOzVY6wIxsO8Ha/rTUfbYLQ?= =?us-ascii?Q?gs1sX1C24Yepfr2zVRJWvN5DkcxCJ16eELik1HoAxC8DjlBjWYP8jB4o3Kck?= =?us-ascii?Q?Vg6bm3K/AOLNsr05I0RhY4m82HBFyXnjKGAVPs1TPRFiIH8cez2wFPVnxd5m?= =?us-ascii?Q?NKGX02JCIm7cyJlquG1WgjLk5lI4oXxYdn9pWpmy0ZCJkqVAwEs3lNDbjk2r?= =?us-ascii?Q?UoUq1AhbQ4dR4o9RZuNYRAVnFJPIXh+DZyzADa15SL25MFmlAjc9SdTyQGHc?= =?us-ascii?Q?H6bNa/1NzO8tGvFCljS2n29JzdWvc2LIGDMnd5mCnTp8u4vq7WaystR0/Sjj?= =?us-ascii?Q?QTOI6i0YzDe78DhOPNUawcwUL9kQcwNQc1vMmPAGUnsFQqiPaFboCY6kZ1uk?= =?us-ascii?Q?5vb0aUyFFF98Jxt3r2U=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:24:09.3199 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e9a1477-c9d1-426c-532e-08de43975bea X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003AE9.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5642 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/ef77284ccbd0708a6d4df693f669850dcc62236c Thanks. Shani --- >From ef77284ccbd0708a6d4df693f669850dcc62236c Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 4 Nov 2025 10:07:05 -0800 Subject: [PATCH] pdump: handle primary process exit [ upstream commit cefd5edce236e69496693ea0ecbf3e61434ff348 ] If primary process exits, then it is not possible (or needed) to cleanup resources. Instead just exit after closing the capture file. Bugzilla ID: 1760 Fixes: a99a311ba101 ("app/pdump: exit with primary process") Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Khadem Ullah <14pwcse1224@uetpeshawar.edu.pk> --- app/dumpcap/main.c | 4 ++++ app/pdump/main.c | 12 +++++++----- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 5eaab6350f..92b363cfff 100644 --- a/app/dumpcap/main.c +++ b/app/dumpcap/main.c @@ -1028,6 +1028,10 @@ int main(int argc, char **argv) else pcap_dump_close(out.dumper); + /* If primary has exited, do not try and communicate with it */ + if (!rte_eal_primary_proc_alive(NULL)) + return 0; + cleanup_pdump_resources(); rte_ring_free(r); diff --git a/app/pdump/main.c b/app/pdump/main.c index 4631ae2591..a2624f2fbf 100644 --- a/app/pdump/main.c +++ b/app/pdump/main.c @@ -1026,13 +1026,15 @@ main(int argc, char **argv) dump_packets(); disable_primary_monitor(); - cleanup_pdump_resources(); + /* dump debug stats */ print_pdump_stats(); - ret = rte_eal_cleanup(); - if (ret) - printf("Error from rte_eal_cleanup(), %d\n", ret); + /* If primary has exited, do not try and communicate with it */ + if (!rte_eal_primary_proc_alive(NULL)) + return 0; - return 0; + cleanup_pdump_resources(); + + return rte_eal_cleanup() ? EXIT_FAILURE : 0; } -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:39.571487912 +0200 +++ 0064-pdump-handle-primary-process-exit.patch 2025-12-25 11:16:36.035845000 +0200 @@ -1 +1 @@ -From cefd5edce236e69496693ea0ecbf3e61434ff348 Mon Sep 17 00:00:00 2001 +From ef77284ccbd0708a6d4df693f669850dcc62236c Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit cefd5edce236e69496693ea0ecbf3e61434ff348 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index e5ba36350b..3621c0ebe3 100644 +index 5eaab6350f..92b363cfff 100644 @@ -27 +28 @@ -@@ -1059,6 +1059,10 @@ int main(int argc, char **argv) +@@ -1028,6 +1028,10 @@ int main(int argc, char **argv) @@ -39 +40 @@ -index 89347d70dc..7cbf1b8c34 100644 +index 4631ae2591..a2624f2fbf 100644 @@ -42 +43 @@ -@@ -1027,13 +1027,15 @@ main(int argc, char **argv) +@@ -1026,13 +1026,15 @@ main(int argc, char **argv)