From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B97B0470E5 for ; Thu, 25 Dec 2025 10:25:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEA4A402B7; Thu, 25 Dec 2025 10:25:43 +0100 (CET) Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012022.outbound.protection.outlook.com [40.107.200.22]) by mails.dpdk.org (Postfix) with ESMTP id 6C09F402B7 for ; Thu, 25 Dec 2025 10:25:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=THihmAgiSxkTXXJ6w4RC8El+SNpRLyqO4EWMXndY65F97Z4aAK4WAqb8Xo4AUps/XqJKZH5xHOTapcldgxl1Z33xgD0qciyrM+xAe9893rzdq1K+DU3feA1nyX4pUXKA4+ZV10ToGujTNtQw2Zv7tk4w8l57H1o/X/0HQBgePLRcEJVrJ39BZTkqVe/PbqbiS6JReaIetlvC/nZWRexe2n9zUPmlt6GJ+r/bHwYqKZKy0DBHoQ52CcXpEfA5QxuTgp+egIoPywdyJmWMt82lbG0AropqALwJbJhrSn/EXz2lRqtjGW7eNb1iiOuepbHgc/q8AUqQrEHevyQ2dfKlXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UcsA6proEkNkx7U3FxDohwqzi0JeKXsXAJfiJLLOP38=; b=hdgS11Td33+9ToO2a405RIjzPZQI79Ht8cHELdICm/5KpB2bb7DZi8EzrCDqkExIw/ZG0k/5Ygv1JMPdMP6/ppbN2Nb2dHpldJ7zfAKWehP5tPzY3LlnVZeftGXy3/mYNc0wEwj8sATsZ3+jsfN7XZU4WoHVLOvAl4G+fwAdUdF9wUjFQWDsItDLnLEok6do8iDxu2IoHpAog1UhjVfBN0IFHII307ZS625FZRj3B9pRpG7gqapJvoMr+ev9u23SPmZKe9ptReFQcnNsM2FImPZjhKXQgkMtgVdN6QqX4GTFCN3AtaLhQqPDMC58u4Trsfn3IFxhUdORgEe39BdcYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UcsA6proEkNkx7U3FxDohwqzi0JeKXsXAJfiJLLOP38=; b=KA1sX9NzeCHRF0KzoWS70vlCRuuQP8dHeXjlbZ7o/xTHG82Lyfk1aW2LVOgAErLpY3udIPOzvaXfzmSnOQnT/gTwSs+w9CbuBVdvXvGLTMc6EY+i57FYqZ2/bMHQi6txS9Y1YVFrWWT92ke0Gobquh2sVq7ziX0BWhFQjqljuYZEq03m5bDsBfz0Ltk+78JJx9CV15Qn+A8ABEcERWIwRtMIcwlcd2nfc9eJu3s2ZLWU1GqdCjI6X0XWJcfUKkSqz+BfwZcqbERt2Qd3eCCstEeveBuGdRHjxAPSChXKNx39b6murWjKnhaGjVSCargMuos7irj0iZc5RLL81cngIg== Received: from CY5PR15CA0213.namprd15.prod.outlook.com (2603:10b6:930:88::7) by MN2PR12MB4469.namprd12.prod.outlook.com (2603:10b6:208:268::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.11; Thu, 25 Dec 2025 09:25:38 +0000 Received: from CY4PEPF0000FCC4.namprd03.prod.outlook.com (2603:10b6:930:88:cafe::23) by CY5PR15CA0213.outlook.office365.com (2603:10b6:930:88::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.11 via Frontend Transport; Thu, 25 Dec 2025 09:25:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000FCC4.mail.protection.outlook.com (10.167.242.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:25:38 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:25:24 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:25:24 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:25:23 -0800 From: Shani Peretz To: David Marchand CC: Hemant Agrawal , dpdk stable Subject: patch 'net/dpaa2: remove ethdev pointer from bus device' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:18:46 +0200 Message-ID: <20251225091938.345892-85-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC4:EE_|MN2PR12MB4469:EE_ X-MS-Office365-Filtering-Correlation-Id: dbf65c18-c831-4e89-dfbe-08de439790e4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?SaL7GJBj5EuatXp+M4p5uvfTq8WD404zZgxstPkPlHn+G28JEgO+5/lXP2x5?= =?us-ascii?Q?jzYWsDiKWrkdlCOBrEjEKwMGfVxtTt6844rMvU9JmgjTZhdPVsdRS8vuZIaK?= =?us-ascii?Q?7p6HdHbbrnrqlsVI+bCaIImL7XhvgtykdQjmZhc72DGHlXxndqUyRSF31ETS?= =?us-ascii?Q?QGN26Jg7GFEsAlZdrWvMHh4pLEavXctZ6KJ0aoQWn/wZ/47o6u1367QvXuBz?= =?us-ascii?Q?Ee/rgh7tFf4QdfzSJcZleF7u8BrpcD6q1rdPKORXmkWDl6cDLCvzWynu6qBu?= =?us-ascii?Q?2hAuzMJkLyasRCM+8F7RplwikMKph5OfZdQ+vir1qk/S59EQ/05d/d2of+Cc?= =?us-ascii?Q?z3IwPKkJIZO1/7CgcCan+/kkcBmyFykIbeAzZZwm5jpK7VtyCyOJ8TdWEoFl?= =?us-ascii?Q?YvNnmMKhG2TP5/rMYXozb1Zwr3ihq2pE2d16R7vIVX6cA5FEmGcbX1hGxYbI?= =?us-ascii?Q?lI1GYeJlZ+5uKtME6FCSaYusWXP4tmsl7EVIqdzoKBwOqEDQdzyksw7k3dR/?= =?us-ascii?Q?JwdW6N1zB530UgHze10jVjbNYgNdWkG13QImg7hwfAKW7CQCqYAjwJt+LtFt?= =?us-ascii?Q?k1LuIWIi+EwoXzdTBv0rzsOMXTgcJiGi11yFZsJGWBdfUjuRc5T8U9nW5i13?= =?us-ascii?Q?P2N7VtzM6Jf0CrlnoARmam2rjvtiIEK82kneB1bW1ussoQI2dRWo+euhV+9c?= =?us-ascii?Q?vm8HILcBUJVQeMHyd+F7C0ndpwmcaDJIcN/m3N1ahnFthcSxRj3bVFCZPmWo?= =?us-ascii?Q?SvCdDrRQcurNTYpkvSmFYMEPW0DPJNWYyCdJzWMsVc4RRp+wdtzL/0BU7CG9?= =?us-ascii?Q?y1sb+Ov4ai0k4NVMeBotww3sMVxwWcmpcXALH1qAYrU6SoISCqwMJKhbb30y?= =?us-ascii?Q?u4/nBlMaw+tp/TqIre9mnooOrYYYxSkYEAdylpJzP5iD3HHxFzmzFlbKzc5J?= =?us-ascii?Q?loIUEjTPVbN/lhXRaXiUPwfuO3wD9sNOhdq9sRiTPHQfSwqKqsO9V/Lrg+1q?= =?us-ascii?Q?kNybHUpi+vM7PRsdH5PENCR/rNTjdzIF9Es+MsKSWAbPd0ZSuNaxnXSfiTLB?= =?us-ascii?Q?l3qgeofyVV3qANgN69ZDLlqF4zwr0oUgAQ+iT1Ez9tgywa5I28eofv6TZdok?= =?us-ascii?Q?8qcHoEfdanrdPy3U+JcYjmHdTA3ysVlSCh/NrA6cA6VxydHiGhI9Lv30lIxj?= =?us-ascii?Q?CXTAGfIOyruWkGE7kmN/6nnAFI3eWGRaAhhu2jAaBn554rFjsVnx0HQSRmHh?= =?us-ascii?Q?nwhDEhuAX0gmeuiytLVGNvJ3XJjLJ3/otud8uKfmytWj6Tywui0baHaCX66/?= =?us-ascii?Q?4mNQ88LA35ZuFAlN7kprSKLQ9FcVFvCPVaQ3Qr5pT0wWZKbkCnnEPB5S5FM5?= =?us-ascii?Q?5G62tVAier6xQhO6SAmeLA9iMGPMWZu2OArfUFHkByq42D2JNU8Z9Oe/7Rnd?= =?us-ascii?Q?BO4afys6hohp8peu2dY+okHJ4jN328CsQwPRmzKdxjIoBA+wbA8qe48KfYBm?= =?us-ascii?Q?e6F3795GUIOaj0w3nWWM4peOp1Q45k/I3Z1x63qcJNZ17yrR/eBKJTiiczvp?= =?us-ascii?Q?LS0QwVX4/eM4Y70lQyugJamd6RsiOsxvPfP5M/OL?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:25:38.2002 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dbf65c18-c831-4e89-dfbe-08de439790e4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4469 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/a0ac9a8e85fc3f4da3e6e36827634e709a335d5b Thanks. Shani --- >From a0ac9a8e85fc3f4da3e6e36827634e709a335d5b Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 12 Nov 2025 10:10:46 +0100 Subject: [PATCH] net/dpaa2: remove ethdev pointer from bus device [ upstream commit 603caa201d7fea95d9272aec5667cb4a23d0886d ] This code was never used. This leaves no user of the ethdev field in the fslmc device object. Fixes: f023d059769f ("net/dpaa2: support recycle loopback port") Signed-off-by: David Marchand Tested-by: Hemant Agrawal --- drivers/bus/fslmc/bus_fslmc_driver.h | 1 - drivers/net/dpaa2/dpaa2_ethdev.c | 1 - drivers/net/dpaa2/dpaa2_ethdev.h | 6 ---- drivers/net/dpaa2/dpaa2_recycle.c | 50 ---------------------------- 4 files changed, 58 deletions(-) diff --git a/drivers/bus/fslmc/bus_fslmc_driver.h b/drivers/bus/fslmc/bus_fslmc_driver.h index 7ac5fe6ff1..32b4238f98 100644 --- a/drivers/bus/fslmc/bus_fslmc_driver.h +++ b/drivers/bus/fslmc/bus_fslmc_driver.h @@ -115,7 +115,6 @@ struct rte_dpaa2_device { TAILQ_ENTRY(rte_dpaa2_device) next; /**< Next probed DPAA2 device. */ struct rte_device device; /**< Inherit core device */ union { - struct rte_eth_dev *eth_dev; /**< ethernet device */ struct rte_cryptodev *cryptodev; /**< Crypto Device */ struct rte_dma_dev *dmadev; /**< DMA Device */ struct rte_rawdev *rawdev; /**< Raw Device */ diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index a195c6f2ad..fe8689ae05 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -2909,7 +2909,6 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv, eth_dev->device = &dpaa2_dev->device; - dpaa2_dev->eth_dev = eth_dev; eth_dev->data->rx_mbuf_alloc_failed = 0; if (dpaa2_drv->drv_flags & RTE_DPAA2_DRV_INTR_LSC) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.h b/drivers/net/dpaa2/dpaa2_ethdev.h index 9feb631d5f..befd2dabe6 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.h +++ b/drivers/net/dpaa2/dpaa2_ethdev.h @@ -306,10 +306,4 @@ int dpaa2_timesync_read_tx_timestamp(struct rte_eth_dev *dev, int dpaa2_dev_recycle_config(struct rte_eth_dev *eth_dev); int dpaa2_dev_recycle_deconfig(struct rte_eth_dev *eth_dev); -int dpaa2_dev_recycle_qp_setup(struct rte_dpaa2_device *dpaa2_dev, - uint16_t qidx, uint64_t cntx, - eth_rx_burst_t tx_lpbk, eth_tx_burst_t rx_lpbk, - struct dpaa2_queue **txq, - struct dpaa2_queue **rxq); - #endif /* _DPAA2_ETHDEV_H */ diff --git a/drivers/net/dpaa2/dpaa2_recycle.c b/drivers/net/dpaa2/dpaa2_recycle.c index 4fde9b95a0..f68653e0f4 100644 --- a/drivers/net/dpaa2/dpaa2_recycle.c +++ b/drivers/net/dpaa2/dpaa2_recycle.c @@ -730,53 +730,3 @@ dpaa2_dev_recycle_deconfig(struct rte_eth_dev *eth_dev) return ret; } - -int -dpaa2_dev_recycle_qp_setup(struct rte_dpaa2_device *dpaa2_dev, - uint16_t qidx, uint64_t cntx, - eth_rx_burst_t tx_lpbk, eth_tx_burst_t rx_lpbk, - struct dpaa2_queue **txq, - struct dpaa2_queue **rxq) -{ - struct rte_eth_dev *dev; - struct rte_eth_dev_data *data; - struct dpaa2_queue *txq_tmp; - struct dpaa2_queue *rxq_tmp; - struct dpaa2_dev_priv *priv; - - dev = dpaa2_dev->eth_dev; - data = dev->data; - priv = data->dev_private; - - if (!(priv->flags & DPAA2_TX_LOOPBACK_MODE) && - (tx_lpbk || rx_lpbk)) { - DPAA2_PMD_ERR("%s is NOT recycle device!", data->name); - - return -EINVAL; - } - - if (qidx >= data->nb_rx_queues || qidx >= data->nb_tx_queues) - return -EINVAL; - - rte_spinlock_lock(&priv->lpbk_qp_lock); - - if (tx_lpbk) - dev->tx_pkt_burst = tx_lpbk; - - if (rx_lpbk) - dev->rx_pkt_burst = rx_lpbk; - - txq_tmp = data->tx_queues[qidx]; - txq_tmp->lpbk_cntx = cntx; - rxq_tmp = data->rx_queues[qidx]; - rxq_tmp->lpbk_cntx = cntx; - - if (txq) - *txq = txq_tmp; - if (rxq) - *rxq = rxq_tmp; - - rte_spinlock_unlock(&priv->lpbk_qp_lock); - - return 0; -} -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:40.549238775 +0200 +++ 0085-net-dpaa2-remove-ethdev-pointer-from-bus-device.patch 2025-12-25 11:16:36.201835000 +0200 @@ -1 +1 @@ -From 603caa201d7fea95d9272aec5667cb4a23d0886d Mon Sep 17 00:00:00 2001 +From a0ac9a8e85fc3f4da3e6e36827634e709a335d5b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 603caa201d7fea95d9272aec5667cb4a23d0886d ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index efa88754a7..094f885f59 100644 +index 7ac5fe6ff1..32b4238f98 100644 @@ -26 +27 @@ -@@ -98,7 +98,6 @@ struct rte_dpaa2_device { +@@ -115,7 +115,6 @@ struct rte_dpaa2_device { @@ -30,0 +32,2 @@ + struct rte_cryptodev *cryptodev; /**< Crypto Device */ + struct rte_dma_dev *dmadev; /**< DMA Device */ @@ -32,2 +34,0 @@ - }; - enum rte_dpaa2_dev_type dev_type; /**< Device Type */ @@ -35 +36 @@ -index 1dd4a1e32b..fdf3e0f220 100644 +index a195c6f2ad..fe8689ae05 100644 @@ -38 +39 @@ -@@ -3351,7 +3351,6 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv, +@@ -2909,7 +2909,6 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv, @@ -47 +48 @@ -index 87a94bc15b..86b3022ddb 100644 +index 9feb631d5f..befd2dabe6 100644 @@ -50,3 +51 @@ -@@ -531,12 +531,6 @@ int dpaa2_dev_recycle_config(struct rte_eth_dev *eth_dev); - int dpaa2_dev_recycle_deconfig(struct rte_eth_dev *eth_dev); - int dpaa2_soft_parser_loaded(void); +@@ -306,10 +306,4 @@ int dpaa2_timesync_read_tx_timestamp(struct rte_eth_dev *dev, @@ -53,0 +53,2 @@ + int dpaa2_dev_recycle_config(struct rte_eth_dev *eth_dev); + int dpaa2_dev_recycle_deconfig(struct rte_eth_dev *eth_dev); @@ -60,3 +61 @@ - void - dpaa2_dev_mac_setup_stats(struct rte_eth_dev *dev); - + #endif /* _DPAA2_ETHDEV_H */ @@ -64 +63 @@ -index 94a7e2a020..d1e21dd4d1 100644 +index 4fde9b95a0..f68653e0f4 100644