From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CC51470E5 for ; Thu, 25 Dec 2025 10:26:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65C2E40262; Thu, 25 Dec 2025 10:26:03 +0100 (CET) Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011056.outbound.protection.outlook.com [40.93.194.56]) by mails.dpdk.org (Postfix) with ESMTP id F06FB40430 for ; Thu, 25 Dec 2025 10:26:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sWVYqc1GGwqL4/R5j5GvGFTV6NEI/v9bXxwe7qvDHSRRUT52jIklH5jvc143Lwt829iqxO6YAq4SvaV5MhD3EcWQYrF3UQjsdIlX58gZrtim2KnYH2f2Vv68reH23LxsqVP191d3gIV+3nWbwKV4BZHQVgk+Oe/un+cBtgAn3eRZVfXlBlX94xdpkx5mkzqcqQyJz3/B3Xpc4EGYrWzgu+HKnnY/TBVA/OmAXbji+FDRVM9tIB/UoAQjOimTCD4Ie0iOrX5iJ3y2p/wPK1vRzji41FE+oWJLhvvkFoSrpKhak3+5xYT8Zi0W/QuGznj96cRcfaqEg/f8I7UGnrRJ1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tExiL+hyrmHaIQi7GQbn/0Gk28AJWvoeLUO9176V6J0=; b=LBHvPHs9mI/RWhVJzBoqoXh7mLeVP8FrdJ69jVe3UMwLmUC7xL4+UEgPUglbDlr8DZk9vVMIzfCm28oobiqZqilvkBuDWEXFKouv2PzYlSz3R1omu959fbeWBmxMqbFS0IIH3aYOOKvav5T97DpCWSt4xMGylaFKpybVXUwgs32c+QxI/KMHBV5tjo5xtWEPJYXqAO2/JdTBrFfJO0JJM+wtIou54P765Wc9oTGV+a6x2/7z3yKUhUWDeWwS1ig6CmYpvO87TeMRNMBnUd0bm+MC69iENEadG/JFc3xphzR4TWHykWng4rJl52w37zhysKX06zsCecJ9pzjU3dD1tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tExiL+hyrmHaIQi7GQbn/0Gk28AJWvoeLUO9176V6J0=; b=WRhCZexh/t539O1JEnn3LT4DZrtI+WmT7Qwih0nc8zfUN0QnW9FI/HGHWS69/Bcfy2qwX60eP7Dv59S/93DgsdB9tGcCL6wOr516D9lRQtHPu9hvZJA9akoLjZLlS9oCqhdfdo/D2pN62m2gEtuCy1Mj1xsCKaMDABKVz9dbrOWu3h3KISLjN/d1KNQIVRp7gJLAqCzg5L2Uo5KfgGbFRKuZEdV6LOHWP/Edo4bKIpZvQREbLZdYPQ0yxhxKdqmMHj6AptsN14qDjBCPCGDMRvLkCnNQcAe1oAQTfYGd9BSTxt9snFiPKvWakr1s53J7UrQN3xPW+aovW/tfJPBpjQ== Received: from DM6PR10CA0030.namprd10.prod.outlook.com (2603:10b6:5:60::43) by CH2PR12MB4055.namprd12.prod.outlook.com (2603:10b6:610:78::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.11; Thu, 25 Dec 2025 09:25:54 +0000 Received: from CY4PEPF0000FCC2.namprd03.prod.outlook.com (2603:10b6:5:60:cafe::af) by DM6PR10CA0030.outlook.office365.com (2603:10b6:5:60::43) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.11 via Frontend Transport; Thu, 25 Dec 2025 09:25:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000FCC2.mail.protection.outlook.com (10.167.242.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:25:53 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:25:45 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:25:45 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:25:44 -0800 From: Shani Peretz To: Roi Dayan CC: Gregory Etelson , Suanming Mou , dpdk stable Subject: patch 'common/mlx5: release unused mempool entries' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:18:51 +0200 Message-ID: <20251225091938.345892-90-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC2:EE_|CH2PR12MB4055:EE_ X-MS-Office365-Filtering-Correlation-Id: 1513dcd7-577c-4857-217f-08de43979a29 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|376014|36860700013|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ZufKP4G5jOEVmFtTBL4hjo6C8zpXQ7KpLDTnRhjmrDLqOZN0m4GybJJ60CSj?= =?us-ascii?Q?38eBT1RSdGmE7LAqJC5BUeglUaTvdKkrqwgoRJwVIUOW6nml6u7bL2oMtoAT?= =?us-ascii?Q?Fq6fhRBEBymGosUpO8ahKZLGYbLs/v91wvR3hQdBsRMghnT74dQFkoZLy/Xg?= =?us-ascii?Q?9hKpiXenpExVo+Z+Q2sQVb/+aeLw+vpD8eMUJ5JbFC3xsgFN2qqWJCp4qFSt?= =?us-ascii?Q?/b9CgVQJpPdAkHKHYQrHwAItAaYT7MdQFefP+wu0NTnUL3rcfJWqnXC2xmAi?= =?us-ascii?Q?1kBaR04gw9lyIQAf4IBro4tMoC6VZ5WkFVFt2muKQSSRBJh0aSJXKdMZw+v7?= =?us-ascii?Q?S54ZxWldEi7k4du7RuqnsNIxKHU0lXL5rD8KoRMl3rutgVpEsz6D5OPupnl8?= =?us-ascii?Q?LkSJQjeiDQjeQCAs5V+aFqox/D285VzuPAeqH8JmLV29aHMsKnsalDSdq+Hq?= =?us-ascii?Q?tyAkhgzVIHuFnYZp675q/4AjE3OtlREPx+lSn8fZ9opHk+SU7f+4wuXn03mN?= =?us-ascii?Q?1o1kagZliZ/6m5IIeIu18zP0OsJ/3k/xx/V9eI8puFzHsHgqYKD308o3XsL6?= =?us-ascii?Q?JqgrjXsvhkdFpijBcL1tnsMpfYG81A40an/eV7sqa2+eM/BiXzWqk2dqwRwh?= =?us-ascii?Q?3czIObtIyTpTP0rmuKhP+AbQK8/yf4befYxFr53oEJrLZhAPonXmwQyyKrle?= =?us-ascii?Q?NI8Lo1j1rZaTHzIhTjnNFCEO6SZPB5sLjatX9YkrRypnQzEl2TlBNXAWqlCc?= =?us-ascii?Q?xfIwboWLadMlJvkbv0AncJRwrWVspx0I4vKobAaWF3Nse9k/rFZ3Mr9SsScD?= =?us-ascii?Q?dXzU+G8cvhUN/tKzf877Ew91HQWKwuI/fWNwqBQeIeKMoa6vxEdy5M1SWlUy?= =?us-ascii?Q?/BY1H+BuK3PyVnEJAhmpapzjofswbdYppGX1qQM3t7JXSXgig8MDNDt7tHqE?= =?us-ascii?Q?VBNp5yQ/3GqhSsJw9+jVqNWnx/LCjVn0kLHRG9HljrhxFkr1VzJr79rOwDW9?= =?us-ascii?Q?kX1PQBdPtd/VXSYB4/S+WH4BjnxPTlup+z1ALyPtM4ewWCKJgdOnkBWhNUjS?= =?us-ascii?Q?Gu5NDbK9sEMHm/HOySpRMmaaxcasIAewcI9itvQPrlg7xeJMDg6Rftn86G9+?= =?us-ascii?Q?zZ+m1nVrd4ugB83wenkgqrUHAHw+bsaKdQL76TuGjk5C3W+2z44v0O0bS5C2?= =?us-ascii?Q?Zm4bei/7wodj6bUtWgJTJPstthWUHVNSEfBuVGsae/mw1aFA9L4M3VYzTWWl?= =?us-ascii?Q?aroRW0k/xdwfgkxsx31JYT0B5mYRjd9VpLn/YbqxFwA7vhfTROtZ1aHoCXMb?= =?us-ascii?Q?UcZ0jwgWdu+LCwePe3e2DRKPvFQi2PnHk8IoSGxrUs4YNPfTsqmtTv8aKmLA?= =?us-ascii?Q?laX+WURAOM+Hd/KClZuTO/dSVSRIkBrR/zzvqGcm4ce+HEpvdYihQKm6AioP?= =?us-ascii?Q?TVaqvHWT8nAtXHcAac1SQBJVk8GlEFicHBc1uFg+MbM2YU3FGCCA9EN+vuYp?= =?us-ascii?Q?k6r6oapNzCB4LMDKjJAyW2U3L1CtIN6nZ3iTAGBuq+UBXAJrxKiQwYorYfPY?= =?us-ascii?Q?rdjWMryDoBB/nxIRejlTOlVChDojDol15oOhlFAE?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:25:53.7508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1513dcd7-577c-4857-217f-08de43979a29 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4055 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/f250ca6da812d784e73c6d0e1f7afcfee61b28da Thanks. Shani --- >From f250ca6da812d784e73c6d0e1f7afcfee61b28da Mon Sep 17 00:00:00 2001 From: Roi Dayan Date: Wed, 12 Nov 2025 09:41:31 +0200 Subject: [PATCH] common/mlx5: release unused mempool entries [ upstream commit aef94343d3d0b7e11071747f0d2fd66546d7b724 ] When creating a new mempool but assigning a shared entries from a different mempool need to release the newly unused allocated entries. Fix it. Fixes: 8947eebc999e ("common/mlx5: fix shared memory region ranges allocation") Signed-off-by: Roi Dayan Signed-off-by: Gregory Etelson Acked-by: Suanming Mou --- drivers/common/mlx5/mlx5_common_mr.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/common/mlx5/mlx5_common_mr.c b/drivers/common/mlx5/mlx5_common_mr.c index 85ec10d2ee..192c9b47f6 100644 --- a/drivers/common/mlx5/mlx5_common_mr.c +++ b/drivers/common/mlx5/mlx5_common_mr.c @@ -1710,18 +1710,24 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache, * hugepage can be shared across mempools that also fit in it. */ if (share_hugepage) { + struct mlx5_mempool_mr *gc_mrs = NULL; + rte_rwlock_write_lock(&share_cache->rwlock); LIST_FOREACH(mpr, &share_cache->mempool_reg_list, next) { if (mpr->mrs[0].pmd_mr.addr == (void *)ranges[0].start) break; } if (mpr != NULL) { + /* Releasing MRs here can create a dead-lock on share_cache->rwlock */ + gc_mrs = new_mpr->mrs; new_mpr->mrs = mpr->mrs; mlx5_mempool_reg_attach(new_mpr); LIST_INSERT_HEAD(&share_cache->mempool_reg_list, new_mpr, next); } rte_rwlock_write_unlock(&share_cache->rwlock); + if (gc_mrs != NULL) + mlx5_free(gc_mrs); if (mpr != NULL) { DRV_LOG(DEBUG, "Shared MR %#x in PD %p for mempool %s with mempool %s", mpr->mrs[0].pmd_mr.lkey, pd, mp->name, -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:40.785486100 +0200 +++ 0090-common-mlx5-release-unused-mempool-entries.patch 2025-12-25 11:16:36.243804000 +0200 @@ -1 +1 @@ -From aef94343d3d0b7e11071747f0d2fd66546d7b724 Mon Sep 17 00:00:00 2001 +From f250ca6da812d784e73c6d0e1f7afcfee61b28da Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit aef94343d3d0b7e11071747f0d2fd66546d7b724 ] + @@ -20 +22 @@ -index c41ffff2d5..8ed988dec9 100644 +index 85ec10d2ee..192c9b47f6 100644 @@ -23 +25 @@ -@@ -1717,18 +1717,24 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache, +@@ -1710,18 +1710,24 @@ mlx5_mr_mempool_register_primary(struct mlx5_mr_share_cache *share_cache,