From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1653470E5 for ; Thu, 25 Dec 2025 10:26:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA38940262; Thu, 25 Dec 2025 10:26:18 +0100 (CET) Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011033.outbound.protection.outlook.com [40.93.194.33]) by mails.dpdk.org (Postfix) with ESMTP id 3980A40648 for ; Thu, 25 Dec 2025 10:26:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CaLDsRiysxa8OyO1g1ydWBjTQn6vs5Mz8ZLyeNCDFZkybhNClHVSEoyW5eXOEpz3SdEgXVhvfmlCO+u5vrdwNGp9v09bTIEQKUYqu6iiSEp18rUPC0T1qaVrFu1qSeDGc/97kiBRi3dKvoi9irvBjkxU1xWPUolAXxl6PwOFWYbhQIME6zjqg4PY5DDxIQj9DjypD4NcZ8yGxCKWcJUzGd+TJkT6Avyt9YUxYFPTZc75+qHP6kbBHArKOrvo/QbYx4g5qKI8YlWRxVyTngDd7XOGz8WOaejdOt+tKioRfiYiR2Q+TRPN/ndjeAO4VpXVIXfVr0s6IUTbjKIn57jkAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qgg6T3rYf/YpF8b0nu51qhZw5rH5nIXprqzNKw6nnm4=; b=WlvmAWtZPHxI+A5j40+KZo+5NNlAk+Yh0YH9FMxVAGI4ruuQOBE5U/So2cmANkMfhoZDyj0vQqUyU2YM6Znx83+mV0XsJeO33uZaxIdZOITf8CWsDyhHIU/k6Byz7SI4pnhhB1B671rMOW27MwAPZmdxs6oqrqsLylhTX6sJZPst+95UTqGO6rL4JOBdaghnh350iID09RrkJGfsMHy0Kkk1CM5fkLdsUyBCqVKqL/6pMwVSlH5pSeZNrQt77XRs125elrEwhFgmB3kEy5CAtQySgjEzKQPstSodE3Rv8sq7Djl+C6sO+X4bulaVuVTaTPbIKKqnvxFXzBnHECTRYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qgg6T3rYf/YpF8b0nu51qhZw5rH5nIXprqzNKw6nnm4=; b=fKCGT2mNMSboPRoEgGPHK46CMTeUKQCh+RwVGzjFbdWrPYV8wiLrd0/az39oG9LFCZwwQXikR3w6V0iK/6l7ObHPmXTcChE6i9oXxKRuQ3SFq7FKhhGk1huV8ZBeND+NYQTvbKcBnUUPxiclyL/PeHQ+0NI2AhH8c/UF2O+woso9FD6YBLFX8k+fxGX7G9KOYEtLFpV5ZeQsRBqimHldgaLCVPQSLLqRyC2pM8EwsABtzsxMo7+pxnD9HW7Xod/BpQ3FZN8+jq7OSwmreAjrrVBAxYi1J37z3EGnyD+L1yRPDAOD/6v4MINkFn351mKLqnqED9SGq8sK335Ptrd30g== Received: from SN7PR04CA0091.namprd04.prod.outlook.com (2603:10b6:806:122::6) by SA3PR12MB9130.namprd12.prod.outlook.com (2603:10b6:806:37f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.11; Thu, 25 Dec 2025 09:26:11 +0000 Received: from SN1PEPF0002636B.namprd02.prod.outlook.com (2603:10b6:806:122:cafe::4c) by SN7PR04CA0091.outlook.office365.com (2603:10b6:806:122::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.11 via Frontend Transport; Thu, 25 Dec 2025 09:26:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF0002636B.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:26:11 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:26:03 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:26:02 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:26:01 -0800 From: Shani Peretz To: Stephen Hemminger CC: Raslan Darawsheh , dpdk stable Subject: patch 'net/mlx5: fix uninitialized variable' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:18:54 +0200 Message-ID: <20251225091938.345892-93-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636B:EE_|SA3PR12MB9130:EE_ X-MS-Office365-Filtering-Correlation-Id: cd4cc3d8-dc1e-4721-1732-08de4397a4c9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6xCiFe66oTCWi67HOcc3J3fw9L2VzCDuSXobGMPfVdf8chRs3VJCoFnj0B8Z?= =?us-ascii?Q?HCdMF7Rhnny2yWFYvoWIZ8EkbtFvchmYKtcQltINd+NFHa3/THWL+eOp0ErL?= =?us-ascii?Q?ulbJDM00xW7F3Fbi/3p3Z3w7/i4q8le7XghaURJR7Qm33PT4n8/ZjWLAhXNH?= =?us-ascii?Q?8oVM5LtYiM2pQRGVnH7Jhn75lCHftuJE+DRD8ZGUYoo6DuVBGcITzWbplYqT?= =?us-ascii?Q?V6Bf1KRZ0oDY/T+2REq3v6p6+CCiZDcYnqTXT+wUR7QMlyuRlzPEIVhc+wVN?= =?us-ascii?Q?aIpiPX26NFnnkVXnVsXWxf0/cbviHzk3yILJwzwcD1dcqxo21Iq3uI5AeM+e?= =?us-ascii?Q?JbI5v64HNOvxFEo+1U/7h1T0VLgNm6POQPXnWvP9x8GZcpKADpfBlnlrQ26p?= =?us-ascii?Q?Hb1rdLqWanIpFkhL4S3eVmP0kew0owXEz0U1rTvXFQNcn3rCu2MtrqwkaDAp?= =?us-ascii?Q?RLMXxBfmM4A6w3muwdMXpBuJYfVvIzlvMWjHrdcfK3zU3V8+GpnM+UJntvrp?= =?us-ascii?Q?R24tWuOgbRcqPxv6itKX/csCFJo9ivOn3cNdcVx8+O31xgMdvodFSpQwQ4DJ?= =?us-ascii?Q?3AqVOh4wboNmo19XiSWAtXuPwmRvGTItgrma7pgFmJ3bB1gtFG9uQwB1I8/f?= =?us-ascii?Q?UCM53/El6eENl0nsl71E9DWY2Izryhps1joCZc58ZUMcPMqbNo/XriVA6SD5?= =?us-ascii?Q?0fAVmHK91jb8GKa3vix5viKQ5KV87ojqNTk/EMeOt1jgMsYEQQBMnJKX5aFd?= =?us-ascii?Q?yTXev9yBa+3tPpA2ZQGD63o2Ys5+c7cFRLMX2Z1qAtsFQJKlIsYwriR7jDxb?= =?us-ascii?Q?o9F5A3XBmtjfOB9JUWTEjQO3zlFO3/Ohfp00PL39BmQ28yC5XzHTC89e9SMW?= =?us-ascii?Q?cCk0Wi2Rh09gffpGF18gLO8hSTd/9VxBnfj0PnXGbeB9S3+sFL21Hjq2ihVC?= =?us-ascii?Q?16/V+zbSwwN+5oroPbke7VVIvqffAinxzXiZaIbfCYEZAmlqDngSj22TJWsU?= =?us-ascii?Q?BnRj1mtB/Hu5QhdFQ6nd9KsK9uB/uyuzZjNVYXwgiSwnDwoXPs8zue+8qLXP?= =?us-ascii?Q?4pmBXdqzxfVYn3xNFtylQBdppP/x59PIlaRSLXA1GxB4swQfSabwXRx2DOzk?= =?us-ascii?Q?MRSeKR5aiU0ZaRCoHfDduRrxM9zAVlBYU5G9lvXSSYqew4SgobGPU2tRDGvg?= =?us-ascii?Q?OlAhgmRmlF6T8fxFDyhjf0NYd6HKHLseR8A3eBDCZ2F2JT4AOoNGchqwd0FW?= =?us-ascii?Q?I5/XbNqdf1T/fOg3KwLWVtA2dEOzrWQEVKmB2lLJzev8zobS23607Dpw51ao?= =?us-ascii?Q?8OUV+AqOLIShDLhrb1XLEZWx83CCYIBU6BJPX1++rE97NX7L97fWQhkUlnr1?= =?us-ascii?Q?4pk0pCPz563sn8U5hrUXzJAOxH/jgbGA6Svz+3n72IxwwNKf1ULeib+hfOwz?= =?us-ascii?Q?kPXmaFBiC2sV7hSDHNyA97doDUGzjinnO4wFBM4iBo+ApNF9uNVc9pxoNhsy?= =?us-ascii?Q?vJmprckKJY/W+gLyYQ1v7jVOPX5nKruxwTsFhMpA+xC86K/wslay5qpNBTTi?= =?us-ascii?Q?yXBjBr4mcHRmVzi7alaslEWIAOZz5khC9w35t9Gx?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:26:11.5747 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd4cc3d8-dc1e-4721-1732-08de4397a4c9 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636B.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9130 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/3ed57372077169c1bfe959ffc4200f8a01f42106 Thanks. Shani --- >From 3ed57372077169c1bfe959ffc4200f8a01f42106 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 14 Nov 2025 09:49:12 -0800 Subject: [PATCH] net/mlx5: fix uninitialized variable [ upstream commit 7429374afba9827a43cf2efabce14e27ccc4bdef ] Gcc-16 detects use of uninitialized variable. If the retry loop exits the code would do memcmp against uninitialized stack value. Resolve by initializing to zero. Bugzilla ID: 1823 Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions") Fixes: cfee94752b8f ("net/mlx5: fix link status to use wait to complete") Signed-off-by: Stephen Hemminger Acked-by: Raslan Darawsheh --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c index ea89ce8e05..a9a12c87dc 100644 --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c @@ -647,7 +647,7 @@ int mlx5_link_update(struct rte_eth_dev *dev, int wait_to_complete) { int ret; - struct rte_eth_link dev_link; + struct rte_eth_link dev_link = { 0 }; time_t start_time = time(NULL); int retry = MLX5_GET_LINK_STATUS_RETRY_COUNT; @@ -2010,4 +2010,3 @@ int mlx5_txpp_map_hca_bar(struct rte_eth_dev *dev) rte_mem_unmap(base, MLX5_ST_SZ_BYTES(initial_seg)); return 0; } - -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:40.926024185 +0200 +++ 0093-net-mlx5-fix-uninitialized-variable.patch 2025-12-25 11:16:36.269797000 +0200 @@ -1 +1 @@ -From 7429374afba9827a43cf2efabce14e27ccc4bdef Mon Sep 17 00:00:00 2001 +From 3ed57372077169c1bfe959ffc4200f8a01f42106 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7429374afba9827a43cf2efabce14e27ccc4bdef ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 4d8fbed188..50997c187c 100644 +index ea89ce8e05..a9a12c87dc 100644 @@ -25 +26 @@ -@@ -512,7 +512,7 @@ int +@@ -647,7 +647,7 @@ int @@ -34 +35 @@ -@@ -2073,4 +2073,3 @@ int mlx5_txpp_map_hca_bar(struct rte_eth_dev *dev) +@@ -2010,4 +2010,3 @@ int mlx5_txpp_map_hca_bar(struct rte_eth_dev *dev)