From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BCB2470E5 for ; Thu, 25 Dec 2025 10:26:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75B6140609; Thu, 25 Dec 2025 10:26:38 +0100 (CET) Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012052.outbound.protection.outlook.com [52.101.48.52]) by mails.dpdk.org (Postfix) with ESMTP id 60F7940609 for ; Thu, 25 Dec 2025 10:26:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s1+HLCRZYsY5+3aFEbxNOXH9NyH0uEEDfuNHpV5FXOfQsn3B0KT+hld6WnR+JyOkw8soEjTwrQ16SQT5R1jIf1ejx5l+3pMQrWYkKmXMKokN9ivGZqt8bA0cTMrWPeokdy/No9StGFE7QCOY3bL5E9pb+jSC2eaXmsM/YL9+bNCVuGVeM0MApjXzJ+LQ75v/sow0FNyzYwX3BUoEMgKdNDyiHKSnY29L/ndLPhH/THGXBGliYA93O3H/zsJdRTh9yzSQxSOJC56/n4KZQPqQYIzrFDZ9A6HnYf+qD2umNwpXZ/+W/jIQLBH923Niqcs809Qb0ZjwHWN8+klUahTloA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fApzXpYG2kveI23JopvJWYxMcPqNN9gn4UifZwEZVvg=; b=FpcXaq1tV8v2wBTxzAYUcci2IjqEHSS04umjtlLXFAhX9nV0aQSKJiB266fZ7lZF8BwXs4sL997aakivEsN390lHbzXmqpoY5+IGqkOlqoTcjF0ZimuhwER9y2op5AIMSz+2HAhaK0Z0VGkui03AmWD4viTMACRZYJnX1klUm8UNZGp3utHpNAdmHJdO2BEuc4w66j/0Ms2TAY6e67BzZiqqfDBKka08TuY1snUOSCfgDSovRA1YkKgCfnA0TmIufQG764LO/qsxXL0UxnOvKEE66K9g55r3S8qS8ohSd8q8GLj1SmQaq0bTljlYHoxKipN7Zp4Xox2xvIp5Obk8cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fApzXpYG2kveI23JopvJWYxMcPqNN9gn4UifZwEZVvg=; b=RjzdbXCszFXu5GEapIOwIL2fYilYv3YwwouqFICgPqq0LzoHTUS9nlaOjCqZJv7l7OaMPBaTxto6+Ph3hjochmuHrkiUmCstNIx+Mhnb+GkIgfeadNJKiO9dIELOmVSH+V4N4b4Dl3lhcbi0ehkt5CQikNP8xT/xp7avx96XKQmfRdK/+1MjiLa5OlZWshI56og1VWoHitt5SLDclbGZcp2w/2upkcLtNE53ZJVvS5ol3GUR9fAvhJ7rK8T0GvfcxvY3h1AbHntDXGlZi6kJP8nm3GRBra4dg9BVp4JgMjOZdHy8NNrqzck3PngcBmW30t3H6JGDj+sAnxgpbb9IUA== Received: from SA9PR13CA0027.namprd13.prod.outlook.com (2603:10b6:806:21::32) by SJ2PR12MB8979.namprd12.prod.outlook.com (2603:10b6:a03:548::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.11; Thu, 25 Dec 2025 09:26:33 +0000 Received: from SN1PEPF00026368.namprd02.prod.outlook.com (2603:10b6:806:21:cafe::2f) by SA9PR13CA0027.outlook.office365.com (2603:10b6:806:21::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.11 via Frontend Transport; Thu, 25 Dec 2025 09:26:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF00026368.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:26:32 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:26:22 -0800 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:26:21 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:26:20 -0800 From: Shani Peretz To: Stephen Hemminger CC: Bruce Richardson , dpdk stable Subject: patch 'examples/server_node_efd: fix format overflow' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:18:58 +0200 Message-ID: <20251225091938.345892-97-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00026368:EE_|SJ2PR12MB8979:EE_ X-MS-Office365-Filtering-Correlation-Id: ef28cf7f-af24-4b85-45d0-08de4397b144 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VXYrN1ZaZS9MMTc4bTRnVFlkODU1UmQveXpoNHNTejZLKzlpK1BleUdHZ0Rs?= =?utf-8?B?UXd3dzBvbVh3Q0RYNlR6UEZPZDMvaU5TeEVQK0FrTVRNNHdHalR0NnNRQ3Fv?= =?utf-8?B?TVRMRGVyZUJYa2FyVHpmM25IeGx2NWhXTmNSNXBnK1JyQlVCK1ZMR005MGNv?= =?utf-8?B?RmJORUFpWmVEdVp6WGZSZkd0L2xqOS9lUS9hcHNkaEMrVkRDakVjc3V1eFRM?= =?utf-8?B?TUtXZnZ5dEFIMktlUnQzM1Z3ZU5VajRDQ2c2MWJhQ3plMHdUM0lreU9odGVw?= =?utf-8?B?WjhvcWsvZm91Q0RWaFRCano1WVZaTUoxL2k5VStjVlhMTzFKMmY0SDNJQzFy?= =?utf-8?B?bm5BeGdPR1hXSDhsSUZqcUhRSDR2azJqL01vS2hjUEtPQUx1RUU4Qi8vcGxz?= =?utf-8?B?eHg4SEZxQkpjN0ZLYUlheXRnSkNLUkdDODNKVFpNckJHREFyUnVGeGhSVjEv?= =?utf-8?B?M2RLL0VMYUlQWm45ejhyc2pGVHJhRjdJcUtyalFPNGhPaTNBM0RTTnU5QThP?= =?utf-8?B?Y1hrRWFERE4yeGZlR3V3djNod3pwam1WNStRQlhaVVFsMUVuODV6a01Cc1Fw?= =?utf-8?B?UDVXeUJ3a1J5eE8yZXFBdEJmamk3bzluckEzVmlMVTN6RnBvV1NXR3ZCQStK?= =?utf-8?B?UEU3VTc2OUQ2dmJIcnpOWTRrR01MbHVnRGpUMklRaUh2TVNDKytYRWlDZHQz?= =?utf-8?B?L1FCRjZUb09oVnBVS2hHdDlpVCttRDZTSmk5YjY1M1hNT1ZxdTJMZUVkTFVK?= =?utf-8?B?ZXVyUVowRjdwRmh4ZXVPSlNmTEE0RUlFelptNnpIQ1k2bkFTNGlZZlRPOWkx?= =?utf-8?B?Ri9RdUV1YXZyMElkaytMTW1Id0JoeFlWMzB0WW5mTUE4ek4zQm1sQm02M0pj?= =?utf-8?B?WWQ4RmE0cUlkemVNb2o2eXovVi9xMDhBSlUvSE4zeXQxT3Jsd3Q4QzhsR2x1?= =?utf-8?B?NlB1dTQyWis5ZjRma2g3TW1FMG1DZWlLbHlrZkppZzZqdUloUnRqblUzNmF5?= =?utf-8?B?Q3RtckpoT2FiRG1nbWtVM1FPbG8ybERVSmM4WENuQytUZG1KeUxtM1c4ako2?= =?utf-8?B?TFNrSUJkQ0N4eXB6S1F6QlpaMW5JSUpjcDlXcVZTUTlTTWFqWTJRa3grcDky?= =?utf-8?B?dm8vREsxd0pRMmJFMVRKVDcyek1VMTAydUZ6UFhiOUx3QU1uRkMxSVdlYkRK?= =?utf-8?B?andxeWtjY1dIL1ZWL2s1T1Z3eEtuUzhKRWlPbXJUdXhQVDdmSkJ5L01NYndo?= =?utf-8?B?amgyMUZkY0p3S1NSa2gxZ1g0NlpEZnFRaXpLKy9OYk1WZFJXU2RFSFFvdXBT?= =?utf-8?B?ZnJFWFF0RmExRTN2Vm5mczVLbW5YQU14YU9KWWNGRzl0S1NoczUyUXYvRVc3?= =?utf-8?B?RFNVMWRsV21VazNWZlRXTytMUEUyMjd3TytpU3ROSEdReWRyaFpZbWNDZGhj?= =?utf-8?B?N2E4NDVTN1VsNnptR1hzWVVmTXpKWUo5M1ZKV0JNeHA1Mmk4WGdIMXVMald3?= =?utf-8?B?bWNsVlV5ODJtdGJCS3JBa1VNdTZMOStZYm03dzFlcHYwOVFGQW1Zb0ZBRHha?= =?utf-8?B?N2xzV0VoSmRXbnE3VGZhR2YxMlcrN0hPT2o1ZERvZHhMYXVKRSsrUGZzbkpp?= =?utf-8?B?VFNUV3dDUUk4MWpPS1ZhU294YTVTalVWQzB3TFR5N2VsUEVXRjJ4T3BqNHMr?= =?utf-8?B?eU56bVFNNThhdG43QnQwbys3Y0NQQ01KeGcvcjJHVktpa3R4bXR0dVVMUWlo?= =?utf-8?B?cnBNVWpwelRidTJ1d3Z3UnpFdS81RE9vbkMxbmIvTWlrYkg4SWJPWE9QdlRs?= =?utf-8?B?RUJMbXNDRVVuYmNqbjdCOTlHMlpGdFFwTUxhSitPR3FyRW9tbWhLb0MvdHhL?= =?utf-8?B?N0RDK1J0anFOYUkwaUhrQ0lKQWM0eS9ub0doREpYVXQxTlV0RXpJR0RhUmJL?= =?utf-8?B?VUNrK3BFbVhpeExJRmhYMDZiZ0tVTmpXUkRhL01odHpScTdmSU5ycGxQbTZB?= =?utf-8?B?bWg5Y2pFRzZET0lSd2xPUjJtNk1WdVB2RHpNTHRQRVAzd2FzdFEwZkZablVh?= =?utf-8?B?TXBGUkZBODVYM0dUSHNXZDM1ekE5UmlEL1M3cVhwWXdoQ3RRSUhkbkFoYWtq?= =?utf-8?Q?UKoQaWa0u1vHclbZfjJTmzWdE?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:26:32.4984 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef28cf7f-af24-4b85-45d0-08de4397b144 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00026368.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8979 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/106a5ad16c8033cd7ff47b78e1f8563d3246d43a Thanks. Shani --- >From 106a5ad16c8033cd7ff47b78e1f8563d3246d43a Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 20 Nov 2025 08:21:59 -0800 Subject: [PATCH] examples/server_node_efd: fix format overflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit c97d223fc64fc10cf8f6c6f0e7d506926e83462b ] If format-truncation is enabled, the compiler detects a string overflow since the snprintf() is putting ethernet address and new line in buffer only sized for the address. Since get_rx_queue_name() is used to create a ring name. The buffer should be sized to be a valid ring name. This fixes some format-overflow warnings and also corrects for future errors. In file included from ../examples/server_node_efd/efd_server/main.c:31: In function ‘get_printable_mac_addr’, inlined from ‘do_stats_display’ at ../examples/server_node_efd/efd_server/main.c:136:3: ../lib/net/rte_ether.h:248:36: warning: ‘snprintf’ output truncated before the last format character [-Wformat-truncation=] 248 | #define RTE_ETHER_ADDR_PRT_FMT "%02X:%02X:%02X:%02X:%02X:%02X" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../examples/server_node_efd/efd_server/main.c:86:33: note: in expansion of macro ‘RTE_ETHER_ADDR_PRT_FMT’ 86 | RTE_ETHER_ADDR_PRT_FMT "\n", | ^~~~~~~~~~~~~~~~~~~~~~ ../examples/server_node_efd/efd_server/main.c: In function ‘do_stats_display’: ../examples/server_node_efd/efd_server/main.c:86:59: note: format string is defined here 86 | RTE_ETHER_ADDR_PRT_FMT "\n", | Fixes: 39aad0e88c58 ("examples/flow_distributor: new example to demonstrate EFD") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- examples/server_node_efd/efd_server/main.c | 2 +- examples/server_node_efd/shared/common.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/server_node_efd/efd_server/main.c b/examples/server_node_efd/efd_server/main.c index fd72882e3a..f1bb6c09fc 100644 --- a/examples/server_node_efd/efd_server/main.c +++ b/examples/server_node_efd/efd_server/main.c @@ -68,7 +68,7 @@ static const char * get_printable_mac_addr(uint16_t port) { static const char err_address[] = "00:00:00:00:00:00"; - static char addresses[RTE_MAX_ETHPORTS][sizeof(err_address)]; + static char addresses[RTE_MAX_ETHPORTS][RTE_ETHER_ADDR_FMT_SIZE + 1]; struct rte_ether_addr mac; int ret; diff --git a/examples/server_node_efd/shared/common.h b/examples/server_node_efd/shared/common.h index 130fd4f4e5..cd6b803ea1 100644 --- a/examples/server_node_efd/shared/common.h +++ b/examples/server_node_efd/shared/common.h @@ -58,8 +58,9 @@ get_rx_queue_name(unsigned int id) /* * Buffer for return value. Size calculated by %u being replaced * by maximum 3 digits (plus an extra byte for safety) + * Used as ring name, so upper limit is ring name size. */ - static char buffer[sizeof(MP_NODE_RXQ_NAME) + 2]; + static char buffer[RTE_RING_NAMESIZE]; snprintf(buffer, sizeof(buffer), MP_NODE_RXQ_NAME, id); return buffer; -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:41.419438732 +0200 +++ 0097-examples-server_node_efd-fix-format-overflow.patch 2025-12-25 11:16:36.327791000 +0200 @@ -1 +1 @@ -From c97d223fc64fc10cf8f6c6f0e7d506926e83462b Mon Sep 17 00:00:00 2001 +From 106a5ad16c8033cd7ff47b78e1f8563d3246d43a Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit c97d223fc64fc10cf8f6c6f0e7d506926e83462b ] + @@ -33 +34,0 @@ -Cc: stable@dpdk.org @@ -43 +44 @@ -index 75ff0ea532..62c3f4a16d 100644 +index fd72882e3a..f1bb6c09fc 100644 @@ -56 +57 @@ -index e1ab7e62b7..6726e2031e 100644 +index 130fd4f4e5..cd6b803ea1 100644