From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3DD8470E5 for ; Thu, 25 Dec 2025 10:26:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ACD5C40262; Thu, 25 Dec 2025 10:26:44 +0100 (CET) Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013070.outbound.protection.outlook.com [40.93.196.70]) by mails.dpdk.org (Postfix) with ESMTP id 65AE740262 for ; Thu, 25 Dec 2025 10:26:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vhTJwBd42WjQXtZkW90ZDT0sl0gmRc4udo7E+HluhWjb2Kk4MR1enTno7Hgv+HHPsCrpaXgoSw9EOXGCAfK76Frtd1ZclhMDFHswwVjC1efZjgi8jASiOlP5gkNQbHDuCpfsThE/dUL3PC8TrFomrO6EbT/rb9FHx5ur6uIS0pR6+SDNj4p9GW6GvuLwLtqi4BKuNALy89KYKOk6qQiB+nMkJq8ggKJcOSiMroOT4cPOQ8thtmkpEfBLWMoQ+Giq7pHNfso5dSqIQ+ZG2Iw/vZ/SmsOecEEvJY+qapWqaFhY9FlV4mp1Ax0ov6n/lWlmapa8KmKdXA/Vi5/WHO5nuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J/n6jbXk9bEFLcZN6u0ZV9xRZtuvYaN9oE6kqq0bchk=; b=RkDULZe10xPWwL3AiygKt52F06vX4z009s+/3N0n/XIu/YVyLTdEAKxp6hpZnbHy5rKmu2yvqQHvkDfmM3AHXZZ9DE3q1Hm3gNB4zrb+jYnntV4lDvKB9TIaU3PW0lxfx/foRj1b19cIglYc+Ws0hY9KtTgWX9xaC+VOnMiZXFZGoErJYoC+qpOW2v1iZjF5wGTwYfjFaePPhQUo14YGx/MdYbSc8YI94MhzS5rC1v0Wf+QccYUHX05Zm8+oViu/QwasNNanSBz1JUxXm9BOx6to73iOok43IG2tfRitDA2l0gUh5OeTxRBVsIIcyXB2ttUuwSdx8Gs4Q2Uao5JpwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J/n6jbXk9bEFLcZN6u0ZV9xRZtuvYaN9oE6kqq0bchk=; b=oRxhzh9Skhjuq7fGkYZfIYLKLwYW1sBE0eLF0HXDxDd98VKZOnhdIBdd7y5HUxdPkbm1o5EIzVZ7D8F04dVVQLrx91f3N8+wjng8DijvfAslP0F4c4sTMB0eq/KNW4q09phQakzKkTLenF44pdAA96eTeFTZLPZVwGQ7ejUu1kOZ3+FTs16sYYHLVy2+9uDRdAosXFKefVzlLyEM6neiemP9wj8PGOm5OK8nXKiCnFQ1AcqFj4Pww5EOt5hNSnuHqX8u35yLaT9CuvRSvP7snWg0ET6IYrl00LrFWLF6me89GmG8TN6z26FXxfH1ozStmo/PeSr3VuOvcbVNIes4SQ== Received: from CY5PR15CA0219.namprd15.prod.outlook.com (2603:10b6:930:88::18) by PH8PR12MB7207.namprd12.prod.outlook.com (2603:10b6:510:225::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.11; Thu, 25 Dec 2025 09:26:38 +0000 Received: from CY4PEPF0000FCC4.namprd03.prod.outlook.com (2603:10b6:930:88:cafe::86) by CY5PR15CA0219.outlook.office365.com (2603:10b6:930:88::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.12 via Frontend Transport; Thu, 25 Dec 2025 09:26:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000FCC4.mail.protection.outlook.com (10.167.242.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Thu, 25 Dec 2025 09:26:38 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:26:24 -0800 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 25 Dec 2025 01:26:23 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Thu, 25 Dec 2025 01:26:22 -0800 From: Shani Peretz To: Stephen Hemminger CC: Bruce Richardson , dpdk stable Subject: patch 'examples/vdpa: fix format overflow' has been queued to stable release 23.11.6 Date: Thu, 25 Dec 2025 11:18:59 +0200 Message-ID: <20251225091938.345892-98-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251225091938.345892-1-shperetz@nvidia.com> References: <20251221145746.763179-93-shperetz@nvidia.com> <20251225091938.345892-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC4:EE_|PH8PR12MB7207:EE_ X-MS-Office365-Filtering-Correlation-Id: fdcfe431-71f9-485e-3932-08de4397b4b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|1800799024|82310400026|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ei8yaVFvZlV3bWEvNjl2UnhDeDF3L2tJVEg5TzE2MkNjQnZRSEc0bWFWVUhy?= =?utf-8?B?ZHF1TDg2T0tUL1JCZVlxRTFFK3M0VzFIRE5jSzRYc0RUQ1NNZjY5bkI2L1dX?= =?utf-8?B?VXpmQVFCY2dGMDZ4eUNEaHRiTjF5SFRRR1RLUUZ1QndqdzUzaWE1blRoY1Rz?= =?utf-8?B?enFmR0lEV2R5V0s4d1V6RUQ4N2ptRmJsY0hxc2Qwdnh3TXVXZDBvbkNqN0x1?= =?utf-8?B?QTkzTE9QMGJWc3dLTUZic2x4eE40Zm81SkQ5N1JiY3lRVzRNbUJnekcrcGhw?= =?utf-8?B?WEtvY0c5SzR1ZVJRSEVDQXRWbkpIRzI3RE9JOEtrSXdlZC9lR29UWjBBTU52?= =?utf-8?B?MHFUZVdHWTZvVWE0Y1V5S3N3emVZazljN3ZtNGxNR1VKNFgyaE52c0g1NFlo?= =?utf-8?B?Y0tNVmVXQVhoZFZreGlNclAyYThta3RHQzg1N25lNUlBczh2ZGpPMEhFS0RN?= =?utf-8?B?bU9BSjJpTU5Sb0h1cTFGNnZzcndpNWcrVGRONW15bVN0b0tDT0hxaFRYMDFn?= =?utf-8?B?ZlVmNXBMTDBBWWNDM2NwVHNId2Jma0pJK1YzeUptT2pwYUFSdHB1MHNzb2FD?= =?utf-8?B?U1lJakNjei9JNFBwQ1VueW9vazNRNktqRDFERXhhN2ZncUhWSENsZ2VWd2Jq?= =?utf-8?B?d0QyR1BqRUwzaGYxT0hPRTk1SWhWMjBsWlRVVUYrTHV6RUxyaXhWaTBhR1ZL?= =?utf-8?B?TWtqZ1BZWW1DemZRWHdXZVpQMlB6TWRkWjZjODdDMWc2bm9vMzlPNFVEUXcw?= =?utf-8?B?eU9MY0EvelpaMmx5aEZLZ0hqM2xVNkNaQ1pBQ1N4YXBDQmxGTysxdmtEV0lD?= =?utf-8?B?c2ZueGFJTDJGVlhUWlNhZkR4WHRwakJrcGVsV0V6cnFySHpUc3dJWW5ZSURL?= =?utf-8?B?WUovdlZyK0RiaHNPYytXMHVTOWpiYlRvcCtLN2lpZ1R3OEEwejJBL01OTTBO?= =?utf-8?B?Y0hZNUo2U1BoMHBlREhFdndHcVFFbitCeVRoY1VUcit3bklQMHBBVko5ZVlL?= =?utf-8?B?YUFXbmM4MDRuU0hqSXJ4U1lSQVZDNnp3Y1Z3L3dKaStGZXY1MTNCUk1CVmpy?= =?utf-8?B?dEEyTWcrWlRtVnM2M2pqT1hBTk5uL2YxbmtvNG1pZU80QnJnLzJqNTRVcnU2?= =?utf-8?B?Z3FOMk5tWmxGNUJoNkZyNjlCNFhrNDVqdlNzaC9JNnNsczJkVkdwSTRZV2Ns?= =?utf-8?B?Ymh6SXhpTnlHYzhXaDl6ai8zTlJZZFNzMTNPaXdiSzN5UGtiSm1oTDJoNVh3?= =?utf-8?B?VUFqTEhCTTgwVTVCaG9jUzlhS1VPejNwT0g5c3hSZ2R6V3BHRFVUVldEcVRF?= =?utf-8?B?TzR0Y2lSZ2dWczFTdGtjTG53RGMzN3BsamF1Y0RjR0pwa25PTEU2aXBvcnR6?= =?utf-8?B?dDJjOGF5N3BMRWFvLzcxQVY5aWxVWXIyQWhUaFhXVHI0TXYxa3ZScHRHQi9B?= =?utf-8?B?ekcwOUhqUlNTK0VLS3F1aGpJNGhlcE4xU1B1bFg2c3dKdVh5blY2QUlBVmFt?= =?utf-8?B?UDJHd1l3VGlpMnUzWCtxdnlFU1k2V0hrb1hrcHVqZHViYjhSR0N1dU9vbFlB?= =?utf-8?B?TlEzTTZOTUhreHVrak90Z1lEODVwd2tFU0Jqdm1YVEl5MWJNOFovK21VajVr?= =?utf-8?B?MlJMZVhSNzRndU1udlRCbnpCSElMaXVpN2orL205V2NsMWZJSk8yNDJMY1Yv?= =?utf-8?B?VENpQWtmeXNFWERYTE1JcEVHZlRNZE1PaHhIVlQ2SzlOMlUzK0Rnbkl3VTBl?= =?utf-8?B?bm1kY2pXdTI2dUdITE9QUHhUd3A4VlFrUmZJdjlKdnZZY2tacTRncWdqam9v?= =?utf-8?B?QmpJdEhnSlZ0L1o3d2JrTTY3NkR2L1kvVzBaenR4amNWa0Vidml2UjBBcUFY?= =?utf-8?B?S1VtVlluakdFYlMyMTVsbzgzS0JpTWkyMk1SRDhuN3Qxai8wT2tLcnlYMTFh?= =?utf-8?B?SHdJamM5WU5aUXZIWTVNYVJEekY2WXZEYWEzR0dKMFNGb05ZSTNnOUZqRng0?= =?utf-8?B?VU5La09JdDlDNnFyU0d3WFRTUWozTkxJNHJNZ3RvVE04Q2ZqNm5rUWV0cjlE?= =?utf-8?B?anR3T3ZFaEFPY1lCdUU0ejRBN25QaEtFRzUvalluY3czRlZIMHB3c3IxYnRQ?= =?utf-8?Q?rApLtRhuBFv+rolPAU32C6c1X?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2025 09:26:38.3107 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fdcfe431-71f9-485e-3932-08de4397b4b7 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7207 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/30/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/f6fdcd78028ecdb9b34fcc6aa841258eca0f30de Thanks. Shani --- >From f6fdcd78028ecdb9b34fcc6aa841258eca0f30de Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 20 Nov 2025 08:22:00 -0800 Subject: [PATCH] examples/vdpa: fix format overflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 66052657fcb810c47cbbe52762c9ad0ad7828821 ] The ifname is limited to 128 characters, but it would allow up to 128 characters as prefix then could overflow creating ifname. Change to limit path prefix (iface) to 123 (128 - sizeof("1024")) to avoid possible format overflow ../examples/vdpa/main.c:501:76: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=] 501 | snprintf(vports[devcnt].ifname, MAX_PATH_LEN, "%s%d", | ^ ../examples/vdpa/main.c:501:25: note: ‘snprintf’ output between 2 and 139 bytes into a destination of size 128 501 | snprintf(vports[devcnt].ifname, MAX_PATH_LEN, "%s%d", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 502 | iface, devcnt); | Fixes: 38f8ab0bbc8d ("vhost: make vDPA framework bus agnostic") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- examples/vdpa/main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c index 289db26498..08aa933272 100644 --- a/examples/vdpa/main.c +++ b/examples/vdpa/main.c @@ -22,6 +22,7 @@ #define MAX_PATH_LEN 128 #define MAX_VDPA_SAMPLE_PORTS 1024 +#define MAX_VDPA_STR_LEN sizeof(RTE_STR(MAX_VDPA_SAMPLE_PORTS)) #define RTE_LOGTYPE_VDPA RTE_LOGTYPE_USER1 struct vdpa_port { @@ -36,7 +37,7 @@ struct vdpa_port { static struct vdpa_port vports[MAX_VDPA_SAMPLE_PORTS]; -static char iface[MAX_PATH_LEN]; +static char iface[MAX_PATH_LEN - MAX_VDPA_STR_LEN]; static int devcnt; static int interactive; static int client_mode; @@ -74,9 +75,8 @@ parse_args(int argc, char **argv) break; /* long options */ case 0: - if (strncmp(long_option[idx].name, "iface", - MAX_PATH_LEN) == 0) { - rte_strscpy(iface, optarg, MAX_PATH_LEN); + if (!strcmp(long_option[idx].name, "iface")) { + rte_strscpy(iface, optarg, sizeof(iface)); printf("iface %s\n", iface); } if (!strcmp(long_option[idx].name, "interactive")) { -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-25 11:16:41.465600318 +0200 +++ 0098-examples-vdpa-fix-format-overflow.patch 2025-12-25 11:16:36.331782000 +0200 @@ -1 +1 @@ -From 66052657fcb810c47cbbe52762c9ad0ad7828821 Mon Sep 17 00:00:00 2001 +From f6fdcd78028ecdb9b34fcc6aa841258eca0f30de Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 66052657fcb810c47cbbe52762c9ad0ad7828821 ] + @@ -25 +26,0 @@ -Cc: stable@dpdk.org