* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix out of bound access when no cpu is available [not found] ` <3463567.oezzxnnWpT@xps> @ 2019-01-17 17:17 ` David Marchand 2019-01-17 17:38 ` Thomas Monjalon 0 siblings, 1 reply; 2+ messages in thread From: David Marchand @ 2019-01-17 17:17 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev, Bruce Richardson, solal.pirelli, dpdk stable On Thu, Jan 17, 2019 at 5:34 PM Thomas Monjalon <thomas@monjalon.net> wrote: > 17/01/2019 14:12, David Marchand: > > In the unlikely case when the dpdk application is started with no cpu > > available in the [0, RTE_MAX_LCORE - 1] range, the master_lcore is > > automatically chosen as RTE_MAX_LCORE which triggers an out of bound > > access. > > > > Either you have a crash then, or the initialisation fails later when > > trying to pin the master thread on it. > > In my test, with RTE_MAX_LCORE == 2: > > > > $ taskset -c 2 ./master/app/testpmd --no-huge -m 512 --log-level *:debug > > [...] > > EAL: pthread_setaffinity_np failed > > PANIC in eal_thread_init_master(): > > cannot set affinity > > 7: [./master/app/testpmd() [0x47f629]] > > > > Bugzilla ID: 19 > > Signed-off-by: David Marchand <david.marchand@redhat.com> > > We should backport this fix. > When this bug has been introduced? > Indeed, at first, I thought the problem had always been there, but it should be starting 17.02: Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") + CC stable Do you want a v2 ? -- David Marchand ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix out of bound access when no cpu is available 2019-01-17 17:17 ` [dpdk-stable] [dpdk-dev] [PATCH] eal: fix out of bound access when no cpu is available David Marchand @ 2019-01-17 17:38 ` Thomas Monjalon 0 siblings, 0 replies; 2+ messages in thread From: Thomas Monjalon @ 2019-01-17 17:38 UTC (permalink / raw) To: David Marchand; +Cc: dev, Bruce Richardson, solal.pirelli, dpdk stable 17/01/2019 18:17, David Marchand: > On Thu, Jan 17, 2019 at 5:34 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > > 17/01/2019 14:12, David Marchand: > > > In the unlikely case when the dpdk application is started with no cpu > > > available in the [0, RTE_MAX_LCORE - 1] range, the master_lcore is > > > automatically chosen as RTE_MAX_LCORE which triggers an out of bound > > > access. > > > > > > Either you have a crash then, or the initialisation fails later when > > > trying to pin the master thread on it. > > > In my test, with RTE_MAX_LCORE == 2: > > > > > > $ taskset -c 2 ./master/app/testpmd --no-huge -m 512 --log-level *:debug > > > [...] > > > EAL: pthread_setaffinity_np failed > > > PANIC in eal_thread_init_master(): > > > cannot set affinity > > > 7: [./master/app/testpmd() [0x47f629]] > > > > > > Bugzilla ID: 19 > > > Signed-off-by: David Marchand <david.marchand@redhat.com> > > > > We should backport this fix. > > When this bug has been introduced? > > > > Indeed, at first, I thought the problem had always been there, but it > should be starting 17.02: > Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection") > > + CC stable > > Do you want a v2 ? Applied, thanks ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-17 17:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1547730777-20405-1-git-send-email-david.marchand@redhat.com>
[not found] ` <3463567.oezzxnnWpT@xps>
2019-01-17 17:17 ` [dpdk-stable] [dpdk-dev] [PATCH] eal: fix out of bound access when no cpu is available David Marchand
2019-01-17 17:38 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).