* [dpdk-stable] [PATCH] mk: fix output directory name when compiling with custom kernel header dir [not found] <20190718132912.28250-1-herakliusz.lipiec@intel.com> @ 2019-07-18 14:03 ` Herakliusz Lipiec 2019-07-18 22:25 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon 2019-07-19 11:11 ` [dpdk-stable] [PATCH v2] " Herakliusz Lipiec 0 siblings, 2 replies; 8+ messages in thread From: Herakliusz Lipiec @ 2019-07-18 14:03 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev, Herakliusz Lipiec, stable, bruce.richardson When building dpdk with differnt kernel headers by specifying RTE_KERNELDIR igb_uio is compiled to directory with a name of the version of kernel thats running on the system instead of the one that dpdk is actually compiled against. Fixed by replacing hardcoded value with value from RTE_KERNELDIR. Cc: stable@dpdk.org Cc: bruce.richardson@intel.com Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com> --- resending v1 with corrected cc address for stable and corrected alignment. --- mk/rte.sdkinstall.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index 5c4215cd7..a602dd6cc 100644 --- a/mk/rte.sdkinstall.mk +++ b/mk/rte.sdkinstall.mk @@ -27,7 +27,7 @@ ifeq ($(RTE_EXEC_ENV),linuxapp) RTE_EXEC_ENV=linux endif ifeq ($(RTE_EXEC_ENV),linux) -kerneldir ?= /lib/modules/$(shell uname -r)/extra/dpdk +kerneldir ?= $(subst /build,/extra/dpdk,$(RTE_KERNELDIR)) else kerneldir ?= /boot/modules endif -- 2.17.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir 2019-07-18 14:03 ` [dpdk-stable] [PATCH] mk: fix output directory name when compiling with custom kernel header dir Herakliusz Lipiec @ 2019-07-18 22:25 ` Thomas Monjalon 2019-07-19 11:09 ` Lipiec, Herakliusz 2019-07-19 11:11 ` [dpdk-stable] [PATCH v2] " Herakliusz Lipiec 1 sibling, 1 reply; 8+ messages in thread From: Thomas Monjalon @ 2019-07-18 22:25 UTC (permalink / raw) To: Herakliusz Lipiec; +Cc: dev, stable, bruce.richardson 18/07/2019 16:03, Herakliusz Lipiec: > When building dpdk with differnt kernel headers by specifying > RTE_KERNELDIR igb_uio is compiled to directory with a name of the > version of kernel thats running on the system instead of the one that > dpdk is actually compiled against. Fixed by replacing hardcoded value > with value from RTE_KERNELDIR. missing original commit reference: Fixes: 3967af352aeb ("mk: install kernel modules") > Cc: stable@dpdk.org > Cc: bruce.richardson@intel.com > Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com> > > --- > resending v1 with corrected cc address for stable and corrected > alignment. It should be marked v2, and the alignment is still not correct. > -kerneldir ?= /lib/modules/$(shell uname -r)/extra/dpdk > +kerneldir ?= $(subst /build,/extra/dpdk,$(RTE_KERNELDIR)) I would suggest another syntax, easier to read: kerneldir ?= $(RTE_KERNELDIR:/build=/extra/dpdk) ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir 2019-07-18 22:25 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon @ 2019-07-19 11:09 ` Lipiec, Herakliusz 2019-07-19 11:36 ` Thomas Monjalon 0 siblings, 1 reply; 8+ messages in thread From: Lipiec, Herakliusz @ 2019-07-19 11:09 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev, stable, Richardson, Bruce > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, July 18, 2019 11:25 PM > 18/07/2019 16:03, Herakliusz Lipiec: > > When building dpdk with differnt kernel headers by specifying > > RTE_KERNELDIR igb_uio is compiled to directory with a name of the > > version of kernel thats running on the system instead of the one that > > dpdk is actually compiled against. Fixed by replacing hardcoded value > > with value from RTE_KERNELDIR. > > missing original commit reference: > Fixes: 3967af352aeb ("mk: install kernel modules") > > > Cc: stable@dpdk.org > > Cc: bruce.richardson@intel.com > > Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com> > > > > --- > > resending v1 with corrected cc address for stable and corrected > > alignment. > > It should be marked v2, > and the alignment is still not correct. Sorry I forgot to add the change to commit, sending as v2. > > > -kerneldir ?= /lib/modules/$(shell uname -r)/extra/dpdk > > +kerneldir ?= $(subst /build,/extra/dpdk,$(RTE_KERNELDIR)) > > I would suggest another syntax, easier to read: > > kerneldir ?= $(RTE_KERNELDIR:/build=/extra/dpdk) > I have tried that before and it didn't seem to solve the issue. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir 2019-07-19 11:09 ` Lipiec, Herakliusz @ 2019-07-19 11:36 ` Thomas Monjalon 2019-07-19 17:01 ` Lipiec, Herakliusz 0 siblings, 1 reply; 8+ messages in thread From: Thomas Monjalon @ 2019-07-19 11:36 UTC (permalink / raw) To: Lipiec, Herakliusz; +Cc: dev, stable, Richardson, Bruce 19/07/2019 13:09, Lipiec, Herakliusz: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 18/07/2019 16:03, Herakliusz Lipiec: > > > -kerneldir ?= /lib/modules/$(shell uname -r)/extra/dpdk > > > +kerneldir ?= $(subst /build,/extra/dpdk,$(RTE_KERNELDIR)) > > > > I would suggest another syntax, easier to read: > > > > kerneldir ?= $(RTE_KERNELDIR:/build=/extra/dpdk) > > > I have tried that before and it didn't seem to solve the issue. Why? What is the output of $(info $(kerneldir)) ? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir 2019-07-19 11:36 ` Thomas Monjalon @ 2019-07-19 17:01 ` Lipiec, Herakliusz 0 siblings, 0 replies; 8+ messages in thread From: Lipiec, Herakliusz @ 2019-07-19 17:01 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev, stable, Richardson, Bruce > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, July 19, 2019 12:37 PM > To: Lipiec, Herakliusz <herakliusz.lipiec@intel.com> > Cc: dev@dpdk.org; stable@dpdk.org; Richardson, Bruce > <bruce.richardson@intel.com> > Subject: Re: [dpdk-dev] [PATCH] mk: fix output directory name when > compiling with custom kernel header dir > > 19/07/2019 13:09, Lipiec, Herakliusz: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 18/07/2019 16:03, Herakliusz Lipiec: > > > > -kerneldir ?= /lib/modules/$(shell uname -r)/extra/dpdk > > > > +kerneldir ?= $(subst /build,/extra/dpdk,$(RTE_KERNELDIR)) > > > > > > I would suggest another syntax, easier to read: > > > > > > kerneldir ?= $(RTE_KERNELDIR:/build=/extra/dpdk) > > > > > I have tried that before and it didn't seem to solve the issue. > > Why? What is the output of $(info $(kerneldir)) ? > I have tested your line again, and it worked, I compared against the one I was using at the beginning And I found that I was missing slash. I will resend a v3. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v2] mk: fix output directory name when compiling with custom kernel header dir 2019-07-18 14:03 ` [dpdk-stable] [PATCH] mk: fix output directory name when compiling with custom kernel header dir Herakliusz Lipiec 2019-07-18 22:25 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon @ 2019-07-19 11:11 ` Herakliusz Lipiec 2019-07-19 17:05 ` [dpdk-stable] [PATCH v3] " Herakliusz Lipiec 1 sibling, 1 reply; 8+ messages in thread From: Herakliusz Lipiec @ 2019-07-19 11:11 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev, Herakliusz Lipiec, stable, bruce.richardson When building dpdk with differnt kernel headers by specifying RTE_KERNELDIR igb_uio is compiled to directory with a name of the version of kernel thats running on the system instead of the one that dpdk is actually compiled against. Fixed by replacing hardcoded value with value from RTE_KERNELDIR. Fixes: 3967af352aeb ("mk: install kernel modules") Cc: stable@dpdk.org Cc: bruce.richardson@intel.com Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com> --- resending v2 with corrected corrected alignment. --- mk/rte.sdkinstall.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index 5c4215cd7..018e64908 100644 --- a/mk/rte.sdkinstall.mk +++ b/mk/rte.sdkinstall.mk @@ -27,7 +27,7 @@ ifeq ($(RTE_EXEC_ENV),linuxapp) RTE_EXEC_ENV=linux endif ifeq ($(RTE_EXEC_ENV),linux) -kerneldir ?= /lib/modules/$(shell uname -r)/extra/dpdk +kerneldir ?= $(subst /build,/extra/dpdk,$(RTE_KERNELDIR)) else kerneldir ?= /boot/modules endif -- 2.17.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-stable] [PATCH v3] mk: fix output directory name when compiling with custom kernel header dir 2019-07-19 11:11 ` [dpdk-stable] [PATCH v2] " Herakliusz Lipiec @ 2019-07-19 17:05 ` Herakliusz Lipiec 2019-07-22 8:00 ` Thomas Monjalon 0 siblings, 1 reply; 8+ messages in thread From: Herakliusz Lipiec @ 2019-07-19 17:05 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev, Herakliusz Lipiec, stable, bruce.richardson When building dpdk with differnt kernel headers by specifying RTE_KERNELDIR igb_uio is compiled to directory with a name of the version of kernel thats running on the system instead of the one that dpdk is actually compiled against. Fixed by replacing hardcoded value with value from RTE_KERNELDIR. Fixes: 3967af352aeb ("mk: install kernel modules") Cc: stable@dpdk.org Cc: bruce.richardson@intel.com Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com> --- v2: with corrected corrected alignment. v3: change to more readable version. --- mk/rte.sdkinstall.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index 5c4215cd7..32bed5d95 100644 --- a/mk/rte.sdkinstall.mk +++ b/mk/rte.sdkinstall.mk @@ -27,7 +27,7 @@ ifeq ($(RTE_EXEC_ENV),linuxapp) RTE_EXEC_ENV=linux endif ifeq ($(RTE_EXEC_ENV),linux) -kerneldir ?= /lib/modules/$(shell uname -r)/extra/dpdk +kerneldir ?= $(RTE_KERNELDIR:/build=/extra/dpdk) else kerneldir ?= /boot/modules endif -- 2.17.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-stable] [PATCH v3] mk: fix output directory name when compiling with custom kernel header dir 2019-07-19 17:05 ` [dpdk-stable] [PATCH v3] " Herakliusz Lipiec @ 2019-07-22 8:00 ` Thomas Monjalon 0 siblings, 0 replies; 8+ messages in thread From: Thomas Monjalon @ 2019-07-22 8:00 UTC (permalink / raw) To: Herakliusz Lipiec; +Cc: stable, dev, bruce.richardson 19/07/2019 19:05, Herakliusz Lipiec: > When building dpdk with differnt kernel headers by specifying > RTE_KERNELDIR igb_uio is compiled to directory with a name of the > version of kernel thats running on the system instead of the one that > dpdk is actually compiled against. Fixed by replacing hardcoded value > with value from RTE_KERNELDIR. > > Fixes: 3967af352aeb ("mk: install kernel modules") > Cc: stable@dpdk.org > Cc: bruce.richardson@intel.com > Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com> Acked-by: Thomas Monjalon <thomas@monjalon.net> Shortened the title to: "mk: fix custom kernel directory name" Applied, thanks ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-07-22 8:01 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190718132912.28250-1-herakliusz.lipiec@intel.com>
2019-07-18 14:03 ` [dpdk-stable] [PATCH] mk: fix output directory name when compiling with custom kernel header dir Herakliusz Lipiec
2019-07-18 22:25 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-07-19 11:09 ` Lipiec, Herakliusz
2019-07-19 11:36 ` Thomas Monjalon
2019-07-19 17:01 ` Lipiec, Herakliusz
2019-07-19 11:11 ` [dpdk-stable] [PATCH v2] " Herakliusz Lipiec
2019-07-19 17:05 ` [dpdk-stable] [PATCH v3] " Herakliusz Lipiec
2019-07-22 8:00 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).