* [dpdk-stable] [PATCH] doc: fix incorrect create bonding command in testpmd
@ 2018-07-23 11:27 Shreyansh Jain
2018-07-23 20:49 ` Ferruh Yigit
2018-07-25 11:31 ` [dpdk-stable] [PATCH v2] " Shreyansh Jain
0 siblings, 2 replies; 5+ messages in thread
From: Shreyansh Jain @ 2018-07-23 11:27 UTC (permalink / raw)
To: dev
Cc: bernard.iremonger, jingjing.wu, wenzhuo.lu, Shreyansh Jain,
john.mcnamara, stable
Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide")
Cc: john.mcnamara@intel.com
Cc: stable@dpdk.org
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
Note: Though the git blame suggest e76d7a768c as the last modification
for fixes, this actually existed when testpmd doc was added.
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 1d6bdf9b3..16af95035 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -1993,7 +1993,7 @@ Create a new bonding device::
For example, to create a bonded device in mode 1 on socket 0::
- testpmd> create bonded 1 0
+ testpmd> create bonded device 1 0
created new bonded device (port X)
add bonding slave
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-stable] [PATCH] doc: fix incorrect create bonding command in testpmd
2018-07-23 11:27 [dpdk-stable] [PATCH] doc: fix incorrect create bonding command in testpmd Shreyansh Jain
@ 2018-07-23 20:49 ` Ferruh Yigit
2018-07-25 9:00 ` Iremonger, Bernard
2018-07-25 11:31 ` [dpdk-stable] [PATCH v2] " Shreyansh Jain
1 sibling, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2018-07-23 20:49 UTC (permalink / raw)
To: Shreyansh Jain, dev
Cc: bernard.iremonger, jingjing.wu, wenzhuo.lu, john.mcnamara, stable
On 7/23/2018 12:27 PM, Shreyansh Jain wrote:
> Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide")
> Cc: john.mcnamara@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
> Note: Though the git blame suggest e76d7a768c as the last modification
> for fixes, this actually existed when testpmd doc was added.
You are right, I think fixes should be initial commit:
Fixes: ac718398f477 ("doc: testpmd application user guide")
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-stable] [PATCH] doc: fix incorrect create bonding command in testpmd
2018-07-23 20:49 ` Ferruh Yigit
@ 2018-07-25 9:00 ` Iremonger, Bernard
0 siblings, 0 replies; 5+ messages in thread
From: Iremonger, Bernard @ 2018-07-25 9:00 UTC (permalink / raw)
To: Yigit, Ferruh, Shreyansh Jain, dev
Cc: Wu, Jingjing, Lu, Wenzhuo, Mcnamara, John, stable
Hi Shreyansh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, July 23, 2018 9:49 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>; dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Mcnamara, John <john.mcnamara@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] doc: fix incorrect create bonding
> command in testpmd
>
> On 7/23/2018 12:27 PM, Shreyansh Jain wrote:
> > Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide")
> > Cc: john.mcnamara@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> > ---
> > Note: Though the git blame suggest e76d7a768c as the last modification
> > for fixes, this actually existed when testpmd doc was added.
>
> You are right, I think fixes should be initial commit:
> Fixes: ac718398f477 ("doc: testpmd application user guide")
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Could you send a v2 with the correct Fixes line.
Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-stable] [PATCH v2] doc: fix incorrect create bonding command in testpmd
2018-07-23 11:27 [dpdk-stable] [PATCH] doc: fix incorrect create bonding command in testpmd Shreyansh Jain
2018-07-23 20:49 ` Ferruh Yigit
@ 2018-07-25 11:31 ` Shreyansh Jain
2018-07-26 20:36 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
1 sibling, 1 reply; 5+ messages in thread
From: Shreyansh Jain @ 2018-07-25 11:31 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, bernard.iremonger, jingjing.wu, wenzhuo.lu,
john.mcnamara, Shreyansh Jain, stable
Fixes: ac718398f477 ("doc: testpmd application user guide")
Cc: bernard.iremonger@intel.com
Cc: stable@dpdk.org
Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
v2:
Update the Fixes line to represent the first commit
rather than the formatting patch (e76d7a76).
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 1d6bdf9b3..16af95035 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -1993,7 +1993,7 @@ Create a new bonding device::
For example, to create a bonded device in mode 1 on socket 0::
- testpmd> create bonded 1 0
+ testpmd> create bonded device 1 0
created new bonded device (port X)
add bonding slave
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] doc: fix incorrect create bonding command in testpmd
2018-07-25 11:31 ` [dpdk-stable] [PATCH v2] " Shreyansh Jain
@ 2018-07-26 20:36 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2018-07-26 20:36 UTC (permalink / raw)
To: Shreyansh Jain
Cc: dev, ferruh.yigit, bernard.iremonger, jingjing.wu, wenzhuo.lu,
john.mcnamara, stable
25/07/2018 13:31, Shreyansh Jain:
> Fixes: ac718398f477 ("doc: testpmd application user guide")
> Cc: bernard.iremonger@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-26 20:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-23 11:27 [dpdk-stable] [PATCH] doc: fix incorrect create bonding command in testpmd Shreyansh Jain
2018-07-23 20:49 ` Ferruh Yigit
2018-07-25 9:00 ` Iremonger, Bernard
2018-07-25 11:31 ` [dpdk-stable] [PATCH v2] " Shreyansh Jain
2018-07-26 20:36 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).