patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, declan.doherty@intel.com
Cc: stable@dpdk.org, Matan Azrad <matan@mellanox.com>,
	dev@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix slave port detection
Date: Mon, 23 Apr 2018 00:58:05 +0200	[thread overview]
Message-ID: <2044227.RGsR745gvM@xps> (raw)
In-Reply-To: <1522235873-22042-1-git-send-email-matan@mellanox.com>

Wenzhuo, Declan,
Any comment or ack, please?

28/03/2018 13:17, Matan Azrad:
> Testpmd allows to create and control bonding devices by run time
> command lines using the bonding PMD API.
> 
> Some bonding device slaves operations(close, stop, etc) should not be
> used by the application and must be managed by the bonding PMD.
> 
> Thus, Testpmd manages slave flags to prevent the special operations
> calls and when a slave is added to bonding device by a run time command
> line, the flag is set.
> 
> There is one more way to define the slaves for a bonding device using
> EAL command line and Testpmd doesn't set the slave flag in this case
> what causes to the special operations to be called by Testpmd.
> 
> Add one more check to detect bonding slave device.
> 
> Fixes: 41b05095c4d1 ("app/testpmd: fix bonding start")
> Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in bonding")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
>  app/test-pmd/testpmd.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 4c0e258..73d9481 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2251,7 +2251,10 @@ uint8_t port_is_bonding_slave(portid_t slave_pid)
>  	struct rte_port *port;
>  
>  	port = &ports[slave_pid];
> -	return port->slave_flag;
> +	if ((rte_eth_devices[slave_pid].data->dev_flags &
> +	    RTE_ETH_DEV_BONDED_SLAVE) || (port->slave_flag == 1))
> +		return 1;
> +	return 0;
>  }
>  
>  const uint16_t vlan_tags[] = {
> 

  reply	other threads:[~2018-04-22 22:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 11:17 Matan Azrad
2018-04-22 22:58 ` Thomas Monjalon [this message]
2018-05-11 16:09   ` [dpdk-stable] [dpdk-dev] " Iremonger, Bernard
2018-05-14  2:00     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2044227.RGsR745gvM@xps \
    --to=thomas@monjalon.net \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=matan@mellanox.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).