* [PATCH 1/4] examples/fips_validation: fix external build [not found] <20230613081741.4083273-1-david.marchand@redhat.com> @ 2023-06-13 8:17 ` David Marchand 2023-06-13 15:05 ` [EXT] " Gowrishankar Muthukrishnan [not found] ` <20230613140635.975187-1-david.marchand@redhat.com> [not found] ` <20230620140704.171667-1-david.marchand@redhat.com> 2 siblings, 1 reply; 7+ messages in thread From: David Marchand @ 2023-06-13 8:17 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Brian Dooley, Gowrishankar Muthukrishnan Added sources were not referenced in the makefile used when compiling this example externally. Fixes: 36128a67c27e ("examples/fips_validation: add asymmetric validation") Fixes: b455d261eb89 ("examples/fips_validation: validate ECDSA") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- examples/fips_validation/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/fips_validation/Makefile b/examples/fips_validation/Makefile index bca6647f55..fbb778d57a 100644 --- a/examples/fips_validation/Makefile +++ b/examples/fips_validation/Makefile @@ -15,6 +15,8 @@ SRCS-y += fips_validation_ccm.c SRCS-y += fips_validation_sha.c SRCS-y += fips_dev_self_test.c SRCS-y += fips_validation_xts.c +SRCS-y += fips_validation_rsa.c +SRCS-y += fips_validation_ecdsa.c SRCS-y += main.c PKGCONF ?= pkg-config -- 2.40.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [EXT] [PATCH 1/4] examples/fips_validation: fix external build 2023-06-13 8:17 ` [PATCH 1/4] examples/fips_validation: fix external build David Marchand @ 2023-06-13 15:05 ` Gowrishankar Muthukrishnan 0 siblings, 0 replies; 7+ messages in thread From: Gowrishankar Muthukrishnan @ 2023-06-13 15:05 UTC (permalink / raw) To: David Marchand, dev; +Cc: thomas, bruce.richardson, stable, Brian Dooley Acked-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> Thanks. > -----Original Message----- > From: David Marchand <david.marchand@redhat.com> > Sent: Tuesday, June 13, 2023 1:48 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; bruce.richardson@intel.com; stable@dpdk.org; > Brian Dooley <brian.dooley@intel.com>; Gowrishankar Muthukrishnan > <gmuthukrishn@marvell.com> > Subject: [EXT] [PATCH 1/4] examples/fips_validation: fix external build > > External Email > > ---------------------------------------------------------------------- > Added sources were not referenced in the makefile used when compiling this > example externally. > > Fixes: 36128a67c27e ("examples/fips_validation: add asymmetric validation") > Fixes: b455d261eb89 ("examples/fips_validation: validate ECDSA") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > examples/fips_validation/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/examples/fips_validation/Makefile > b/examples/fips_validation/Makefile > index bca6647f55..fbb778d57a 100644 > --- a/examples/fips_validation/Makefile > +++ b/examples/fips_validation/Makefile > @@ -15,6 +15,8 @@ SRCS-y += fips_validation_ccm.c SRCS-y += > fips_validation_sha.c SRCS-y += fips_dev_self_test.c SRCS-y += > fips_validation_xts.c > +SRCS-y += fips_validation_rsa.c > +SRCS-y += fips_validation_ecdsa.c > SRCS-y += main.c > > PKGCONF ?= pkg-config > -- > 2.40.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20230613140635.975187-1-david.marchand@redhat.com>]
* [PATCH v2 1/4] examples/fips_validation: fix external build [not found] ` <20230613140635.975187-1-david.marchand@redhat.com> @ 2023-06-13 14:06 ` David Marchand 0 siblings, 0 replies; 7+ messages in thread From: David Marchand @ 2023-06-13 14:06 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Brian Dooley, Gowrishankar Muthukrishnan Added sources were not referenced in the makefile used when compiling this example externally. Fixes: 36128a67c27e ("examples/fips_validation: add asymmetric validation") Fixes: b455d261eb89 ("examples/fips_validation: validate ECDSA") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- examples/fips_validation/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/fips_validation/Makefile b/examples/fips_validation/Makefile index bca6647f55..fbb778d57a 100644 --- a/examples/fips_validation/Makefile +++ b/examples/fips_validation/Makefile @@ -15,6 +15,8 @@ SRCS-y += fips_validation_ccm.c SRCS-y += fips_validation_sha.c SRCS-y += fips_dev_self_test.c SRCS-y += fips_validation_xts.c +SRCS-y += fips_validation_rsa.c +SRCS-y += fips_validation_ecdsa.c SRCS-y += main.c PKGCONF ?= pkg-config -- 2.40.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20230620140704.171667-1-david.marchand@redhat.com>]
* [PATCH v3 1/4] examples/fips_validation: fix external build [not found] ` <20230620140704.171667-1-david.marchand@redhat.com> @ 2023-06-20 14:07 ` David Marchand 2023-06-21 6:23 ` David Marchand 2023-06-22 13:48 ` [PATCH] examples/l2fwd-cat: " Thomas Monjalon 1 sibling, 1 reply; 7+ messages in thread From: David Marchand @ 2023-06-20 14:07 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Brian Dooley, Gowrishankar Muthukrishnan Added sources were not referenced in the makefile used when compiling this example externally. Fixes: 36128a67c27e ("examples/fips_validation: add asymmetric validation") Fixes: b455d261eb89 ("examples/fips_validation: validate ECDSA") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- examples/fips_validation/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/fips_validation/Makefile b/examples/fips_validation/Makefile index bca6647f55..fbb778d57a 100644 --- a/examples/fips_validation/Makefile +++ b/examples/fips_validation/Makefile @@ -15,6 +15,8 @@ SRCS-y += fips_validation_ccm.c SRCS-y += fips_validation_sha.c SRCS-y += fips_dev_self_test.c SRCS-y += fips_validation_xts.c +SRCS-y += fips_validation_rsa.c +SRCS-y += fips_validation_ecdsa.c SRCS-y += main.c PKGCONF ?= pkg-config -- 2.40.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v3 1/4] examples/fips_validation: fix external build 2023-06-20 14:07 ` [PATCH v3 " David Marchand @ 2023-06-21 6:23 ` David Marchand 0 siblings, 0 replies; 7+ messages in thread From: David Marchand @ 2023-06-21 6:23 UTC (permalink / raw) To: dev Cc: thomas, bruce.richardson, stable, Brian Dooley, Gowrishankar Muthukrishnan On Tue, Jun 20, 2023 at 4:30 PM David Marchand <david.marchand@redhat.com> wrote: > > Added sources were not referenced in the makefile used when compiling > this example externally. > > Fixes: 36128a67c27e ("examples/fips_validation: add asymmetric validation") > Fixes: b455d261eb89 ("examples/fips_validation: validate ECDSA") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand <david.marchand@redhat.com> I forgot a tag on v1: Acked-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com> > Acked-by: Bruce Richardson <bruce.richardson@intel.com> -- David Marchand ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] examples/l2fwd-cat: fix external build [not found] ` <20230620140704.171667-1-david.marchand@redhat.com> 2023-06-20 14:07 ` [PATCH v3 " David Marchand @ 2023-06-22 13:48 ` Thomas Monjalon 2023-06-22 13:55 ` Thomas Monjalon 1 sibling, 1 reply; 7+ messages in thread From: Thomas Monjalon @ 2023-06-22 13:48 UTC (permalink / raw) To: dev Cc: David Marchand, stable, Tomasz Kantecki, Andrew Rybchenko, Natanael Copa From: David Marchand <david.marchand@redhat.com> cpu_set_t definition requires _GNU_SOURCE. Fixes: e0473c6d5b18 ("eal: fix build with musl") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- This patch was missing in the patchset to make all examples compile. It will be merged with others from: "Test examples compilation externally" --- examples/l2fwd-cat/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/l2fwd-cat/Makefile b/examples/l2fwd-cat/Makefile index 23a09550a4..d06053451a 100644 --- a/examples/l2fwd-cat/Makefile +++ b/examples/l2fwd-cat/Makefile @@ -35,6 +35,7 @@ endif endif CFLAGS += -DALLOW_EXPERIMENTAL_API +CFLAGS += -D_GNU_SOURCE LDFLAGS += -lpqos -- 2.41.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] examples/l2fwd-cat: fix external build 2023-06-22 13:48 ` [PATCH] examples/l2fwd-cat: " Thomas Monjalon @ 2023-06-22 13:55 ` Thomas Monjalon 0 siblings, 0 replies; 7+ messages in thread From: Thomas Monjalon @ 2023-06-22 13:55 UTC (permalink / raw) To: David Marchand Cc: dev, stable, Tomasz Kantecki, Andrew Rybchenko, Natanael Copa 22/06/2023 15:48, Thomas Monjalon: > From: David Marchand <david.marchand@redhat.com> > > cpu_set_t definition requires _GNU_SOURCE. > > Fixes: e0473c6d5b18 ("eal: fix build with musl") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > This patch was missing in the patchset to make all examples compile. > It will be merged with others from: > "Test examples compilation externally" Tested-by: Thomas Monjalon <thomas@monjalon.net> and applied. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-22 13:56 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20230613081741.4083273-1-david.marchand@redhat.com> 2023-06-13 8:17 ` [PATCH 1/4] examples/fips_validation: fix external build David Marchand 2023-06-13 15:05 ` [EXT] " Gowrishankar Muthukrishnan [not found] ` <20230613140635.975187-1-david.marchand@redhat.com> 2023-06-13 14:06 ` [PATCH v2 " David Marchand [not found] ` <20230620140704.171667-1-david.marchand@redhat.com> 2023-06-20 14:07 ` [PATCH v3 " David Marchand 2023-06-21 6:23 ` David Marchand 2023-06-22 13:48 ` [PATCH] examples/l2fwd-cat: " Thomas Monjalon 2023-06-22 13:55 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).