* [dpdk-stable] [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask [not found] <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> @ 2018-09-13 13:47 ` Jerin Jacob 2018-10-01 13:45 ` Ferruh Yigit [not found] ` <20181002105142.24333-1-jerin.jacob@caviumnetworks.com> 1 sibling, 1 reply; 7+ messages in thread From: Jerin Jacob @ 2018-09-13 13:47 UTC (permalink / raw) To: Olivier Matz; +Cc: dev, Jerin Jacob, stable, jiayu.hu Fixes missing PKT_TX_UDP_SEG value in PKT_TX_OFFLOAD_MASK. Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") Cc: stable@dpdk.org Cc: jiayu.hu@intel.com Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> --- lib/librte_mbuf/rte_mbuf.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 9ce5d76d7..6a5dbbc8f 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -343,7 +343,8 @@ extern "C" { PKT_TX_VLAN_PKT | \ PKT_TX_TUNNEL_MASK | \ PKT_TX_MACSEC | \ - PKT_TX_SEC_OFFLOAD) + PKT_TX_SEC_OFFLOAD | \ + PKT_TX_UDP_SEG) /** * Mbuf having an external buffer attached. shinfo in mbuf must be filled. -- 2.19.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask 2018-09-13 13:47 ` [dpdk-stable] [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask Jerin Jacob @ 2018-10-01 13:45 ` Ferruh Yigit 2018-10-01 15:53 ` Jerin Jacob 0 siblings, 1 reply; 7+ messages in thread From: Ferruh Yigit @ 2018-10-01 13:45 UTC (permalink / raw) To: Jerin Jacob, Olivier Matz; +Cc: dev, stable, jiayu.hu On 9/13/2018 2:47 PM, Jerin Jacob wrote: > Fixes missing PKT_TX_UDP_SEG value in PKT_TX_OFFLOAD_MASK. > > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > Cc: stable@dpdk.org > Cc: jiayu.hu@intel.com > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > --- > lib/librte_mbuf/rte_mbuf.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index 9ce5d76d7..6a5dbbc8f 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -343,7 +343,8 @@ extern "C" { > PKT_TX_VLAN_PKT | \ > PKT_TX_TUNNEL_MASK | \ > PKT_TX_MACSEC | \ > - PKT_TX_SEC_OFFLOAD) > + PKT_TX_SEC_OFFLOAD | \ > + PKT_TX_UDP_SEG) Also can you sort the list, it seem there was an intention to sort from high bits to low, but broken, it makes easy to recognize missing items later. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask 2018-10-01 13:45 ` Ferruh Yigit @ 2018-10-01 15:53 ` Jerin Jacob 2018-10-01 16:13 ` Ferruh Yigit 0 siblings, 1 reply; 7+ messages in thread From: Jerin Jacob @ 2018-10-01 15:53 UTC (permalink / raw) To: Ferruh Yigit; +Cc: Olivier Matz, dev, stable, jiayu.hu -----Original Message----- > Date: Mon, 1 Oct 2018 14:45:02 +0100 > From: Ferruh Yigit <ferruh.yigit@intel.com> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, Olivier Matz > <olivier.matz@6wind.com> > CC: dev@dpdk.org, stable@dpdk.org, jiayu.hu@intel.com > Subject: Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.9.1 > > > On 9/13/2018 2:47 PM, Jerin Jacob wrote: > > Fixes missing PKT_TX_UDP_SEG value in PKT_TX_OFFLOAD_MASK. > > > > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > > Cc: stable@dpdk.org > > Cc: jiayu.hu@intel.com > > > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > --- > > lib/librte_mbuf/rte_mbuf.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > > index 9ce5d76d7..6a5dbbc8f 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -343,7 +343,8 @@ extern "C" { > > PKT_TX_VLAN_PKT | \ > > PKT_TX_TUNNEL_MASK | \ > > PKT_TX_MACSEC | \ > > - PKT_TX_SEC_OFFLOAD) > > + PKT_TX_SEC_OFFLOAD | \ > > + PKT_TX_UDP_SEG) > > Also can you sort the list, it seem there was an intention to sort from high > bits to low, but broken, it makes easy to recognize missing items later. I think, sorting from high bits to low bits makes it easy to recognize. If it broken, How about fixing that(order based on bits) while rebasing to top of tree? I don't have strong opinion or sorting based on bit order vs name. Just shared my thought. Let me know your opinion, I will update it accordingly. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask 2018-10-01 15:53 ` Jerin Jacob @ 2018-10-01 16:13 ` Ferruh Yigit 0 siblings, 0 replies; 7+ messages in thread From: Ferruh Yigit @ 2018-10-01 16:13 UTC (permalink / raw) To: Jerin Jacob; +Cc: Olivier Matz, dev, stable, jiayu.hu On 10/1/2018 4:53 PM, Jerin Jacob wrote: > -----Original Message----- >> Date: Mon, 1 Oct 2018 14:45:02 +0100 >> From: Ferruh Yigit <ferruh.yigit@intel.com> >> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, Olivier Matz >> <olivier.matz@6wind.com> >> CC: dev@dpdk.org, stable@dpdk.org, jiayu.hu@intel.com >> Subject: Re: [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask >> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 >> Thunderbird/52.9.1 >> >> >> On 9/13/2018 2:47 PM, Jerin Jacob wrote: >>> Fixes missing PKT_TX_UDP_SEG value in PKT_TX_OFFLOAD_MASK. >>> >>> Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") >>> Cc: stable@dpdk.org >>> Cc: jiayu.hu@intel.com >>> >>> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> >>> --- >>> lib/librte_mbuf/rte_mbuf.h | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h >>> index 9ce5d76d7..6a5dbbc8f 100644 >>> --- a/lib/librte_mbuf/rte_mbuf.h >>> +++ b/lib/librte_mbuf/rte_mbuf.h >>> @@ -343,7 +343,8 @@ extern "C" { >>> PKT_TX_VLAN_PKT | \ >>> PKT_TX_TUNNEL_MASK | \ >>> PKT_TX_MACSEC | \ >>> - PKT_TX_SEC_OFFLOAD) >>> + PKT_TX_SEC_OFFLOAD | \ >>> + PKT_TX_UDP_SEG) >> >> Also can you sort the list, it seem there was an intention to sort from high >> bits to low, but broken, it makes easy to recognize missing items later. > > I think, sorting from high bits to low bits makes it easy to recognize. > If it broken, How about fixing that(order based on bits) while rebasing to top of tree? I am for order based on bits unless Olivier objects. > > I don't have strong opinion or sorting based on bit order vs name. Just shared > my thought. Let me know your opinion, I will update it accordingly. > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <20181002105142.24333-1-jerin.jacob@caviumnetworks.com>]
* [dpdk-stable] [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask [not found] ` <20181002105142.24333-1-jerin.jacob@caviumnetworks.com> @ 2018-10-02 10:51 ` Jerin Jacob 2018-10-04 2:31 ` Hu, Jiayu 0 siblings, 1 reply; 7+ messages in thread From: Jerin Jacob @ 2018-10-02 10:51 UTC (permalink / raw) To: Olivier Matz; +Cc: dev, Jerin Jacob, stable, jiayu.hu Fixes missing PKT_TX_UDP_SEG, PKT_TX_OUTER_IPV6,PKT_TX_OUTER_IPV4, PKT_TX_IPV6 and PKT_TX_IPV4 values in PKT_TX_OFFLOAD_MASK. Also sort them in bit wise order to recognize missing items later. Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels") Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with Rx ones") Cc: stable@dpdk.org Cc: jiayu.hu@intel.com Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> --- v2: - Add all missing PKT_TX_ types - Sort them in bit mask order(Ferruh Yigit) --- lib/librte_mbuf/rte_mbuf.h | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index a50b05c64..c8ebc3230 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -334,16 +334,21 @@ extern "C" { * which can be set for packet. */ #define PKT_TX_OFFLOAD_MASK ( \ + PKT_TX_OUTER_IPV6 | \ + PKT_TX_OUTER_IPV4 | \ + PKT_TX_OUTER_IP_CKSUM | \ + PKT_TX_VLAN_PKT | \ + PKT_TX_IPV6 | \ + PKT_TX_IPV4 | \ PKT_TX_IP_CKSUM | \ PKT_TX_L4_MASK | \ - PKT_TX_OUTER_IP_CKSUM | \ - PKT_TX_TCP_SEG | \ PKT_TX_IEEE1588_TMST | \ + PKT_TX_TCP_SEG | \ PKT_TX_QINQ_PKT | \ - PKT_TX_VLAN_PKT | \ PKT_TX_TUNNEL_MASK | \ PKT_TX_MACSEC | \ - PKT_TX_SEC_OFFLOAD) + PKT_TX_SEC_OFFLOAD | \ + PKT_TX_UDP_SEG) /** * Mbuf having an external buffer attached. shinfo in mbuf must be filled. -- 2.19.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask 2018-10-02 10:51 ` [dpdk-stable] [dpdk-dev] [PATCH v2 2/2] " Jerin Jacob @ 2018-10-04 2:31 ` Hu, Jiayu 2018-10-04 16:05 ` Ferruh Yigit 0 siblings, 1 reply; 7+ messages in thread From: Hu, Jiayu @ 2018-10-04 2:31 UTC (permalink / raw) To: Jerin Jacob, Olivier Matz; +Cc: dev, stable > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, October 2, 2018 6:52 PM > To: Olivier Matz <olivier.matz@6wind.com> > Cc: dev@dpdk.org; Jerin Jacob <jerin.jacob@caviumnetworks.com>; > stable@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com> > Subject: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask > > Fixes missing PKT_TX_UDP_SEG, > PKT_TX_OUTER_IPV6,PKT_TX_OUTER_IPV4, > PKT_TX_IPV6 and PKT_TX_IPV4 values in PKT_TX_OFFLOAD_MASK. > > Also sort them in bit wise order to recognize missing items later. > > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels") > Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with Rx > ones") > Cc: stable@dpdk.org > Cc: jiayu.hu@intel.com > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> Acked-by: Jiayu Hu <jiayu.hu@intel.com> Thanks, Jiayu > --- > v2: > - Add all missing PKT_TX_ types > - Sort them in bit mask order(Ferruh Yigit) > --- > lib/librte_mbuf/rte_mbuf.h | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index a50b05c64..c8ebc3230 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -334,16 +334,21 @@ extern "C" { > * which can be set for packet. > */ > #define PKT_TX_OFFLOAD_MASK ( \ > + PKT_TX_OUTER_IPV6 | \ > + PKT_TX_OUTER_IPV4 | \ > + PKT_TX_OUTER_IP_CKSUM | \ > + PKT_TX_VLAN_PKT | \ > + PKT_TX_IPV6 | \ > + PKT_TX_IPV4 | \ > PKT_TX_IP_CKSUM | \ > PKT_TX_L4_MASK | \ > - PKT_TX_OUTER_IP_CKSUM | \ > - PKT_TX_TCP_SEG | \ > PKT_TX_IEEE1588_TMST | \ > + PKT_TX_TCP_SEG | \ > PKT_TX_QINQ_PKT | \ > - PKT_TX_VLAN_PKT | \ > PKT_TX_TUNNEL_MASK | \ > PKT_TX_MACSEC | \ > - PKT_TX_SEC_OFFLOAD) > + PKT_TX_SEC_OFFLOAD | \ > + PKT_TX_UDP_SEG) > > /** > * Mbuf having an external buffer attached. shinfo in mbuf must be filled. > -- > 2.19.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask 2018-10-04 2:31 ` Hu, Jiayu @ 2018-10-04 16:05 ` Ferruh Yigit 0 siblings, 0 replies; 7+ messages in thread From: Ferruh Yigit @ 2018-10-04 16:05 UTC (permalink / raw) To: Hu, Jiayu, Jerin Jacob, Olivier Matz; +Cc: dev, stable On 10/4/2018 3:31 AM, Hu, Jiayu wrote: > > >> -----Original Message----- >> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] >> Sent: Tuesday, October 2, 2018 6:52 PM >> To: Olivier Matz <olivier.matz@6wind.com> >> Cc: dev@dpdk.org; Jerin Jacob <jerin.jacob@caviumnetworks.com>; >> stable@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com> >> Subject: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask >> >> Fixes missing PKT_TX_UDP_SEG, >> PKT_TX_OUTER_IPV6,PKT_TX_OUTER_IPV4, >> PKT_TX_IPV6 and PKT_TX_IPV4 values in PKT_TX_OFFLOAD_MASK. >> >> Also sort them in bit wise order to recognize missing items later. >> >> Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") >> Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels") >> Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with Rx >> ones") >> Cc: stable@dpdk.org >> Cc: jiayu.hu@intel.com >> >> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > Acked-by: Jiayu Hu <jiayu.hu@intel.com> Series applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-04 16:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180913134707.23698-1-jerin.jacob@caviumnetworks.com>
2018-09-13 13:47 ` [dpdk-stable] [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask Jerin Jacob
2018-10-01 13:45 ` Ferruh Yigit
2018-10-01 15:53 ` Jerin Jacob
2018-10-01 16:13 ` Ferruh Yigit
[not found] ` <20181002105142.24333-1-jerin.jacob@caviumnetworks.com>
2018-10-02 10:51 ` [dpdk-stable] [dpdk-dev] [PATCH v2 2/2] " Jerin Jacob
2018-10-04 2:31 ` Hu, Jiayu
2018-10-04 16:05 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).