From: Thomas Monjalon <thomas@monjalon.net>
To: Sarosh Arif <sarosh.arif@emumba.com>
Cc: dev@dpdk.org, drc@linux.vnet.ibm.com, maxime.coquelin@redhat.com,
zhihong.wang@intel.com, xiaolong.ye@intel.com,
bruce.richardson@intel.com, konstantin.ananyev@intel.com,
david.hunt@intel.com, jerinj@marvell.com, skori@marvell.com,
john.mcnamara@intel.com, kirill.rybalchenko@intel.com,
stable@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-stable] [PATCH] examples: fix return value of function that parses portmask
Date: Sat, 11 Jul 2020 12:00:58 +0200 [thread overview]
Message-ID: <2105820.9fF9r4LGxE@thomas> (raw)
In-Reply-To: <20200611123624.25319-1-sarosh.arif@emumba.com>
Why nobody reviewed? Isn't there some maintainers of example apps?
11/06/2020 14:36, Sarosh Arif:
> Giving invalid or zero portmask as command line option to
> these applications will have an unexpected response.
> The reason behind this is that the return value of function
> that parses portmask is stored in a variable whose datatype is
> unsigned int, hence returning -1 in case of zero or
> invalid portmask causes an unexpected behaviour.
After looking at few examples, the function returns a signed int.
> If we return 0 instead of -1 this issue can be resolved.
Yes, the caller of the function seems to expect 0 as error value.
> The program already contains the functionality to print
> "invalid portmask" and program usage if zero is returned.
>
> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
next prev parent reply other threads:[~2020-07-11 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 12:36 Sarosh Arif
2020-07-11 10:00 ` Thomas Monjalon [this message]
2020-07-21 16:07 ` Bruce Richardson
2020-07-30 21:08 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2105820.9fF9r4LGxE@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=kirill.rybalchenko@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=sarosh.arif@emumba.com \
--cc=skori@marvell.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).