From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A79B4160;
 Fri, 29 Dec 2017 12:07:34 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 29E2F2103B;
 Fri, 29 Dec 2017 06:07:34 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Fri, 29 Dec 2017 06:07:34 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=1FSbqf49/eXttcNmYyNweBJ/UJ
 fVh4RJ77e/rCXRGlc=; b=iNKp6cC/rbvt/vXxj3G25tExsBXdiAkdkA3d8VaVVi
 i/TPFYimwZiD2j2jbfCa4Pg80dHBZyj+FVAAhWXxR2Fk7aKQs8XMwkjeyPNLlxSY
 rxnS2GVUJJJfuNw4rtbqRKoZfm8TvY/SwhVWXTeWwokkTMN+RRYjivoeA2bc9SCr
 Y=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1FSbqf
 49/eXttcNmYyNweBJ/UJfVh4RJ77e/rCXRGlc=; b=kJql6PorFVNz9X4HDm1kUi
 zsTgHFjHJDFb3kpIdlo6f34xNwurrpE5KyRE8w72RVuh6ZVyCYMv9FZIxaaH4nY+
 JwBwLdWiGK7SJ/5LejJUQrwS3RWkohWezQIOK5NHIU57whIV0tEdIMFcgR+oCncO
 1ofi2gku5gpZCIOEb4uLrGPwJVlcz+Y4qA4TMfJy3/CxUq3PeScF1fa5kR9tfCq9
 X/VUpibW80G7FQWMIPmFUftcD2xakz61mklZCbhQk/rT/ofDyXtjc/Ukui6YuR2b
 pZLDgAmhaF2JRzGNpQr92jGTZKVQgyPpdcgrBWh8Lug2pKGclC/MI3sb42kKnvRw
 ==
X-ME-Sender: <xms:9iFGWleEq-WjFHioboI7dCD5xIU51gco_DESQRKiSbMLqjDQ5kZjjA>
Received: from xps.localnet (33.42.136.77.rev.sfr.net [77.136.42.33])
 by mail.messagingengine.com (Postfix) with ESMTPA id 2FF5E7E43A;
 Fri, 29 Dec 2017 06:07:33 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org
Date: Fri, 29 Dec 2017 12:07:08 +0100
Message-ID: <2110508.9oViqIghhz@xps>
In-Reply-To: <20171229075511.33180-1-zhiyong.yang@intel.com>
References: <20171228061210.64767-1-zhiyong.yang@intel.com>
 <20171229075511.33180-1-zhiyong.yang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-stable] [PATCH v2] bus/pci: fix wrong intr_handle.type
	with uio_pci_generic
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Dec 2017 11:07:34 -0000

29/12/2017 08:55, Zhiyong Yang:
> For virtio legacy device, testpmd startup fails when using
> uio_pci_generic. The issue is caused by invoking the function
> pci_ioport_map. The right intr_handle.type is already set before
> calling it, we should avoid overwriting the default value "RTE_
> INTR_HANDLE_UNKNOWN" in it. Besides, the removal has no harm to
> other cases since it already is set to this value (0) at init.

To be more precise, it is set to 0 by a memset on the whole struct
during allocation in the scan function (pci_scan_one).

> --- a/drivers/bus/pci/linux/pci.c
> +++ b/drivers/bus/pci/linux/pci.c
> @@ -723,7 +723,6 @@ pci_ioport_map(struct rte_pci_device *dev, int bar __rte_unused,
>  	if (!found)
>  		return -1;
>  
> -	dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN;

There is the same assignment in pci_vfio_map_resource_primary(),
pci_vfio_map_resource_secondary() and pci_uio_map_resource().

Please could you check why there is such assignments?