From: Thomas Monjalon <thomas@monjalon.net>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: Ilya Maximets <i.maximets@samsung.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8
Date: Mon, 14 Jan 2019 19:47:34 +0100 [thread overview]
Message-ID: <2111354.bjGcnvyq1o@xps> (raw)
In-Reply-To: <AM6PR08MB367257A5091665632A94051398800@AM6PR08MB3672.eurprd08.prod.outlook.com>
14/01/2019 17:50, Honnappa Nagarahalli:
> >
> > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined.
> > But 'rte_atomic.h' is a generic header that included to the external apps like
> > OVS while building with DPDK. As a result, clang build of OVS fails on ARMv8
> ^^^^^^
> Typo, should be armv8.
> Commit '40fd87486799' should have caught the typo issue. I don't want to do this for every patch 😊 Does 'check-git-log.sh' run automatically?
We are supposed to run it before submitting.
And tree maintainers run it before applying.
Anyway, it does check the title but not the message body.
prev parent reply other threads:[~2019-01-14 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190114161447eucas1p1c1d73ede17b706e69a4db491f8c94578@eucas1p1.samsung.com>
2019-01-14 16:14 ` [dpdk-stable] " Ilya Maximets
2019-01-14 16:27 ` Thomas Monjalon
2019-01-14 18:49 ` Thomas Monjalon
2019-01-14 19:06 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-01-14 16:46 ` Richardson, Bruce
2019-01-15 11:32 ` Ilya Maximets
2019-01-14 16:50 ` Honnappa Nagarahalli
2019-01-14 18:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2111354.bjGcnvyq1o@xps \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).