* [PATCH] devtools: fix escaped space in grep pattern
@ 2023-01-10 21:33 Thomas Monjalon
2023-01-10 21:52 ` Tyler Retzlaff
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2023-01-10 21:33 UTC (permalink / raw)
To: Sean Morrissey, Ferruh Yigit; +Cc: dev, David Marchand, stable
Since grep 3.8, a warning is printed if a space is escaped in a pattern:
grep: warning: stray \ before white space
There was an occurence of such extra backslash in check-git-log.sh.
Fixes: d448efa259e9 ("devtools: export dictionary for commit title check")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
devtools/check-git-log.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index 01d8aa0717..e26205814b 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -120,7 +120,7 @@ words="$selfdir/words-case.txt"
for word in $(cat $words); do
bad=$(echo "$headlines" | grep -iw $word | grep -vw $word)
if [ "$word" = "Tx" ]; then
- bad=$(echo $bad | grep -v 'OCTEON\ TX')
+ bad=$(echo $bad | grep -v 'OCTEON TX')
fi
for bad_line in $bad; do
bad_word=$(echo $bad_line | cut -d":" -f2 | grep -iwo $word)
--
2.39.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] devtools: fix escaped space in grep pattern
2023-01-10 21:33 [PATCH] devtools: fix escaped space in grep pattern Thomas Monjalon
@ 2023-01-10 21:52 ` Tyler Retzlaff
2023-01-11 8:57 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Tyler Retzlaff @ 2023-01-10 21:52 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Sean Morrissey, Ferruh Yigit, dev, David Marchand, stable
On Tue, Jan 10, 2023 at 10:33:17PM +0100, Thomas Monjalon wrote:
> Since grep 3.8, a warning is printed if a space is escaped in a pattern:
> grep: warning: stray \ before white space
>
> There was an occurence of such extra backslash in check-git-log.sh.
>
> Fixes: d448efa259e9 ("devtools: export dictionary for commit title check")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
thanks, it was annoying.
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] devtools: fix escaped space in grep pattern
2023-01-10 21:52 ` Tyler Retzlaff
@ 2023-01-11 8:57 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2023-01-11 8:57 UTC (permalink / raw)
To: Sean Morrissey; +Cc: stable, Ferruh Yigit, dev, David Marchand, Tyler Retzlaff
10/01/2023 22:52, Tyler Retzlaff:
> On Tue, Jan 10, 2023 at 10:33:17PM +0100, Thomas Monjalon wrote:
> > Since grep 3.8, a warning is printed if a space is escaped in a pattern:
> > grep: warning: stray \ before white space
> >
> > There was an occurence of such extra backslash in check-git-log.sh.
> >
> > Fixes: d448efa259e9 ("devtools: export dictionary for commit title check")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
>
> thanks, it was annoying.
>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-11 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10 21:33 [PATCH] devtools: fix escaped space in grep pattern Thomas Monjalon
2023-01-10 21:52 ` Tyler Retzlaff
2023-01-11 8:57 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).