patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: dev@dpdk.org, jingjing.wu@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] app/testpmd: support non contiguous socket ids
Date: Sun, 07 May 2017 14:14:49 +0200	[thread overview]
Message-ID: <213478826.uc3EAffF5t@xps> (raw)
In-Reply-To: <20170503134429.22723-1-shahafs@mellanox.com>

03/05/2017 15:44, Shahaf Shuler:
> +			printf("Invalid socket id, options are: ");
> +			for (i = 0; i < num_sockets; i++) {
> +				printf("%u%s", socket_ids[i],
> +				(i == num_sockets - 1) ? "\n" : ",");
[...]
> +			printf("Invalid socket id, options are: ");
> +			for (i = 0; i < num_sockets; i++) {
> +				printf("%u%s", socket_ids[i],
> +				(i == num_sockets - 1) ? "\n" : ",");
[...]
> +					printf("socket id options are: ");
> +					for (i = 0; i < num_sockets; i++) {
> +						printf("%u%s", socket_ids[i],
> +						(i == num_sockets - 1) ?
> +						"\n" : ",");

It is three times the same copy pasted code.
Please make a function.

  parent reply	other threads:[~2017-05-07 12:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 13:44 [dpdk-stable] " Shahaf Shuler
2017-05-06  1:41 ` Wu, Jingjing
2017-05-07  6:06   ` Shahaf Shuler
2017-05-08  0:54     ` Wu, Jingjing
2017-05-08 17:35       ` Shahaf Shuler
2017-05-09  0:43         ` Wu, Jingjing
2017-05-07 12:14 ` Thomas Monjalon [this message]
2017-05-07 13:05 ` [dpdk-stable] [PATCH v3] " Shahaf Shuler
2017-05-09  7:28   ` [dpdk-stable] [PATCH v4] app/testpmd: fix mempool creation by socket id Shahaf Shuler
2017-05-09  8:54     ` Wu, Jingjing
2017-05-10 16:41       ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=213478826.uc3EAffF5t@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).