patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs
@ 2018-05-18  9:59 zhiyong.yang
  2018-05-18  4:52 ` Yao, Lei A
  0 siblings, 1 reply; 21+ messages in thread
From: zhiyong.yang @ 2018-05-18  9:59 UTC (permalink / raw)
  To: dev
  Cc: maxime.coquelin, ferruh.yigit, tiwei.bie, lei.a.yao,
	bernard.iremonger, stable, Zhiyong Yang

For vdev, just calling rte_eth_dev_close() isn't enough to free all
the resources allocated during device probe, e.g. for virtio-user,
virtio_user_pmd_remove(), i.e. the remove() method of a vdev driver,
needs to be called to unlink the socket file created during device
probe. So this patch calls the rte_eth_dev_detach() for vdev when
quitting testpmd.

Cc: maxime.coquelin@redhat.com
Cc: ferruh.yigit@intel.com
Cc: tiwei.bie@intel.com
Cc: lei.a.yao@intel.com
Cc: bernard.iremonger@intel.com
Cc: stable@dpdk.org

Fixes: af75078fece3 ("first public release")
Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---

changes in V2:
1. change the pache title and add a fixes line.

 app/test-pmd/testpmd.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 134401603..1d308f056 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2011,6 +2011,8 @@ detach_port(portid_t port_id)
 void
 pmd_test_exit(void)
 {
+	const struct rte_bus *bus;
+	struct rte_device *device;
 	portid_t pt_id;
 	int ret;
 
@@ -2020,10 +2022,14 @@ pmd_test_exit(void)
 	if (ports != NULL) {
 		no_link_check = 1;
 		RTE_ETH_FOREACH_DEV(pt_id) {
+			device = rte_eth_devices[pt_id].device;
+			bus = rte_bus_find_by_device(device);
 			printf("\nShutting down port %d...\n", pt_id);
 			fflush(stdout);
 			stop_port(pt_id);
 			close_port(pt_id);
+			if (bus && !strcmp(bus->name, "vdev"))
+				detach_port(pt_id);
 		}
 	}
 
-- 
2.14.3

^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2018-05-23 11:58 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-18  9:59 [dpdk-stable] [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs zhiyong.yang
2018-05-18  4:52 ` Yao, Lei A
2018-05-18 10:18   ` Iremonger, Bernard
2018-05-18 10:21     ` Ferruh Yigit
2018-05-18 10:48     ` Ferruh Yigit
2018-05-18 15:55       ` [dpdk-stable] [dpdk-dev] " Matan Azrad
2018-05-18 16:29         ` Ferruh Yigit
2018-05-19 14:19           ` Thomas Monjalon
2018-05-21 10:54             ` Thomas Monjalon
2018-05-21 16:32               ` Ferruh Yigit
2018-05-21 16:38                 ` Thomas Monjalon
2018-05-22 13:12                   ` Thomas Monjalon
2018-05-22 18:38                     ` Ferruh Yigit
2018-05-22 19:48                       ` Thomas Monjalon
2018-05-23  1:52                         ` Yang, Zhiyong
2018-05-23 11:37                           ` Yang, Zhiyong
2018-05-23 11:58                             ` Thomas Monjalon
2018-05-21 16:37             ` Ferruh Yigit
2018-05-21 16:40               ` Thomas Monjalon
2018-05-21 16:44                 ` Ferruh Yigit
2018-05-21 19:12                   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).