From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68A3F45B13 for ; Fri, 11 Oct 2024 16:43:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5CD644065B; Fri, 11 Oct 2024 16:43:11 +0200 (CEST) Received: from fout-a8-smtp.messagingengine.com (fout-a8-smtp.messagingengine.com [103.168.172.151]) by mails.dpdk.org (Postfix) with ESMTP id 2710D40651; Fri, 11 Oct 2024 16:43:09 +0200 (CEST) Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 9FC1F13801F4; Fri, 11 Oct 2024 10:43:08 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Fri, 11 Oct 2024 10:43:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1728657788; x=1728744188; bh=vtwx96tXbGSdOr945QWsvgEeT6/0hEFjFZGibgrrv2Y=; b= TuNpdyWDixsYPNtJmZwAGquRou9zQPFXOU8EMAP86FUdRjY8XMVM4xiosc8iHqtI oqvMUd6b2mbS326T8j4yfzufIXMJxd0sPolxUtN4Mfer7qkPyV56B4U2I5xjMRfD ITnVHEGzjEJqV+Y/3CD5062iu1IXanG6y55KN/k9wY4TZ9q++GWUziswnDj8Zt+J QQiw94NezYaZMU17xOKO8Eabc1oW6glWZDTDGznHPK/az1GIuO7/HMUFDg8/EWsG vqJcLVVURX1EVMKZt1ZbhPn6o3MBKtPyQGAY+39tAqdMl+G0Vfq72rmRPosibPCU lPXArrBciQVvo18vba1D1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1728657788; x= 1728744188; bh=vtwx96tXbGSdOr945QWsvgEeT6/0hEFjFZGibgrrv2Y=; b=N PIHH4oa2pTwXNEmwTgZz8wKxeGwpq9SxXtDm2KDQisrxP2b+7XvL6iz9+FJg1adY 2uC8ZghVatf3Pa172W0mMgaXOjUpB3OJoCIICB6uWq97fQgwG4I3Z2Ao14uAcT+W FgD2UzgesDWBoBmOgWs/8ibcF5/b1ba2JDXN+P5UcqJcFwahPKK6/IxcWkvysAJe olUzkWoV4RN4CajoSaBat9z7bBlDLqpSIYvZ58PdXHkVwYaByeFPFgf+nrK+26rs 9+osGAY+7I1fzVRRtLFM00sGgHpGGNX8JabxE8vOjZVIDjeNZcnXcqZTDOmsku0L LmNhMQPmCMJP3m+5/OxtQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdefkedgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehrjhgrrh hrhiesrhgvughhrghtrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhgpdhr tghpthhtohepshhtrggslhgvseguphgukhdrohhrghdprhgtphhtthhopegsrhhutggvrd hrihgthhgrrhgushhonhesihhnthgvlhdrtghomh X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 11 Oct 2024 10:43:07 -0400 (EDT) From: Thomas Monjalon To: Robin Jarry Cc: dev@dpdk.org, stable@dpdk.org, Bruce Richardson Subject: Re: [PATCH dpdk] buildtools/cmdline: fix meson error when used as a subproject Date: Fri, 11 Oct 2024 16:43:05 +0200 Message-ID: <21410529.0c2gjJ1VT2@thomas> In-Reply-To: References: <20240801100153.41779-2-rjarry@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 07/08/2024 15:43, Bruce Richardson: > On Thu, Aug 01, 2024 at 12:01:54PM +0200, Robin Jarry wrote: > > Fix the following error when using dpdk as a subproject: > > > > subprojects/dpdk/buildtools/subproject/meson.build:28:56: > > ERROR: Unknown function "file". > > > > This was obviously never tested in its submitted form. > > > > Cc: stable@dpdk.org > > Fixes: 7d8c608faa7f ("buildtools/cmdline: allow using script in subproject") > > > > Signed-off-by: Robin Jarry > > --- > > Good catch, and easy fix, thanks. > > Interestingly, even without testing the build, vscode meson extension > flags this issue in the "problems" tab of vscode: "Unknown function `file`" > > Acked-by: Bruce Richardson Applied, thanks.