patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] doc: document a limitation for a meter with RSS action
@ 2021-10-26  2:08 Li Zhang
  2021-10-26  9:24 ` Li Zhang
                   ` (6 more replies)
  0 siblings, 7 replies; 15+ messages in thread
From: Li Zhang @ 2021-10-26  2:08 UTC (permalink / raw)
  To: orika, viacheslavo, matan, shahafs, Shun Hao
  Cc: dev, thomas, rasland, roniba, stable

A meter policy with RSS/Queue action is not supported
when dv_xmeta_en != 0.

Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
Cc: stable@dpdk.org

Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 47709d93b3..4129fe2009 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -435,6 +435,7 @@ Limitations
      - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
      - RED: must be DROP.
   - Policy actions of RSS for green and yellow should have the same configuration except queues.
+  - Policy with RSS/queue action is not supported when dv_xmeta_en != 0.
   - meter profile packet mode is supported.
   - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-stable] [PATCH] doc: document a limitation for a meter with RSS action
  2021-10-26  2:08 [dpdk-stable] [PATCH] doc: document a limitation for a meter with RSS action Li Zhang
@ 2021-10-26  9:24 ` Li Zhang
  2021-10-26  9:27 ` [dpdk-stable] [PATCH v2] " Li Zhang
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 15+ messages in thread
From: Li Zhang @ 2021-10-26  9:24 UTC (permalink / raw)
  To: orika, viacheslavo, matan, shahafs, Shun Hao
  Cc: dev, thomas, rasland, roniba, stable

A meter policy with RSS/Queue action is not supported
when dv_xmeta_en is not zero.

Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
Cc: stable@dpdk.org

Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 47709d93b3..4129fe2009 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -435,6 +435,7 @@ Limitations
      - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
      - RED: must be DROP.
   - Policy actions of RSS for green and yellow should have the same configuration except queues.
+  - Policy with RSS/queue action is not supported when dv_xmeta_en != 0.
   - meter profile packet mode is supported.
   - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-stable] [PATCH v2] doc: document a limitation for a meter with RSS action
  2021-10-26  2:08 [dpdk-stable] [PATCH] doc: document a limitation for a meter with RSS action Li Zhang
  2021-10-26  9:24 ` Li Zhang
@ 2021-10-26  9:27 ` Li Zhang
  2021-10-26  9:31 ` [dpdk-stable] [PATCH v3] " Li Zhang
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 15+ messages in thread
From: Li Zhang @ 2021-10-26  9:27 UTC (permalink / raw)
  To: orika, viacheslavo, matan, shahafs, Shun Hao
  Cc: dev, thomas, rasland, roniba, stable

A meter policy with RSS/Queue action is not supported
when dv_xmeta_en is not zero.

Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
Cc: stable@dpdk.org

Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 47709d93b3..4129fe2009 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -435,6 +435,7 @@ Limitations
      - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
      - RED: must be DROP.
   - Policy actions of RSS for green and yellow should have the same configuration except queues.
+  - Policy with RSS/queue action is not supported when dv_xmeta_en != 0.
   - meter profile packet mode is supported.
   - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-stable] [PATCH v3] doc: document a limitation for a meter with RSS action
  2021-10-26  2:08 [dpdk-stable] [PATCH] doc: document a limitation for a meter with RSS action Li Zhang
  2021-10-26  9:24 ` Li Zhang
  2021-10-26  9:27 ` [dpdk-stable] [PATCH v2] " Li Zhang
@ 2021-10-26  9:31 ` Li Zhang
  2021-10-26  9:51   ` Thomas Monjalon
  2021-10-26 10:10 ` [dpdk-stable] [PATCH v4] " Li Zhang
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 15+ messages in thread
From: Li Zhang @ 2021-10-26  9:31 UTC (permalink / raw)
  To: orika, viacheslavo, matan, shahafs, Shun Hao
  Cc: dev, thomas, rasland, roniba, stable

A meter policy with RSS/Queue action is not supported
when dv_xmeta_en is not zero.

Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
Cc: stable@dpdk.org

Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 47709d93b3..5d1d3a7f0e 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -435,6 +435,7 @@ Limitations
      - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
      - RED: must be DROP.
   - Policy actions of RSS for green and yellow should have the same configuration except queues.
+  - Policy with RSS/queue action is not supported when dv_xmeta_en is not zero.
   - meter profile packet mode is supported.
   - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-stable] [PATCH v3] doc: document a limitation for a meter with RSS action
  2021-10-26  9:31 ` [dpdk-stable] [PATCH v3] " Li Zhang
@ 2021-10-26  9:51   ` Thomas Monjalon
  2021-10-26 10:12     ` Li Zhang
  0 siblings, 1 reply; 15+ messages in thread
From: Thomas Monjalon @ 2021-10-26  9:51 UTC (permalink / raw)
  To: Li Zhang
  Cc: orika, viacheslavo, matan, shahafs, Shun Hao, dev, rasland,
	roniba, stable

26/10/2021 11:31, Li Zhang:
> A meter policy with RSS/Queue action is not supported
> when dv_xmeta_en is not zero.

It is still not explaining why.

> 
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
>    - Policy actions of RSS for green and yellow should have the same configuration except queues.
> +  - Policy with RSS/queue action is not supported when dv_xmeta_en is not zero.

It is still not enclosed like this: ``dv_xmeta_en``

Don't you think "enabled" is better than "not zero"?




^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-stable] [PATCH v4] doc: document a limitation for a meter with RSS action
  2021-10-26  2:08 [dpdk-stable] [PATCH] doc: document a limitation for a meter with RSS action Li Zhang
                   ` (2 preceding siblings ...)
  2021-10-26  9:31 ` [dpdk-stable] [PATCH v3] " Li Zhang
@ 2021-10-26 10:10 ` Li Zhang
  2021-10-26 10:15   ` Thomas Monjalon
  2021-10-26 11:53 ` [dpdk-stable] [PATCH v5] " Li Zhang
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 15+ messages in thread
From: Li Zhang @ 2021-10-26 10:10 UTC (permalink / raw)
  To: orika, viacheslavo, matan, shahafs, Shun Hao
  Cc: dev, thomas, rasland, roniba, stable

A meter policy with RSS/Queue action is not supported
when dv_xmeta_en enabled.

When dv_xmeta_en enabled in legacy creating flow,
it will split into two flows
(one set_tag with jump flow and one RSS/queue action flow).
For meter policy as termination table,
it cannot split flow and
cannot support dv_xmeta_en enabled.

Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
Cc: stable@dpdk.org

Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 47709d93b3..2f46ed0263 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -435,6 +435,7 @@ Limitations
      - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
      - RED: must be DROP.
   - Policy actions of RSS for green and yellow should have the same configuration except queues.
+  - Policy with RSS/queue action is not supported when dv_xmeta_en enabled.
   - meter profile packet mode is supported.
   - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-stable] [PATCH v3] doc: document a limitation for a meter with RSS action
  2021-10-26  9:51   ` Thomas Monjalon
@ 2021-10-26 10:12     ` Li Zhang
  0 siblings, 0 replies; 15+ messages in thread
From: Li Zhang @ 2021-10-26 10:12 UTC (permalink / raw)
  To: NBU-Contact-Thomas Monjalon
  Cc: Ori Kam, Slava Ovsiienko, Matan Azrad, Shahaf Shuler, Shun Hao,
	dev, Raslan Darawsheh, Roni Bar Yanai, stable

Thanks Thomas.
Will update the following commit-log in patch v4

A meter policy with RSS/Queue action is not supported
when dv_xmeta_en enabled.

When dv_xmeta_en enabled in legacy creating flow,
it will split into two flows (one set_tag with jump flow and one RSS/queue action flow).
For meter policy as termination table, it cannot split flow and cannot support
dv_xmeta_en enabled.


Regards,
Li Zhang

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Tuesday, October 26, 2021 5:51 PM
To: Li Zhang <lizh@nvidia.com>
Cc: Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>; Shun Hao <shunh@nvidia.com>; dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Roni Bar Yanai <roniba@nvidia.com>; stable@dpdk.org
Subject: Re: [PATCH v3] doc: document a limitation for a meter with RSS action

External email: Use caution opening links or attachments


26/10/2021 11:31, Li Zhang:
> A meter policy with RSS/Queue action is not supported when dv_xmeta_en 
> is not zero.

It is still not explaining why.

>
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
>    - Policy actions of RSS for green and yellow should have the same configuration except queues.
> +  - Policy with RSS/queue action is not supported when dv_xmeta_en is not zero.

It is still not enclosed like this: ``dv_xmeta_en``

Don't you think "enabled" is better than "not zero"?




^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-stable] [PATCH v4] doc: document a limitation for a meter with RSS action
  2021-10-26 10:10 ` [dpdk-stable] [PATCH v4] " Li Zhang
@ 2021-10-26 10:15   ` Thomas Monjalon
  2021-10-26 11:54     ` Li Zhang
  0 siblings, 1 reply; 15+ messages in thread
From: Thomas Monjalon @ 2021-10-26 10:15 UTC (permalink / raw)
  To: Li Zhang
  Cc: orika, viacheslavo, matan, shahafs, Shun Hao, dev, rasland,
	roniba, stable

26/10/2021 12:10, Li Zhang:
> A meter policy with RSS/Queue action is not supported
> when dv_xmeta_en enabled.
> 
> When dv_xmeta_en enabled in legacy creating flow,
> it will split into two flows
> (one set_tag with jump flow and one RSS/queue action flow).
> For meter policy as termination table,
> it cannot split flow and
> cannot support dv_xmeta_en enabled.

Thank you for the explanation.

> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  doc/guides/nics/mlx5.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index 47709d93b3..2f46ed0263 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -435,6 +435,7 @@ Limitations
>       - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
>       - RED: must be DROP.
>    - Policy actions of RSS for green and yellow should have the same configuration except queues.
> +  - Policy with RSS/queue action is not supported when dv_xmeta_en enabled.

Did you understand my comment about the formatting?
You must add quotes like that: ``dv_xmeta_en``
Look at other occurences in the doc.





^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-stable] [PATCH v5] doc: document a limitation for a meter with RSS action
  2021-10-26  2:08 [dpdk-stable] [PATCH] doc: document a limitation for a meter with RSS action Li Zhang
                   ` (3 preceding siblings ...)
  2021-10-26 10:10 ` [dpdk-stable] [PATCH v4] " Li Zhang
@ 2021-10-26 11:53 ` Li Zhang
  2021-10-26 12:28   ` Thomas Monjalon
  2021-10-27  5:39 ` [dpdk-stable] [PATCH v6] " Li Zhang
  2021-10-27  9:13 ` [dpdk-stable] [PATCH v7] doc: add metering limitation in mlx5 guide Li Zhang
  6 siblings, 1 reply; 15+ messages in thread
From: Li Zhang @ 2021-10-26 11:53 UTC (permalink / raw)
  To: orika, viacheslavo, matan, shahafs, Shun Hao
  Cc: dev, thomas, rasland, roniba, stable

A meter policy with RSS/Queue action is not supported
when ``dv_xmeta_en`` enabled.

When ``dv_xmeta_en`` enabled in legacy creating flow,
it will split into two flows
(one set_tag with jump flow and one RSS/queue action flow).
For meter policy as termination table,
it cannot split flow and
cannot support when ``dv_xmeta_en`` enabled.

Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
Cc: stable@dpdk.org

Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 47709d93b3..cd28c04c1e 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -435,6 +435,7 @@ Limitations
      - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
      - RED: must be DROP.
   - Policy actions of RSS for green and yellow should have the same configuration except queues.
+  - Policy with RSS/queue action is not supported when ``dv_xmeta_en`` enabled.
   - meter profile packet mode is supported.
   - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-stable] [PATCH v4] doc: document a limitation for a meter with RSS action
  2021-10-26 10:15   ` Thomas Monjalon
@ 2021-10-26 11:54     ` Li Zhang
  0 siblings, 0 replies; 15+ messages in thread
From: Li Zhang @ 2021-10-26 11:54 UTC (permalink / raw)
  To: NBU-Contact-Thomas Monjalon
  Cc: Ori Kam, Slava Ovsiienko, Matan Azrad, Shahaf Shuler, Shun Hao,
	dev, Raslan Darawsheh, Roni Bar Yanai, stable

Sorry, I misunderstood your comment and update it in patch v5.

Regards,
Li Zhang

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Tuesday, October 26, 2021 6:16 PM
To: Li Zhang <lizh@nvidia.com>
Cc: Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>; Shun Hao <shunh@nvidia.com>; dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Roni Bar Yanai <roniba@nvidia.com>; stable@dpdk.org
Subject: Re: [PATCH v4] doc: document a limitation for a meter with RSS action

External email: Use caution opening links or attachments


26/10/2021 12:10, Li Zhang:
> A meter policy with RSS/Queue action is not supported when dv_xmeta_en 
> enabled.
>
> When dv_xmeta_en enabled in legacy creating flow, it will split into 
> two flows (one set_tag with jump flow and one RSS/queue action flow).
> For meter policy as termination table, it cannot split flow and cannot 
> support dv_xmeta_en enabled.

Thank you for the explanation.

> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  doc/guides/nics/mlx5.rst | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 
> 47709d93b3..2f46ed0263 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -435,6 +435,7 @@ Limitations
>       - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
>       - RED: must be DROP.
>    - Policy actions of RSS for green and yellow should have the same configuration except queues.
> +  - Policy with RSS/queue action is not supported when dv_xmeta_en enabled.

Did you understand my comment about the formatting?
You must add quotes like that: ``dv_xmeta_en`` Look at other occurences in the doc.





^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-stable] [PATCH v5] doc: document a limitation for a meter with RSS action
  2021-10-26 11:53 ` [dpdk-stable] [PATCH v5] " Li Zhang
@ 2021-10-26 12:28   ` Thomas Monjalon
  2021-10-27  5:41     ` Li Zhang
  0 siblings, 1 reply; 15+ messages in thread
From: Thomas Monjalon @ 2021-10-26 12:28 UTC (permalink / raw)
  To: Li Zhang, rasland
  Cc: orika, viacheslavo, matan, shahafs, Shun Hao, dev, roniba, stable

The title should mention "mlx5 guide" as the scope.

26/10/2021 13:53, Li Zhang:
> A meter policy with RSS/Queue action is not supported
> when ``dv_xmeta_en`` enabled.

The quotes are RST syntax.
Raslan, while merging, you can remove the quotes from the commit log.

> 
> When ``dv_xmeta_en`` enabled in legacy creating flow,
> it will split into two flows
> (one set_tag with jump flow and one RSS/queue action flow).
> For meter policy as termination table,
> it cannot split flow and
> cannot support when ``dv_xmeta_en`` enabled.
> 
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  doc/guides/nics/mlx5.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index 47709d93b3..cd28c04c1e 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -435,6 +435,7 @@ Limitations
>       - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
>       - RED: must be DROP.
>    - Policy actions of RSS for green and yellow should have the same configuration except queues.
> +  - Policy with RSS/queue action is not supported when ``dv_xmeta_en`` enabled.
>    - meter profile packet mode is supported.
>    - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.




^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-stable] [PATCH v6] doc: document a limitation for a meter with RSS action
  2021-10-26  2:08 [dpdk-stable] [PATCH] doc: document a limitation for a meter with RSS action Li Zhang
                   ` (4 preceding siblings ...)
  2021-10-26 11:53 ` [dpdk-stable] [PATCH v5] " Li Zhang
@ 2021-10-27  5:39 ` Li Zhang
  2021-10-27  9:13 ` [dpdk-stable] [PATCH v7] doc: add metering limitation in mlx5 guide Li Zhang
  6 siblings, 0 replies; 15+ messages in thread
From: Li Zhang @ 2021-10-27  5:39 UTC (permalink / raw)
  To: orika, viacheslavo, matan, shahafs, Shun Hao
  Cc: dev, thomas, rasland, roniba, stable

A meter policy with RSS/Queue action is not supported
when dv_xmeta_en enabled.

When dv_xmeta_en enabled in legacy creating flow,
it will split into two flows
(one set_tag with jump flow and one RSS/queue action flow).
For meter policy as termination table,
it cannot split flow and
cannot support when dv_xmeta_en enabled.

Add this limitation in mlx5 guide document.

Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
Cc: stable@dpdk.org

Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 47709d93b3..cd28c04c1e 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -435,6 +435,7 @@ Limitations
      - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
      - RED: must be DROP.
   - Policy actions of RSS for green and yellow should have the same configuration except queues.
+  - Policy with RSS/queue action is not supported when ``dv_xmeta_en`` enabled.
   - meter profile packet mode is supported.
   - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-stable] [PATCH v5] doc: document a limitation for a meter with RSS action
  2021-10-26 12:28   ` Thomas Monjalon
@ 2021-10-27  5:41     ` Li Zhang
  0 siblings, 0 replies; 15+ messages in thread
From: Li Zhang @ 2021-10-27  5:41 UTC (permalink / raw)
  To: NBU-Contact-Thomas Monjalon, Raslan Darawsheh
  Cc: Ori Kam, Slava Ovsiienko, Matan Azrad, Shahaf Shuler, Shun Hao,
	dev, Roni Bar Yanai, stable

Thanks!
I will update it into patch v6 according to your comments.
Please take a look.

Regards,
Li Zhang

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Tuesday, October 26, 2021 8:28 PM
To: Li Zhang <lizh@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>
Cc: Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>; Shun Hao <shunh@nvidia.com>; dev@dpdk.org; Roni Bar Yanai <roniba@nvidia.com>; stable@dpdk.org
Subject: Re: [PATCH v5] doc: document a limitation for a meter with RSS action

External email: Use caution opening links or attachments


The title should mention "mlx5 guide" as the scope.

26/10/2021 13:53, Li Zhang:
> A meter policy with RSS/Queue action is not supported when 
> ``dv_xmeta_en`` enabled.

The quotes are RST syntax.
Raslan, while merging, you can remove the quotes from the commit log.

>
> When ``dv_xmeta_en`` enabled in legacy creating flow, it will split 
> into two flows (one set_tag with jump flow and one RSS/queue action 
> flow).
> For meter policy as termination table, it cannot split flow and cannot 
> support when ``dv_xmeta_en`` enabled.
>
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  doc/guides/nics/mlx5.rst | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 
> 47709d93b3..cd28c04c1e 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -435,6 +435,7 @@ Limitations
>       - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
>       - RED: must be DROP.
>    - Policy actions of RSS for green and yellow should have the same configuration except queues.
> +  - Policy with RSS/queue action is not supported when ``dv_xmeta_en`` enabled.
>    - meter profile packet mode is supported.
>    - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.




^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-stable] [PATCH v7] doc: add metering limitation in mlx5 guide
  2021-10-26  2:08 [dpdk-stable] [PATCH] doc: document a limitation for a meter with RSS action Li Zhang
                   ` (5 preceding siblings ...)
  2021-10-27  5:39 ` [dpdk-stable] [PATCH v6] " Li Zhang
@ 2021-10-27  9:13 ` Li Zhang
  2021-10-31 13:28   ` Raslan Darawsheh
  6 siblings, 1 reply; 15+ messages in thread
From: Li Zhang @ 2021-10-27  9:13 UTC (permalink / raw)
  To: orika, viacheslavo, matan, shahafs, Shun Hao
  Cc: dev, thomas, rasland, roniba, stable

A meter policy with RSS/Queue action is not supported
when dv_xmeta_en enabled.

When dv_xmeta_en enabled in legacy creating flow,
it will split into two flows
(one set_tag with jump flow and one RSS/queue action flow).
For meter policy as termination table,
it cannot split flow and
cannot support when dv_xmeta_en enabled.

Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
Cc: stable@dpdk.org

Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 47709d93b3..cd28c04c1e 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -435,6 +435,7 @@ Limitations
      - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
      - RED: must be DROP.
   - Policy actions of RSS for green and yellow should have the same configuration except queues.
+  - Policy with RSS/queue action is not supported when ``dv_xmeta_en`` enabled.
   - meter profile packet mode is supported.
   - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-stable] [PATCH v7] doc: add metering limitation in mlx5 guide
  2021-10-27  9:13 ` [dpdk-stable] [PATCH v7] doc: add metering limitation in mlx5 guide Li Zhang
@ 2021-10-31 13:28   ` Raslan Darawsheh
  0 siblings, 0 replies; 15+ messages in thread
From: Raslan Darawsheh @ 2021-10-31 13:28 UTC (permalink / raw)
  To: Li Zhang, Ori Kam, Slava Ovsiienko, Matan Azrad, Shahaf Shuler, Shun Hao
  Cc: dev, NBU-Contact-Thomas Monjalon, Roni Bar Yanai, stable

Hi,

> -----Original Message-----
> From: Li Zhang <lizh@nvidia.com>
> Sent: Wednesday, October 27, 2021 12:14 PM
> To: Ori Kam <orika@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf
> Shuler <shahafs@nvidia.com>; Shun Hao <shunh@nvidia.com>
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>; Raslan Darawsheh <rasland@nvidia.com>; Roni
> Bar Yanai <roniba@nvidia.com>; stable@dpdk.org
> Subject: [PATCH v7] doc: add metering limitation in mlx5 guide
> 
> A meter policy with RSS/Queue action is not supported when dv_xmeta_en
> enabled.
> 
> When dv_xmeta_en enabled in legacy creating flow, it will split into two
> flows (one set_tag with jump flow and one RSS/queue action flow).
> For meter policy as termination table,
> it cannot split flow and
> cannot support when dv_xmeta_en enabled.
> 
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2021-10-31 13:28 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26  2:08 [dpdk-stable] [PATCH] doc: document a limitation for a meter with RSS action Li Zhang
2021-10-26  9:24 ` Li Zhang
2021-10-26  9:27 ` [dpdk-stable] [PATCH v2] " Li Zhang
2021-10-26  9:31 ` [dpdk-stable] [PATCH v3] " Li Zhang
2021-10-26  9:51   ` Thomas Monjalon
2021-10-26 10:12     ` Li Zhang
2021-10-26 10:10 ` [dpdk-stable] [PATCH v4] " Li Zhang
2021-10-26 10:15   ` Thomas Monjalon
2021-10-26 11:54     ` Li Zhang
2021-10-26 11:53 ` [dpdk-stable] [PATCH v5] " Li Zhang
2021-10-26 12:28   ` Thomas Monjalon
2021-10-27  5:41     ` Li Zhang
2021-10-27  5:39 ` [dpdk-stable] [PATCH v6] " Li Zhang
2021-10-27  9:13 ` [dpdk-stable] [PATCH v7] doc: add metering limitation in mlx5 guide Li Zhang
2021-10-31 13:28   ` Raslan Darawsheh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).