patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: wangyunjian <wangyunjian@huawei.com>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	stable@dpdk.org, "rsanford2@gmail.com" <rsanford2@gmail.com>,
	"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
	xudingke <xudingke@huawei.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] malloc: cleanup coding style
Date: Sun, 22 Nov 2020 18:44:55 +0100	[thread overview]
Message-ID: <2171508.PB3JDZ5GFF@thomas> (raw)
In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60DB077B2@DGGEMM533-MBX.china.huawei.com>

12/11/2020 14:41, wangyunjian:
> From: Burakov, Anatoly [mailto:anatoly.burakov@intel.com]
> > On 12-Nov-20 9:31 AM, wangyunjian wrote:
> > > From: Yunjian Wang <wangyunjian@huawei.com>
> > >
> > > Cleanup code style issue reported by kernel checkpatch. As follows:
> > >    * ERROR:CODE_INDENT: code indent should use tabs where possible
> > >    * ERROR:SPACING: spaces required around that '?' (ctx:VxE)
> > >    * WARNING:INDENTED_LABEL: labels should not be indented
> > >
> > > Fixes: b0489e7bca2f ("malloc: fix linear complexity")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> > > ---
> > > --- a/lib/librte_eal/common/malloc_elem.c
> > > +++ b/lib/librte_eal/common/malloc_elem.c
> > > @@ -391,14 +391,14 @@ malloc_elem_free_list_index(size_t size)
> > >   		return 0;
> > >
> > >   	/* Find next power of 2 >= size. */
> > > -	log2 = sizeof(size) * 8 - __builtin_clzl(size-1);
> > > +	log2 = sizeof(size) * 8 - __builtin_clzl(size - 1);
> > >
> > >   	/* Compute freelist index, based on log2(size). */
> > >   	index = (log2 - MALLOC_MINSIZE_LOG2 +
> > MALLOC_LOG2_INCREMENT - 1) /
> > > -	        MALLOC_LOG2_INCREMENT;
> > > +		MALLOC_LOG2_INCREMENT;
> > 
> > Here and below, I believe we usually add two indents to the continuation
> > line, to avoid confusing with things like if statements.
> 
> It is already two indents in the patch. Please double check?

No it is two indents from the beginning of the line,
while Anatoly was asking for double additional indent.

> > With that fixed,

I fix it.

> > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks



      reply	other threads:[~2020-11-22 17:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-12  9:31 wangyunjian
2020-11-12 11:40 ` Burakov, Anatoly
2020-11-12 13:41   ` wangyunjian
2020-11-22 17:44     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2171508.PB3JDZ5GFF@thomas \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerry.lilijun@huawei.com \
    --cc=rsanford2@gmail.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).