From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4609A1AEE9; Sat, 7 Oct 2017 00:10:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AF02B20EF6; Fri, 6 Oct 2017 18:10:37 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 06 Oct 2017 18:10:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=pJwx/e4weF0JlCD /J0AyVuiQgQWC0hYXM1hUcWlM89E=; b=snblDe35TWZVvsgLJ0lCUDrDZk1W9i3 eHQFH6V1/aQDSTZReqyy4SY20hnHtafM7Z0el2dePxA2eu8KCOvWuGgW7/PhjFry PHUv0b3TX3jXcX8jM2ENmHbvDH4E6p5VREGjpaQtQlc8hSpsKc8ztTCpYZ48DL23 DLDcHmnDlNUk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=pJwx/e4weF0JlCD/J0AyVuiQgQWC0hYXM1hUcWlM89E=; b=MjOhw/6G qJEsWhpCAlZZ34af+vVD7dbqVBvuLIyv2oLovT3Ay0Pwy/JovsLfNljfl41xBeb4 e/yH2eRKRtPAkOZ6QFb9ShHwLVxBZ9Q94yKxkSrzGbT7E2WjHcro09QeQWHvKTBo X+3Ic66og11n/d/oNHMVhOFXEAFKLMSvdEpn7HmfzhU27pCVIDIDt4vkUjqKusY7 tCAHtutVyQw6tRmxreWjcGAr8GJ4Ww5ZyZLnooM/YWY+VT8y+HIVWPPAzB6hSZc2 qfG/HI8Qft1OI1Bu0pUdT4NXZHvm4TjWtt0AEF02V7CDpCV4PgaOAQbDgqDEFQuo Wz0R0lM5sPD03w== X-ME-Sender: X-Sasl-enc: zcGgrTyFa0Bhi3tfaHETMAHwKKMIRzKZBvtupksATorq 1507327837 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 67107247F0; Fri, 6 Oct 2017 18:10:37 -0400 (EDT) From: Thomas Monjalon To: Pablo de Lara Cc: dev@dpdk.org, Bruce Richardson , stable@dpdk.org Date: Sat, 07 Oct 2017 00:10:36 +0200 Message-ID: <2186124.KRdBs8CKvy@xps> In-Reply-To: <20170922134637.GA21280@bricha3-MOBL3.ger.corp.intel.com> References: <20170921124646.68253-1-pablo.de.lara.guarch@intel.com> <20170922042543.38362-1-pablo.de.lara.guarch@intel.com> <20170922134637.GA21280@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] hash: fix incorrect eviction counter X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 22:10:38 -0000 22/09/2017 15:46, Bruce Richardson: > On Fri, Sep 22, 2017 at 05:25:43AM +0100, Pablo de Lara wrote: > > When adding a new entry in a hash table, there is > > a maximum number of evictions that can be > > performed. When the counter of these evictions reaches > > this maximum, the entry cannot be added, as it is considered > > that the algorithm has encountered an infinite loop. > > > > The problem with the current implementation, is that this > > counter was declared as a static variable. > > If there are multiple threads adding entries in the same table > > or in different tables, they should access different counters, > > one per core and per table. > > > > Therefore, the variable has been modified to be non-static. > > > > Fixes: 243e93a5046f ("hash: fix unlimited cuckoo path") > > Cc: stable@dpdk.org > > > > Signed-off-by: Pablo de Lara > > --- > Acked-by: Bruce Richardson Applied, thanks