* [dpdk-stable] [PATCH] bus/pci: fix a typo
@ 2018-07-26 18:31 Rami Rosen
2018-07-26 18:37 ` Mcnamara, John
2018-07-26 19:20 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Rami Rosen @ 2018-07-26 18:31 UTC (permalink / raw)
To: dev; +Cc: stable, Rami Rosen
This patch fixes a trivial typo in pci_common.c.
Signed-off-by: Rami Rosen <rami.rosen@intel.com>
---
drivers/bus/pci/pci_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 94b0f41..8253a50 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -72,7 +72,7 @@ static struct rte_devargs *pci_devargs_lookup(struct rte_pci_device *dev)
*/
if (devargs != NULL)
/* If an rte_devargs exists, the generic rte_device uses the
- * given name as its namea
+ * given name as its name
*/
dev->device.name = dev->device.devargs->name;
else
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] bus/pci: fix a typo
2018-07-26 18:31 [dpdk-stable] [PATCH] bus/pci: fix a typo Rami Rosen
@ 2018-07-26 18:37 ` Mcnamara, John
2018-07-26 19:20 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Mcnamara, John @ 2018-07-26 18:37 UTC (permalink / raw)
To: Rosen, Rami, dev; +Cc: stable, Rosen, Rami
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Thursday, July 26, 2018 7:31 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Rosen, Rami <rami.rosen@intel.com>
> Subject: [dpdk-stable] [PATCH] bus/pci: fix a typo
>
> This patch fixes a trivial typo in pci_common.c.
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] bus/pci: fix a typo
2018-07-26 18:31 [dpdk-stable] [PATCH] bus/pci: fix a typo Rami Rosen
2018-07-26 18:37 ` Mcnamara, John
@ 2018-07-26 19:20 ` Thomas Monjalon
2018-07-26 19:25 ` Mcnamara, John
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2018-07-26 19:20 UTC (permalink / raw)
To: Rami Rosen; +Cc: stable, dev, gaetan.rivet, John McNamara
26/07/2018 20:31, Rami Rosen:
> This patch fixes a trivial typo in pci_common.c.
>
> Signed-off-by: Rami Rosen <rami.rosen@intel.com>
Fixes: 23eaa9059ec2 ("bus/pci: use given name as generic name")
Cc: gaetan.rivet@6wind.com
> --- a/drivers/bus/pci/pci_common.c
> +++ b/drivers/bus/pci/pci_common.c
> if (devargs != NULL)
> /* If an rte_devargs exists, the generic rte_device uses the
> - * given name as its namea
> + * given name as its name
> */
You can replace the "a" by a dot.
Applied with above changes, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [PATCH] bus/pci: fix a typo
2018-07-26 19:20 ` Thomas Monjalon
@ 2018-07-26 19:25 ` Mcnamara, John
0 siblings, 0 replies; 4+ messages in thread
From: Mcnamara, John @ 2018-07-26 19:25 UTC (permalink / raw)
To: Thomas Monjalon, Rosen, Rami; +Cc: stable, dev, gaetan.rivet
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, July 26, 2018 8:21 PM
> To: Rosen, Rami <rami.rosen@intel.com>
> Cc: stable@dpdk.org; dev@dpdk.org; gaetan.rivet@6wind.com; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: Re: [dpdk-stable] [PATCH] bus/pci: fix a typo
>
> 26/07/2018 20:31, Rami Rosen:
> > This patch fixes a trivial typo in pci_common.c.
> >
> > Signed-off-by: Rami Rosen <rami.rosen@intel.com>
>
> Fixes: 23eaa9059ec2 ("bus/pci: use given name as generic name")
> Cc: gaetan.rivet@6wind.com
>
> > --- a/drivers/bus/pci/pci_common.c
> > +++ b/drivers/bus/pci/pci_common.c
> > if (devargs != NULL)
> > /* If an rte_devargs exists, the generic rte_device uses the
> > - * given name as its namea
> > + * given name as its name
> > */
>
> You can replace the "a" by a dot.
>
> Applied with above changes, thanks.
Yes. I like to see comments as properly punctuated sentences.
other people have other preferences
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-26 19:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-26 18:31 [dpdk-stable] [PATCH] bus/pci: fix a typo Rami Rosen
2018-07-26 18:37 ` Mcnamara, John
2018-07-26 19:20 ` Thomas Monjalon
2018-07-26 19:25 ` Mcnamara, John
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).