patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH v2] usertools: dpdk-telemetry-client.py run into looping status
@ 2019-08-07 13:04 Andrius Sirvys
  2019-08-08  7:17 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  2019-08-08 14:37 ` [dpdk-stable] [PATCH v3] usertools: fix input handling in telemetry script Andrius Sirvys
  0 siblings, 2 replies; 5+ messages in thread
From: Andrius Sirvys @ 2019-08-07 13:04 UTC (permalink / raw)
  To: Kevin Laatz; +Cc: dev, stable, Andrius Sirvys

The ast.literal_eval() was used incorrectly and wouldn't properly
retrieve the user option. Was causing the options to keep being listed
in a loop. Removed and replaced with raw_input() being cast to an int.
Works as expected now.

Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
Cc: andrius.sirvys@intel.com

Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
---
v2: Removed unnecessary comments
---
 usertools/dpdk-telemetry-client.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index 4b0502ff9..b5b5cdcfe 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -16,9 +16,9 @@
 DEFAULT_FP = "/var/run/dpdk/default_client"
 
 try:
-	raw_input  # Python 2
+        raw_input  # Python 2
 except NameError:
-	raw_input = input  # Python 3
+        raw_input = input  # Python 3
 
 class Socket:
 
@@ -78,7 +78,7 @@ def requestMetrics(self): # Requests metrics for given client
 
     def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
         print("\nPlease enter the number of times you'd like to continuously request Metrics:")
-        n_requests = int(ast.literal_eval(raw_input("\n:")))
+        n_requests = int(raw_input("\n:"))
         print("\033[F") #Removes the user input from screen, cleans it up
         print("\033[K")
         for i in range(n_requests):
@@ -99,7 +99,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
             print("[4] Unregister client")
 
             try:
-                self.choice = int(ast.literal_eval(raw_input("\n:")))
+                self.choice = int(raw_input("\n:"))
                 print("\033[F") #Removes the user input for screen, cleans it up
                 print("\033[K")
                 if self.choice == 1:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-08-08 15:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07 13:04 [dpdk-stable] [PATCH v2] usertools: dpdk-telemetry-client.py run into looping status Andrius Sirvys
2019-08-08  7:17 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-08-08 14:37 ` [dpdk-stable] [PATCH v3] usertools: fix input handling in telemetry script Andrius Sirvys
2019-08-08 15:32   ` Van Haaren, Harry
2019-08-08 15:32   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).