From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FBB343196 for ; Wed, 18 Oct 2023 08:27:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4887640289; Wed, 18 Oct 2023 08:27:43 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 0740D4027C; Wed, 18 Oct 2023 08:27:42 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 98D72F146; Wed, 18 Oct 2023 08:27:41 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 8D02DF33C; Wed, 18 Oct 2023 08:27:41 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.6 X-Spam-Score: -1.5 Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 24B77F4BA; Wed, 18 Oct 2023 08:27:39 +0200 (CEST) Message-ID: <219c3495-d5ba-446b-a56f-f3bf5d65ffed@lysator.liu.se> Date: Wed, 18 Oct 2023 08:27:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] event/dsw: fix missing device pointer Content-Language: en-US To: Bruce Richardson , dev@dpdk.org Cc: mattias.ronnblom@ericsson.com, stable@dpdk.org, Jerin Jacob References: <20231016151713.711965-1-bruce.richardson@intel.com> <20231017164610.191852-1-bruce.richardson@intel.com> <20231017164610.191852-3-bruce.richardson@intel.com> From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <20231017164610.191852-3-bruce.richardson@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2023-10-17 18:46, Bruce Richardson wrote: > Initialize the "dev" pointer in the eventdev structure so it can be > returned in calls to "rte_event_dev_info_get()" and avoid potential > crashes due to a NULL value being passed to "rte_dev_name()" > > Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system") > Cc: mattias.ronnblom@ericsson.com > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > --- > drivers/event/dsw/dsw_evdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c > index 785c12f61f..44da3c60d1 100644 > --- a/drivers/event/dsw/dsw_evdev.c > +++ b/drivers/event/dsw/dsw_evdev.c > @@ -440,6 +440,7 @@ dsw_probe(struct rte_vdev_device *vdev) > return -EFAULT; > > dev->dev_ops = &dsw_evdev_ops; > + dev->dev = &vdev->device; > dev->enqueue = dsw_event_enqueue; > dev->enqueue_burst = dsw_event_enqueue_burst; > dev->enqueue_new_burst = dsw_event_enqueue_new_burst; Acked-by: Mattias Rönnblom