From: Kevin Traynor <ktraynor@redhat.com>
To: Chengwen Feng <fengchengwen@huawei.com>, stable@dpdk.org
Cc: david.marchand@redhat.com
Subject: Re: [PATCH 24.11 1/3] [PATCH 24.11] vhost: fix compile error when without vduse.h
Date: Tue, 25 Nov 2025 10:30:55 +0000 [thread overview]
Message-ID: <21aa83aa-b145-4412-b4ef-e607e2ca4964@redhat.com> (raw)
In-Reply-To: <20251125015130.12867-2-fengchengwen@huawei.com>
On 25/11/2025 01:51, Chengwen Feng wrote:
> Fix compile error when don't set VHOST_HAS_VDUSE.
>
> Fixes: 0ea4b51e84ce ("vhost: fix external buffer in VDUSE")
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
> lib/vhost/vduse.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/vduse.h b/lib/vhost/vduse.h
> index 353f297d5a..e923aeac56 100644
> --- a/lib/vhost/vduse.h
> +++ b/lib/vhost/vduse.h
> @@ -17,7 +17,7 @@ int vduse_device_destroy(const char *path);
> #else
>
> static inline int
> -vduse_device_create(const char *path, bool compliant_ol_flags, bool extbuf, bool linearbuf);
> +vduse_device_create(const char *path, bool compliant_ol_flags, bool extbuf, bool linearbuf)
> {
> RTE_SET_USED(compliant_ol_flags);
> RTE_SET_USED(extbuf);
Ah, thanks for finding this. This was a mistake in rebasing for 24.11
that was not caught as the VHOST_HAS_VDUSE is set.
The commit referenced is not pushed yet, so I will fix it directly there
before push, rather than introducing the issue and then fixing it.
Thanks again for catching it,
Kevin.
next prev parent reply other threads:[~2025-11-25 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 1:51 [PATCH 24.11 0/3] backport dmaperf bugfix Chengwen Feng
2025-11-25 1:51 ` [PATCH 24.11 1/3] [PATCH 24.11] vhost: fix compile error when without vduse.h Chengwen Feng
2025-11-25 10:30 ` Kevin Traynor [this message]
2025-11-26 0:39 ` fengchengwen
2025-11-25 1:51 ` [PATCH 24.11 2/3] [PATCH 24.11] app/dma-perf: fix on-flight DMA when verifying data Chengwen Feng
2025-11-25 1:51 ` [PATCH 24.11 3/3] [PATCH 24.11] app/dma-perf: fix stopping device Chengwen Feng
2025-11-27 11:45 ` [PATCH 24.11 0/3] backport dmaperf bugfix Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21aa83aa-b145-4412-b4ef-e607e2ca4964@redhat.com \
--to=ktraynor@redhat.com \
--cc=david.marchand@redhat.com \
--cc=fengchengwen@huawei.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).