* [PATCH] vhost: decrease log level for unimplemented request
@ 2022-12-06 15:02 Maxime Coquelin
2022-12-08 11:10 ` Kevin Traynor
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2022-12-06 15:02 UTC (permalink / raw)
To: dev, chenbo.xia, ktraynor, david.marchand; +Cc: Maxime Coquelin, stable
This patch changes VHOST_USER_SET_VRING_ERR "not
implemented" log level from INFO to DEBUG.
Indeed, it is not required to support this message type,
and since version 7.1, QEMU sends this message for every
queue. It could confuse the end-user, thinking there is an
issue where there are not.
Implementing it could be an option, but it does nothing
special on QEMU side but displaying an error message.
Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions")
Cc: stable@dpdk.org
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
lib/vhost/vhost_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 9902ae9944..371d6304d6 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -1809,7 +1809,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,
if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
close(ctx->fds[0]);
- VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
+ VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
return RTE_VHOST_MSG_RESULT_OK;
}
--
2.38.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost: decrease log level for unimplemented request
2022-12-06 15:02 [PATCH] vhost: decrease log level for unimplemented request Maxime Coquelin
@ 2022-12-08 11:10 ` Kevin Traynor
2023-01-27 11:37 ` Maxime Coquelin
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Traynor @ 2022-12-08 11:10 UTC (permalink / raw)
To: Maxime Coquelin, dev, chenbo.xia, david.marchand; +Cc: stable
On 06/12/2022 15:02, Maxime Coquelin wrote:
> This patch changes VHOST_USER_SET_VRING_ERR "not
> implemented" log level from INFO to DEBUG.
>
> Indeed, it is not required to support this message type,
> and since version 7.1, QEMU sends this message for every
> queue. It could confuse the end-user, thinking there is an
> issue where there are not.
>
> Implementing it could be an option, but it does nothing
> special on QEMU side but displaying an error message.
>
> Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> lib/vhost/vhost_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 9902ae9944..371d6304d6 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -1809,7 +1809,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,
>
> if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
> close(ctx->fds[0]);
> - VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
> + VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
>
> return RTE_VHOST_MSG_RESULT_OK;
> }
Debug level seem fine for this and this is what is done in QEMU. Not an
issue atm from what I see, but should we do the same for
VHOST_USER_SET_LOG_FD ?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost: decrease log level for unimplemented request
2022-12-08 11:10 ` Kevin Traynor
@ 2023-01-27 11:37 ` Maxime Coquelin
0 siblings, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2023-01-27 11:37 UTC (permalink / raw)
To: Kevin Traynor, dev, chenbo.xia, david.marchand; +Cc: stable
Hi Kevin,
On 12/8/22 12:10, Kevin Traynor wrote:
> On 06/12/2022 15:02, Maxime Coquelin wrote:
>> This patch changes VHOST_USER_SET_VRING_ERR "not
>> implemented" log level from INFO to DEBUG.
>>
>> Indeed, it is not required to support this message type,
>> and since version 7.1, QEMU sends this message for every
>> queue. It could confuse the end-user, thinking there is an
>> issue where there are not.
>>
>> Implementing it could be an option, but it does nothing
>> special on QEMU side but displaying an error message.
>>
>> Fixes: fd29c33b651a ("vhost: handle unsupported message types in
>> functions")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> lib/vhost/vhost_user.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
>> index 9902ae9944..371d6304d6 100644
>> --- a/lib/vhost/vhost_user.c
>> +++ b/lib/vhost/vhost_user.c
>> @@ -1809,7 +1809,7 @@ static int vhost_user_set_vring_err(struct
>> virtio_net **pdev,
>> if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
>> close(ctx->fds[0]);
>> - VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
>> + VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
>> return RTE_VHOST_MSG_RESULT_OK;
>> }
>
> Debug level seem fine for this and this is what is done in QEMU. Not an
> issue atm from what I see, but should we do the same for
> VHOST_USER_SET_LOG_FD ?
>
Right, it makes sense to do the same for VHOST_USER_SET_LOG_FD in the
sake of consistency.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-27 11:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-06 15:02 [PATCH] vhost: decrease log level for unimplemented request Maxime Coquelin
2022-12-08 11:10 ` Kevin Traynor
2023-01-27 11:37 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).