From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39E604560D for ; Fri, 12 Jul 2024 10:39:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EBDA402AE; Fri, 12 Jul 2024 10:39:01 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mails.dpdk.org (Postfix) with ESMTP id 6B2334027F; Fri, 12 Jul 2024 10:38:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1720773540; x=1752309540; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=m+z+61FExk2pHaeNeWcOzqH23AQzBMC1EeIWDscSz6I=; b=B1K1VMiY/c6ajbLrX+KR29k/T3eZotS65SO2qaJYfGj936Nj2QBCtugu 5txwoPrbDcwiXZ6QAH8OLmVNcj79zzdB+q2h/eUH+vW5JmLlurWS3zKhY 4JVvHoV/j0Q/U/bjnN7uKa6grxSqxjHx+q9rKp+6O9fPEweVozr9Gt3NN VpULbGnTsGFW5+OK5X4XdFJPdlq+rIANtkGr6a7EvRphFQ59QahPuTmFI C4ssacXlFLrjwxgwAqLDj35iBOLKu9U81nGmKzqyDZAW3xma36cif+ufl uyqla5sf0oMU+o7mXoUKSYcwIhqWv0vdBH0pZXOOSTti/vn0b1eofsAcC A==; X-CSE-ConnectionGUID: FR6ZkrHUQXecD6rRMoHqkA== X-CSE-MsgGUID: mjHhS41wTVCymL4EBZhM6w== X-IronPort-AV: E=McAfee;i="6700,10204,11130"; a="18047174" X-IronPort-AV: E=Sophos;i="6.09,202,1716274800"; d="scan'208";a="18047174" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jul 2024 01:38:57 -0700 X-CSE-ConnectionGUID: 5W8UqUpbT5Czcz07is0fEw== X-CSE-MsgGUID: 32FlHHp9R5qaLU5zAgbH8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,202,1716274800"; d="scan'208";a="48849782" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 Jul 2024 01:38:57 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 12 Jul 2024 01:38:57 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 12 Jul 2024 01:38:56 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 12 Jul 2024 01:38:56 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 12 Jul 2024 01:38:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OGiNkodhmKaZn6lv6x8TregqBDKh2NlIIGnUT408XmVki58Vb2K86Zmvgm7rzsW1QBrnXvwV8V9DstZphho2tY9ByPD4SJpHzgtoi4OJ7mtESWfCFWBQ1r3+PJbpFjYpHRQ11k69xjLI9z8X/IQ/pDgPPK3oRH+Z+pPDbKQafADilFSN4ouxfkQ353Dtly+qovMOiAM5HHnyURef1+SteoVQ7jXfzv3u4cvEgRrfULWn+WSe9TQqpwhunQwtUGg5M+a1WvaTaUNbeCzoorVmMunyTF8wt+AllIdDD9N8BfyV77pxI76MchX+MESuUldkj8KvMFxI4lSgROqnFsjvDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bxBNlzgBA0dLF6cyn0LfypDfAY2HY3Blv18pJehKfYc=; b=LPlQeq7CGA6RrsmEq7Khmc5LQgYtTG6b3fll3FcVNHm78QSWWUVGOcSwHJSNtrGT77wTBtoBKP5W/VR6/sr0OYrNKD6YWMusj/P5uzXNjAW0wD+ivIVSlQGyVw+y5TeriZHTFRGvlyNRa87J7puZGIV8AeACNATmcvFGQfyE10WgySwKWEAEtOrVcd9EOawH4MackU0auUMXbd/B9Jk1ZWCn2nAseoICyJD2H0culDQ5Bxnh2sI26unWC224QDl8TfC0sNNlT15pIdH4yPW4Qqee56wTLBow6aCNV7h5i2DvB0u5a1cwoOvD9a2dXxvU/t7vYg8OPd7UnTs0oIkW1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by DS0PR11MB6397.namprd11.prod.outlook.com (2603:10b6:8:ca::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.36; Fri, 12 Jul 2024 08:38:54 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%6]) with mapi id 15.20.7741.033; Fri, 12 Jul 2024 08:38:54 +0000 Message-ID: <21d1f4e2-bbd6-49cf-91d1-5917c57449b3@intel.com> Date: Fri, 12 Jul 2024 10:38:44 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] net/vdev: fix insert vdev core dump To: "Ye, MingjinX" , "dev@dpdk.org" CC: "stable@dpdk.org" References: <20240314093630.1066948-1-mingjinx.ye@intel.com> <20240314093630.1066948-4-mingjinx.ye@intel.com> <48edd8b1-715e-4363-b627-37a910d2dd70@intel.com> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU7P189CA0008.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:552::10) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|DS0PR11MB6397:EE_ X-MS-Office365-Filtering-Correlation-Id: e635a1f0-cc03-4137-07ca-08dca24e1009 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?NElYREp3VStlTmlOaU45cTQvc084Q3BnMisvaDBicWRmcktscjZCMmlvUDdR?= =?utf-8?B?QmRWTlNPdFlwVU05REswWTdLMWJtU29mbVlKdm5GTm05clJYZ1FQTUQxbjAv?= =?utf-8?B?Q0xQaEJlRHBhVitYRVByalF0K2VGOTY5d3d6UUtrMVNqVVBRTVMvN1VmT0lZ?= =?utf-8?B?UjRnbXJGQzQ2VGZRNnNmY2NxYVYrbGxUcGRIVXhvcHhzSWJJd2YyRXZlWGI0?= =?utf-8?B?TnNGWTZNR1NaNFYyRys0dnkrQ2xsUUdIamg3eCtRa280QUZnZithdHlDdi9S?= =?utf-8?B?Qk9XdW1jdW0zR2FaUTM1K2hkL29jZmh3cituaWJLZzZaYUVUTjIvM1ZKWEZu?= =?utf-8?B?OFNRQ1RZcDhFOXdpcDJDUEVrbE5wZkZmRTRoU0g2clUrVFJQb2Q5T1pOa3pJ?= =?utf-8?B?ZlpLWkhINit3ZUtncXg2aVplYWJFLytJWmZCVGtFc3RvZ0RFU1RwWW1OM2VD?= =?utf-8?B?VXFSdEd1UEFLNG5SejQwVy96eks2VWhxbnZYR2dZMndUNktld2JEaUdMVThh?= =?utf-8?B?LzVDVVFWa1FpRWVITzVxeUIzODkwYkFqZXBuelFoUThVRnE0VmpCU3ppVks1?= =?utf-8?B?dUFCcjdLdmJIYjRYSktZZ0k0OU9PUUVlSVFUTmREMkxaQVE1T2pkV0hUMlhu?= =?utf-8?B?SW1SdHBqS2ltWWJzOGVyOWFveUtDRk9yeVF2cytZb1pFdFN3SW5pNVA3NGFO?= =?utf-8?B?dU9XTEJ3T1N6SkRwd25GK3JVSDZEYzdGa016d3I1YU40U1Q4M3Q1S3ZIMDI0?= =?utf-8?B?TXJrbllwS2VTZ1BPSlYzQWluNEFVQXFVN2graXQ4cXFGa3VzRE5paDNMai9n?= =?utf-8?B?RmNUcTFaemhuTGFxNzA1OVlxaEpKYnpqb0RDTDlKdmh1VUFiNjVPOWhmNVQz?= =?utf-8?B?ektwRWZ1TTRrNXJscUYyemNQRHRqalFRTzJUZ0VLbGJndktCdkRscjBUNzM5?= =?utf-8?B?Y1hkTXNab1QzZnBPMytIQmQ3U1p4eXl4VFlIV0NJSGJ2dllwRDN5Wk1vdWdL?= =?utf-8?B?YmdYWTJrK1RSWllnU0o3MXpycTBQSlV0bTRQcElUTnFKa1dGbE5XQ240MTJN?= =?utf-8?B?cVRObGNXUytoTHlJQWtMZHk4Zno0NVVDeThwanZsdlJtUXIyVDQ0UkVaNWMv?= =?utf-8?B?SkNTcHZnU1RxRllZMWZpVUFWbDhqWXd6M3hPWlNJaCs0TDNrRkdCZFpuYWh1?= =?utf-8?B?RGZwTnJmcS9VWW4wbWpyNnhBOXNuemN4bktUN0ZtQVB0U0N1djdGcEVVNHo1?= =?utf-8?B?cDhLcThhZW41eUJKSUhvR2ZaV09TS1BtblgwWEl4UzJvcVF0TzQ1b3Q2WDZn?= =?utf-8?B?Z0J1QTdhUFFPYVphaUl0UmlaZHU2V2IwWTJ5dnN6M3hpa1huK1NPMkdDNHBm?= =?utf-8?B?L3ZxS2Y5UXBGQUxhdWVNcnlnVFg4dDJNVGZ6UlUyeThuS0s0azBRVm1odjBD?= =?utf-8?B?cUZ3N0lyREQ0ZEpiVFFkUGdwL1N5RGlXTENSYlRjOFFHZGRsbkhtaTc5K2hU?= =?utf-8?B?YXNiU3VoY0R1VkdRTlFCckJIcS8wOVF3clJkdkdrK0x3SFdDSExuQ2d6TWcw?= =?utf-8?B?cVd2TklCQkJBTEFCU0Rma2Z1eU1RTmdUKzJGMFFpZ1dJeHlyZVphS2ZvcnFr?= =?utf-8?B?elFGa29mbTNFVm9UZWlNdW9NVzdSMUdwMU1MYjlRRlYxcTNsSUJReC9xUXY5?= =?utf-8?B?QkFoSXNUVDhmNnc5bDk1QWZRMkdraE1RajFWQ0poUlNsYWYzRXpoY0hReUV4?= =?utf-8?B?Qk5WREpyUkMzZjhnYXRuSFovRFlMZVZyQXJZSGgzRWJZdlVWZHBrNDk1dlMx?= =?utf-8?B?WUxUejlsckVZamlWQk9DUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmI2eWljWkJhcnUrdm9MSXMwcm8zbFAreTdpN3pzV3hYYk0vTUM3M2F6eUJB?= =?utf-8?B?ZXZWcjNqaUJ2bytzOGZ4S2Z6VGpocGlHU3JsdVhoK253c09SeUVQWHhqMFZS?= =?utf-8?B?UjdOQ2Q4RHMzenZZeWJwU2RJb0xZTTVoR1hEU1BjR2phUnd2TGoxcElicHVr?= =?utf-8?B?R0hXL0hJazZybkdPNHMxcnVVcEZpbWd4dnc0cFJzb3Zpc0E2LzdnYXZMa2kz?= =?utf-8?B?U3ZpTm4wMXdCbUtHYkU2Vkt5TS82blNLOWFJWEtwcDlheUtha3Zyd1c5Q1E5?= =?utf-8?B?anhUYk50M3d0TFdJMFI2RlB1Qk50RmZDc253bWVpSFR4Umk0eWl6WEN1N0pL?= =?utf-8?B?TUhEZEEzNnJibXVkNGUxUUZwVW5lOTZoQStVVms1MmtOa3RmMG51MGMxVFNv?= =?utf-8?B?LzRkS2NLaTJORmx6SEZ6S29WeHpmSGd2Zk45dWV3V3duTkhhL0NtcnNlRmtq?= =?utf-8?B?RWdQNnV5QXJZbitJZ1dXYTVEcnRaZEdqQXdyN1VsNjl1M3U0bWZqUFNQMXpa?= =?utf-8?B?VXNEODZVa1E2Rk5JWFJpQ21SakkvN05QVDY3U0ZCUUxEMzRuWFhpeFdKM2l0?= =?utf-8?B?SzVZV1BWSFJ6WkVvSkFhUzdvZENSenFqVGJXT2FXZ1hNWmlBa3NtWjFJeS82?= =?utf-8?B?RnhGejBrSkFqeVNnajUxM1dSZk9BK3Zuc0JPTXc1eENTLzdMRU9jYThIeEs1?= =?utf-8?B?MVdSSDV3MzZ5QVVxajRNZjJWdnowRmVFUEt5cjJkSHJJQmFVeCtNLzZRVk9Y?= =?utf-8?B?TldTZ3pnUmdxcHpWUHh6RzdHbmpGbW5nMVhBeHRGU0cyZDgrZndQWDhRRTVN?= =?utf-8?B?RFZhcWo4UktYclh0OWJXODlJUHNDUVp4RnFKQVhQYkNxRE1vQzVmVWJkWDZO?= =?utf-8?B?NW9qajFJOFpsdkRDRTQ5bFBPQ2dsd29Tc3lYb3hhSE5peTJHN3R2c2tLTXBl?= =?utf-8?B?bkdEM25aaitSN0VQODQrQlVHdGxva0lWTWdoMHpFdG1rKy9EcHZvL3J2Vko3?= =?utf-8?B?SUxyVU1pd2V2ak1kNWVaNGhFRCtPRW5wR0lHVjF6aFE4SnlZZ0luS0tKT3BG?= =?utf-8?B?NXA5d3h3K1UwSWlRemhmV2EvNkExbTdkYk9DeVFhTS9zZTJ6VmVpRkJwL3gy?= =?utf-8?B?Qi9ZYTBRZHVWL2cxZDkyalRsSWUxTGZFZEdaT1VBeFpFZ1poa0QyeFhibTZO?= =?utf-8?B?ODFrVWgzU3ZISzZHWXZJWWQ3ZjR5R1VPUzd1SmlWNFNPS2RwemFvdFJVUXFS?= =?utf-8?B?OUpqU2l4S0QzaUIyRTNYYVhkK3FNbWphV0ZncVhXdE5wajlqOHZZcVdVQ2Fn?= =?utf-8?B?U0luN2JkN29sTXpabmxQamNzTWxmYTF4dVNoR1gzeGk5eFVJSkx6MjBIR3hW?= =?utf-8?B?aGl5WTFtZU9KUm1EblNTQzVtOFBCamtVRlV3MlFmNEJtQmdxY3BFQ2x3ZFZm?= =?utf-8?B?VHhiRE8zKzdHMUJ4S0dXd2JGS1lvdVZ1aTBYd2pSZExZTUJwMVJvTlNiT2ZM?= =?utf-8?B?Q1ZPem1nMUt4aDdIUDBPWXFUMjdzWVFWNVFJVHpHeEhWOXJlYlQxaTQyNytR?= =?utf-8?B?dVd2Y1VVR0FUZU1vK3dvQjVHcUtzMmFCKzhSbEkvNkFac3M0MktxbjNYQTd5?= =?utf-8?B?T3RXOGUyTDFHYzgwZnhPclVXMkZSdmNWL1hGWlZJNjladEQ0TTI1aUhvYmxM?= =?utf-8?B?bzA1NlhwUjB1Ri9KUEpCQmxqMTVldW5PY1cvZkprT09JcHZVaWhBWlJpV1NL?= =?utf-8?B?N0tONnJVZTNnYkZ3MTJKWEVMR0dMdjlxYkMxMmROZHl5dzd1UXpCVzJYaXhw?= =?utf-8?B?cnZ1SkJxNHBwTnJ0N2tvbkwwRkRqMzZiMnhnMUw0dWY5dWE4ZTliV3RnT2g4?= =?utf-8?B?ekp1OXpqYjB6cDErV2poQnM4Z2thdkpoVEd6UjYrYjI1UkY3T2xHSVFYNFlV?= =?utf-8?B?VmpFWEppOFJxajVmYzB2Q2prNDBaT28xOGtJRlNHK1J1aUF3TVFwbE5GQllI?= =?utf-8?B?QmhDQUZ3OFV2N21JQVZyWEpJRXNXZXJLRll4bmY1eTkzRmhBOG1WYVBFaDdw?= =?utf-8?B?UGx2OVEzaWxWMVRCUXVuMXhCaldPcW9Oa1h5T2U4ekg4SjIxNFZLcG43RXJZ?= =?utf-8?B?NUY5MDVZbzBsemU5VHZNeUx4bmxTRStVTlZmcVByZWw5T25MSkRFcFpNYWJQ?= =?utf-8?B?ZHc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e635a1f0-cc03-4137-07ca-08dca24e1009 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2024 08:38:54.1494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DrWnu9KBb+LXh1bBQQaS0AnGjA3eSP7vwtjC6HLStnA2Gy6hgLmyPmJpDU56j4ZrAMD3qezK8PnJ1Hqx6J/+Kuyt8HMXTmGoxLHcikvlj7E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6397 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 7/12/2024 4:18 AM, Ye, MingjinX wrote: > > >> -----Original Message----- >> From: Burakov, Anatoly >> Sent: Friday, July 12, 2024 12:10 AM >> To: Ye, MingjinX ; dev@dpdk.org >> Cc: stable@dpdk.org >> Subject: Re: [PATCH 3/3] net/vdev: fix insert vdev core dump >> >> On 3/14/2024 10:36 AM, Mingjin Ye wrote: >>> Inserting a vdev device when the device arguments are already stored >>> in devargs_list, the rte_devargs_insert function replaces the supplied >>> new devargs with the found devargs and frees the new devargs. As a >>> result, the use of free devargs results in a core dump. >>> >>> This patch fixes the issue by using valid devargs. >>> >>> Fixes: f3a1188cee4a ("devargs: make device representation generic") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Mingjin Ye >> >> I am not too familiar with how devargs works, so I have a trivial question. >> >> I understand the point of this patch, and it is roughly as follows: >> >> 1) we enter insert_vdev and allocated new devargs structure (and copy the >> `name` into devargs) >> 2) we set dev->device.name to devargs->name >> 3) we insert devargs into the list using rte_devargs_insert >> 4) if devargs list already had devargs with the same name, our devargs is >> destroyed and replaced with devargs that is in the list >> 5) because of this, dev->device.name becomes invalid as that specific >> devargs has been freed - it points to name from the old devargs >> >> We do need to store devargs->name in dev->device.name, and we need to >> do so after calling rte_devargs_insert to avoid keeping reference to memory >> that was freed. So, provisionally, >> >> Reviewed-by: Anatoly Burakov >> >> My question is, under what circumstances would there be duplicate entries >> in devargs list? > > In a multi-process circumstances, the primary and secondary processes both have "vdev" startup > Parameters. And their parameters have the same name. This causes multiple devargs objects with the same name > to be created in the secondary process, the 1st one constructed from the startup parameter and > the 2nd one constructed due to the VDEV_SCAN_ONE message received. > > Path 1: > eal_parse_args->eal_parse_common_option: OPT_VDEV_NUM > eal_option_device_parse->rte_devargs_add > > Path 2: > vdev_action: vdev_scan_one ->insert_vdev(alloc_devargs) So, technically, this is only a problem because we're specifying --vdev at secondary process startup even though we could've just relied on vdev multiprocess hotplug to provide us with a device? Or is there more to it? In any case, I think this patch is OK. I think the Fixes: tag is pointing to an incorrect commit. I've walked through the commit history, and it seems that this wasn't a bug initially, but became a bug when vdev multiprocess hotplug was added, so I think the correct Fixes: tag should be as follows: Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") So, on account of the above, I suggest rewording the commit message to something like the following: In secondary processes, insert_vdev() may be called multiple times on the same device due to a combination of multiprocess hotplug for vdev bus, and EAL argument adding the same vdev. In this circumstance, when rte_devargs_insert() is called, the devargs->name reference becomes invalid because rte_devargs_insert() will destroy the just-allocated devargs and will replace the pointer with one from the devargs list. As a result, the reference to devargs->name stored in dev->device.name becomes invalid. Fix the issue by not setting device name until after rte_devargs_insert() was called. Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") Cc: stable@dpdk.org Signed-off-by: Mingjin Ye Reviewed-by: Anatoly Burakov -- Thanks, Anatoly