Re: [dpdk-stable] [dpdk-dev] [PATCH v3 03/24] rte_common.h: cast gcc builtin result to avoid complaints

Re: [dpdk-stable] [dpdk-dev] [PATCH v3 03/24] rte_common.h: cast gcc builtin result to avoid complaints

[Thomas Monjalon]

12/05/2018 03:58, Andy Green:
> /projects/lagopus/src/dpdk/build/include/rte_common.h:416:9:
> warning: conversion to 'uint32_t' {aka 'unsigned int'} from
> 'int' may change the sign of the result [-Wsign-conversion]
>   return __builtin_ctz(v);
>          ^~~~~~~~~~~~~~~~
> 
> The builtin is defined to return int, but we want to
> return it as uint32_t.  Its only defined valid return
> values are positive integers or zero, which is OK for
> uint32_t.  So just add an explicit cast.

    Fixes: 03f6bced5bba ("eal: use intrinsic function")
    Cc: stable@dpdk.org

> Signed-off-by: Andy Green <andy@warmcat.com>

Applied, thanks

Re: [dpdk-stable] [dpdk-dev] [PATCH v3 05/24] lib/librte_eal: explicit cast for signed change

[Thomas Monjalon]

12/05/2018 03:59, Andy Green:
> /projects/lagopus/src/dpdk/build/include/rte_lcore.h:
> In function 'rte_lcore_index':
> /projects/lagopus/src/dpdk/build/include/rte_lcore.h:122:14:
> warning: conversion to 'int' from 'unsigned int' may change
> the sign of the result [-Wsign-conversion]
>    lcore_id = rte_lcore_id();

    Fixes: 5583037a7950 ("eal: get relative core index")
    Cc: stable@dpdk.org

> Signed-off-by: Andy Green <andy@warmcat.com>

Applied, thanks

Re: [dpdk-stable] [dpdk-dev] [PATCH v3 10/24] rte_dev.h: stack declaration at top of own basic block

[Thomas Monjalon]

12/05/2018 03:59, Andy Green:
> /projects/lagopus/src/dpdk/build/include/rte_dev.h:54:2:
> warning: ISO C90 forbids mixed declarations and
> code [-Wdeclaration-after-statement]
>   char buffer[vsnprintf(NULL, 0, fmt, ap) + 1];

    Fixes: b974e4a40cb5 ("ethdev: make error checking macros public")
    Cc: stable@dpdk.org

> Signed-off-by: Andy Green <andy@warmcat.com>

Applied, thanks

Re: [dpdk-stable] [dpdk-dev] [PATCH v3 07/24] rte_spinlock.h: stack declarations before code

[Thomas Monjalon]

12/05/2018 03:59, Andy Green:
> /projects/lagopus/src/dpdk/build/include/rte_spinlock.h:
> In function 'rte_try_tm':
> /projects/lagopus/src/dpdk/build/include/rte_spinlock.h:82:2:
> warning: ISO C90 forbids mixed declarations and code
> [-Wdeclaration-after-statement]
>   int retries = RTE_RTM_MAX_RETRIES;

    Fixes: ba7468997ea6 ("spinlock: add HTM lock elision for x86")
    Cc: stable@dpdk.org

> Signed-off-by: Andy Green <andy@warmcat.com>

Applied, thanks

Re: [dpdk-stable] [dpdk-dev] [PATCH v3 19/24] rte_ether.h: stack vars declared at top of function

[Thomas Monjalon]

12/05/2018 04:00, Andy Green:
> /projects/lagopus/src/dpdk/build/include/rte_ether.h:
> In function 'rte_vlan_strip':
> /projects/lagopus/src/dpdk/build/include/rte_ether.h:357:2:
> warning: ISO C90 forbids mixed declarations and code
> [-Wdeclaration-after-statement]
>   struct vlan_hdr *vh = (struct vlan_hdr *)(eh + 1);

    Fixes: c974021a5949 ("ether: add soft vlan encap/decap")
    Cc: stable@dpdk.org

> Signed-off-by: Andy Green <andy@warmcat.com>

Applied, thanks

Re: [dpdk-stable] [dpdk-dev] [PATCH v3 21/24] rte_ethdev.h: explicit cast for truncation

[Thomas Monjalon]

12/05/2018 04:00, Andy Green:
> /projects/lagopus/src/dpdk/build/include/rte_ethdev.h:
> In function 'rte_eth_tx_buffer_flush':
> /projects/lagopus/src/dpdk/build/include/rte_ethdev.h:4248:55:
> warning: conversion from 'int' to 'uint16_t'
> {aka 'short unsigned int'} may change value [-Wconversion]
>    buffer->error_callback(&buffer->pkts[sent], to_send - sent,

    Fixes: d6c99e62c852 ("ethdev: add buffered Tx")
    Cc: stable@dpdk.org

> Signed-off-by: Andy Green <andy@warmcat.com>

Applied, thanks

Re: [dpdk-stable] [dpdk-dev] [PATCH v3 22/24] rte_hash_crc.h: stack vars declared at top of function

[Thomas Monjalon]

12/05/2018 04:00, Andy Green:
> /projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:
> In function 'crc32c_2words':
> /projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:347:2:
> warning: ISO C90 forbids mixed declarations and code
> [-Wdeclaration-after-statement]
>   uint32_t crc, term1, term2;

    Fixes: d983cf41698f ("hash: add software CRC32 implementation")
    Cc: stable@dpdk.org

> Signed-off-by: Andy Green <andy@warmcat.com>

Applied, thanks

Re: [dpdk-stable] [dpdk-dev] [PATCH v3 23/24] rte_hash_crc.h: explicit casts for truncation

[Thomas Monjalon]

12/05/2018 04:00, Andy Green:
> /projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:
> In function 'crc32c_sse42_u64_mimic':
> /projects/lagopus/src/dpdk/build/include/rte_hash_crc.h:402:40:
> warning: conversion from 'uint64_t' {aka 'long unsigned int'}
> to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion]
>   init_val = crc32c_sse42_u32(d.u32[0], init_val);

    Fixes: 00bf774bab0b ("hash: add assembly implementation of CRC32 intrinsics")
    Cc: stable@dpdk.org

> Signed-off-by: Andy Green <andy@warmcat.com>

Applied, thanks