From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>,
stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH] devtools: move mailmap check after patch applied
Date: Tue, 28 Mar 2023 19:11:51 +0200 [thread overview]
Message-ID: <2215041.Dhsi8hcfAM@thomas> (raw)
In-Reply-To: <357c3e8a-9460-de86-6305-2faa8c7bdbef@amd.com>
28/03/2023 16:27, Ferruh Yigit:
> On 3/28/2023 2:52 PM, David Marchand wrote:
> > On Mon, Mar 27, 2023 at 4:52 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >>
> >> The names in a patch were possibly checked with checkpatches.sh
> >> before applying the patch, so before .mailmap file was updated.
> >>
> >> The check is moved and translated in check-git-log.sh,
> >> which is run only on a repository, not a detached patch file.
> >>
> >> Fixes: e83d41f0694d ("mailmap: add list of contributors")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > I don't really like how we rely on the IFS= change in the middle of
> > check-git-log.sh, but this change works.
> >
> > Reviewed-by: David Marchand <david.marchand@redhat.com>
>
> Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied
prev parent reply other threads:[~2023-03-28 17:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 14:52 Thomas Monjalon
2023-03-28 13:52 ` David Marchand
2023-03-28 14:27 ` Ferruh Yigit
2023-03-28 17:11 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2215041.Dhsi8hcfAM@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).