From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66E8FA09D9 for ; Wed, 11 Nov 2020 12:19:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A857D493D; Wed, 11 Nov 2020 12:19:04 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 68DBEF64; Wed, 11 Nov 2020 12:19:00 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 1AE595C0348; Wed, 11 Nov 2020 06:18:59 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 11 Nov 2020 06:18:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 4ucrF0LEtIKw8UVGMONs2ysALrygNctB1reHuhb8XOY=; b=eRnsq3DM5BrVzakC HZu3DngMKdKdxD8ZXKQ4DODifag48yD0ZFHAACCbk3fLmOS/EJRJfJ596aXO6uEl g0omZOxc1MojfyQcHISd6o63HY3xvuUzoQTkRH+4mjHIZsMAOwVhlrPZhutlZnU9 jagIOIxFp+L9txTSLgYo8vFy+gt8rqOqwoxgDsNIzIQA1dWPMGyIbYge4nevsqJT dX4oLOB3/SfhN8g3QrJ96GZmg0ZfwVckezl+Xe3zKO6meS2tTs+ntnNbNNGQRQHK iNYQxXJhT/MXX0NASccZ4GRR9AMYbb/22DrUAIFk8KJU469FhIj9FGPxcbeIPRlK AzJUdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=4ucrF0LEtIKw8UVGMONs2ysALrygNctB1reHuhb8X OY=; b=VdnWQRRt5Wm+NX8CNhDNuRgsbPdEiu83S8nQ+yLN4HYtRPt6nhdhbPMNP yegp/+t6T/LGXBrRxG2qzeu47P9/sL6aOyv9AHX8/fkgOcM3CyY6AbnXYfNU0RQ9 omdiWPkneANvCeBrGr+CGy1PQ0dJ+NX0qExIIKgSD2AOoNFwTfomtA7c4fLJEHEP /GaFh/1T5/SKjQ6WzQ/EQE0CfWs0X9y25rSZ4L1iEl/O4Ro6BgzjZ54+OtiAy3SU yv87QEGi33DGFM1lHucCaz/suKPOYrFGbaYggmlMGXR6teefvenN7FhDii4xrdU0 F3mzeUeZ8uSxqcqVthXT44xYUQ0jw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudduledgudefiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 012E13063067; Wed, 11 Nov 2020 06:18:57 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: Bruce Richardson , dev@dpdk.org, david.marchand@redhat.com, stable@dpdk.org, Luca Boccassi Date: Wed, 11 Nov 2020 12:18:57 +0100 Message-ID: <2250856.khoVdy575E@thomas> In-Reply-To: <9873b5ca-db70-60f3-a3c0-9c1d4bf5e22a@intel.com> References: <20201109210009.919129-1-thomas@monjalon.net> <20201111110049.GB1500@bricha3-MOBL.ger.corp.intel.com> <9873b5ca-db70-60f3-a3c0-9c1d4bf5e22a@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH 1/1] devtools: fix build test config inheritance from env X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 11/11/2020 12:13, Ferruh Yigit: > On 11/11/2020 11:00 AM, Bruce Richardson wrote: > > On Wed, Nov 11, 2020 at 11:37:41AM +0100, Thomas Monjalon wrote: > >> 11/11/2020 10:18, Bruce Richardson: > >>> On Tue, Nov 10, 2020 at 06:09:45PM +0000, Ferruh Yigit wrote: > >>>> On 11/10/2020 5:55 PM, Thomas Monjalon wrote: > >>>>> 10/11/2020 18:18, Ferruh Yigit: > >>>>>> On 11/9/2020 9:00 PM, Thomas Monjalon wrote: > >>>>>>> PKG_CONFIG_PATH is specific to each target, so it must be empty > >>>>>>> before configuring each build from the file according to DPDK_TARGET. > >>>>>>> Inheriting a default PKG_CONFIG_PATH for all targets does not make sense > >>>>>>> and is prone to confusion. > >>>>> [...] > >>>>>> In same run both 64bit and 32bit builds are done, > >>>>> > >>>>> Multiple targets can be built yes. > >>>>> > >>>>>> At least for my environment, > >>>>>> for 64bit, PKG_CONFIG_PATH should be '/usr/local/lib64/pkgconfig/' > >>>>>> for 32bit, PKG_CONFIG_PATH should be '/usr/lib/pkgconfig/' > >>>>> > >>>>> Not sure you need to set these values in PKG_CONFIG_PATH. > >>>>> At least /usr/lib/pkgconfig/ is already set in PKG_CONFIG_LIBDIR. > >>>>> > >>>>> Let me rephrase the man page of pkg-config: > >>>>> PKG_CONFIG_LIBDIR is the primary paths list > >>>>> PKG_CONFIG_PATH is the secondary paths list > >>>>> > >>>>>> What should I set in the config file to support both? > >>>>> > >>>>> The standard paths for your 64-bit machine should be built-in > >>>>> in your pkg-config. > >>>>> The standard path for 32-bit is already set automatically > >>>>> in devtools/test-meson-builds.sh. > >>>>> Only additional specific paths should be set in a config file. > >>>>> > >>>>> What is a config file? It is loaded by devtools/load-devel-config: > >>>>> - /etc/dpdk/devel.config (system-wide) > >>>>> - or ~/.config/dpdk/devel.config (user config) > >>>>> - or .develconfig (project directory config) > >>>>> Personally I set all my configs in ~/.config/dpdk/devel.config. > >>>>> Note that the same file is used to configure multiple tools. > >>>>> > >>>>> For each build, some variables are reset the variable DPDK_TARGET is set, > >>>>> and the config file is sourced. > >>>>> The typical values of DPDK_TARGET are: > >>>>> - i386-pc-linux-gnu > >>>>> - x86_64-pc-linux-gnu > >>>>> - x86_64-w64-mingw32 > >>>>> - aarch64-linux-gnu > >>>>> - powerpc64le-linux-gcc > >>>>> > >>>>> TLDR, I assume you just want to set an additional 64-bit path, > >>>>> so the config file should look like: > >>>>> > >>>>> if [ "$DPDK_TARGET" = x86_64-pc-linux-gnu ] ; then > >>>>> export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:/usr/local/lib64/pkgconfig > >>>>> fi > >>>>> > >>>>> > >>>> > >>>> Thanks for the clarification. > >>>> > >>>> Standard paths seems should be covered already in current script, which I > >>>> was trying to do with "export PKG_CONFIG_PATH=$CUSTOM_PKG_CONFIG_PATH" line > >>>> in my patch, > >>>> > >>>> I may be mixed 'PKG_CONFIG_LIBDIR' vs 'PKG_CONFIG_PATH' usage, let me check > >>>> it in my environment. > >>>> > >>> > >>> For just adding a new custom path for pkg-config using PKG_CONFIG_PATH. For > >>> building anything other than a native 64-bit build you need to override > >>> PKG_CONFIG_LIBDIR and clear PKG_CONFIG_PATH, otherwise the 64-bit packages > >>> will be found from the standard paths if not found in a 32-bit one. > >> > >> Yes, this is what is done in this patch (clearing PKG_CONFIG_PATH). > >> May I assume you are all OK with this patch now? > >> > > Yes, I previously acked it, I believe. > > > > 'PKG_CONFIG_LIBDIR' seems replaces the pkgconfig defaults, > 'PKG_CONFIG_PATH' adds paths to process *before* built-in ones. > > With adjustment according above, all looks good to me. > > What about unset the variable "uset PKG_CONFIG_PATH", to set it to empty to get > rid of the following line from logs: > "Using 'PKG_CONFIG_PATH' from environment with value: ''" Oh yes I didn't notice this message. The reason why I didn't unset was to allow referencing empty variable with shell option which forbids referencing unset ones: set -u. Now I think it's better to unset. > With or without about change, > Acked-by: Ferruh Yigit