[dpdk-stable] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag

[dpdk-stable] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag

[Sunil Kumar Kori]

Application uses different pool to allocate direct and indirect
mbufs which are further spliced together to consturct a fragmented
packet and same is transmitted over the port which is configured
with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
must belong to the same pool. But constructed packet violates
the conditions.

So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
configuration.

Fixes: fdb9eff67f0c ("examples/ip_fragmentation: convert to new offloads API")

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
v3:
 - Add Fixes tag
v2:
 - Subject is corrected.

 examples/ip_fragmentation/main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index 03be0c1..324d607 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config = {
 		n_tx_queue = nb_lcores;
 		if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
 			n_tx_queue = MAX_TX_QUEUE_PER_PORT;
-		if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
-			local_port_conf.txmode.offloads |=
-				DEV_TX_OFFLOAD_MBUF_FAST_FREE;
 		ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,
 					    &local_port_conf);
 		if (ret < 0) {
-- 
1.8.3.1

Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag

[Jerin Jacob Kollanukkaran]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Sunil Kumar Kori
> Sent: Thursday, July 25, 2019 1:54 PM
> To: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Sunil Kumar Kori <skori@marvell.com>
> Subject: [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload
> flag
> 
> Application uses different pool to allocate direct and indirect mbufs which are
> further spliced together to consturct a fragmented packet and same is
> transmitted over the port which is configured with
> DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments must belong
> to the same pool. But constructed packet violates the conditions.
> 
> So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
> configuration.
> 
> Fixes: fdb9eff67f0c ("examples/ip_fragmentation: convert to new offloads
> API")
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>

Reviewed-by: Jerin Jacob <jerinj@marvell.com>

Re: [dpdk-stable] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag

[Ananyev, Konstantin]

> -----Original Message-----
> From: Sunil Kumar Kori [mailto:skori@marvell.com]
> Sent: Thursday, July 25, 2019 9:24 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Sunil Kumar Kori <skori@marvell.com>
> Subject: [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag
> 
> Application uses different pool to allocate direct and indirect
> mbufs which are further spliced together to consturct a fragmented
> packet and same is transmitted over the port which is configured
> with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
> must belong to the same pool. But constructed packet violates
> the conditions.
> 
> So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
> configuration.
> 
> Fixes: fdb9eff67f0c ("examples/ip_fragmentation: convert to new offloads API")
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> v3:
>  - Add Fixes tag
> v2:
>  - Subject is corrected.
> 
>  examples/ip_fragmentation/main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
> index 03be0c1..324d607 100644
> --- a/examples/ip_fragmentation/main.c
> +++ b/examples/ip_fragmentation/main.c
> @@ -939,9 +939,6 @@ struct rte_lpm6_config lpm6_config = {
>  		n_tx_queue = nb_lcores;
>  		if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
>  			n_tx_queue = MAX_TX_QUEUE_PER_PORT;
> -		if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
> -			local_port_conf.txmode.offloads |=
> -				DEV_TX_OFFLOAD_MBUF_FAST_FREE;
>  		ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue,
>  					    &local_port_conf);
>  		if (ret < 0) {
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 1.8.3.1

Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/1] examples/ip_frag: fix Tx fast free offload flag

[Thomas Monjalon]

> > Application uses different pool to allocate direct and indirect
> > mbufs which are further spliced together to consturct a fragmented
> > packet and same is transmitted over the port which is configured
> > with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments
> > must belong to the same pool. But constructed packet violates
> > the conditions.
> > 
> > So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device
> > configuration.
> > 
> > Fixes: fdb9eff67f0c ("examples/ip_fragmentation: convert to new offloads API")
> > 
> > Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied, thanks