From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2FBFA0C41 for ; Tue, 9 Nov 2021 15:17:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DFC941102; Tue, 9 Nov 2021 15:17:06 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 0FE8C4068B; Tue, 9 Nov 2021 15:17:04 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 606215C00ED; Tue, 9 Nov 2021 09:17:03 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 09 Nov 2021 09:17:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= wwlmHFIBpNK5+WCv/6g4Xc5BLe6Py+VEYF5rxoP0inY=; b=iEIfbSMTMi1kiQzI E8IW7lIeb+obIoY1ZT4Yx3eKRFqzbPTnH37C7VseHmI3imYW+xZjumJBpoh/ujYO +oniVl8oEphCbHTihNQesWC3Qbae4wRWRr8ibNYJRSJtnhS1dcxwtg2JZlDx+Fav sUb9/WaKoUZV3kKHLfYUJsdMJhTsc6qFvGTWo4Yo01PtVD6jIcoJiyqmsXB/OQE4 DWQl7X0egzeHKxxx7/8OzUjpWRcIZe3jqBqiXi7S8PbCddXaNHZVadhVqeWNDXcP Ae9ZLVCS+GIH1S2h7eZnjBEqdBf8jr0ovTKyL6HhOcn+4IcOI07hZBa8coLFrL/Y IegHRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=wwlmHFIBpNK5+WCv/6g4Xc5BLe6Py+VEYF5rxoP0i nY=; b=HMm8s4FvuR9LzaC+kP36w9bN3yLwFqtqGOE8txZc3+tDytXp5LciE3Biv QerXgFtnfwC7DHe/RT2+BIEhGWsB4vUnRi2HQ6jIUz/ttAUAd8S2Px4bBZvTGW3v SlYUWlp5Xk1nVWyQEjmdo9J+amxVp/HgvO3bpL2QdNdQSfggn5x17fRCGMhn/Iwo k8NHvnO20/d0zJkzEiq/nYD0eYFKcYLYelPuwwaLsFEc3OPlJYqJF0PUysJ493Tc c7r5FB8+W2+E5kEQFBG3/kLEQlv/QEiFg6hj0bmU4Oj07z1DWp8BBWOhJ0bNj2in yKHaZkzXADJa9KYDDozzOw4J4VaUg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrudeggdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 9 Nov 2021 09:17:02 -0500 (EST) From: Thomas Monjalon To: Gregory Etelson Cc: "dev@dpdk.org" , Matan Azrad , Raslan Darawsheh , "stable@dpdk.org" , Anatoly Burakov , "david.marchand@redhat.com" Date: Tue, 09 Nov 2021 15:17:00 +0100 Message-ID: <2265443.MuN2qLDJi8@thomas> In-Reply-To: References: <20211026095037.17557-1-getelson@nvidia.com> <4872412.G4mxdARt5T@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH v2] examples/multi_proces: fix Rx packets distribution X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 09/11/2021 12:49, Gregory Etelson: > Hello Thomas, > > > 09/11/2021 10:58, Gregory Etelson: > > > - uint8_t client = 0; > > > + /* > > > + * C99: All objects with static storage > > duration > > > + * shall be initialized (set to their initial > > values) before > > > + * program startup. > > > + */ > > > > Why adding this comment? > > > > > + static uint8_t client; > > > > > > C99 optimization that was used here is not obvious. > The patch relies on client=0 initialization. > I added the comment to clarify why the client was not initialized. I think it is the C standard, not only C99. As far as I know, having static as 0 is obvious for a lot of people.