* [dpdk-stable] [dpdk-dev] [PATCH] mk: fix march for octeontx2 target
@ 2019-07-02 15:06 jerinj
2019-07-02 21:57 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: jerinj @ 2019-07-02 15:06 UTC (permalink / raw)
To: dev, Thomas Monjalon; +Cc: gavin.hu, Jerin Jacob, stable
From: Jerin Jacob <jerinj@marvell.com>
Correct the wrong -march=-mcpu=armv8.2-a+crc+crypto+lse for
octeontx2 target. Since rte_cc_has_argument drops invalid
CFLAG and -mcpu=octeontx2 picks up the correct optimization,
this typo is not noticed in performance testing.
Fixes: 01d184798731 ("config: add octeontx2 machine")
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
mk/machine/octeontx2/rte.vars.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/machine/octeontx2/rte.vars.mk b/mk/machine/octeontx2/rte.vars.mk
index cbec7f14d..e209cf492 100644
--- a/mk/machine/octeontx2/rte.vars.mk
+++ b/mk/machine/octeontx2/rte.vars.mk
@@ -30,5 +30,5 @@
include $(RTE_SDK)/mk/rte.helper.mk
-MACHINE_CFLAGS += $(call rte_cc_has_argument, -march=-mcpu=armv8.2-a+crc+crypto+lse)
+MACHINE_CFLAGS += $(call rte_cc_has_argument, -march=armv8.2-a+crc+crypto+lse)
MACHINE_CFLAGS += $(call rte_cc_has_argument, -mcpu=octeontx2)
--
2.21.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] mk: fix march for octeontx2 target
2019-07-02 15:06 [dpdk-stable] [dpdk-dev] [PATCH] mk: fix march for octeontx2 target jerinj
@ 2019-07-02 21:57 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2019-07-02 21:57 UTC (permalink / raw)
To: jerinj; +Cc: dev, gavin.hu, stable
02/07/2019 17:06, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
>
> Correct the wrong -march=-mcpu=armv8.2-a+crc+crypto+lse for
> octeontx2 target. Since rte_cc_has_argument drops invalid
> CFLAG and -mcpu=octeontx2 picks up the correct optimization,
> this typo is not noticed in performance testing.
>
> Fixes: 01d184798731 ("config: add octeontx2 machine")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-02 21:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-02 15:06 [dpdk-stable] [dpdk-dev] [PATCH] mk: fix march for octeontx2 target jerinj
2019-07-02 21:57 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).